* [PATCH for-5.8 1/2] usb: dwc3: meson-g12a: fix error path when fetching the reset line fails
From: Martin Blumenstingl @ 2020-05-26 20:29 UTC (permalink / raw)
To: balbi, gregkh, linux-usb, linux-amlogic, narmstrong
Cc: Martin Blumenstingl, hanjie.lin, linux-kernel, linux-arm-kernel,
yue.wang
In-Reply-To: <20200526202943.715220-1-martin.blumenstingl@googlemail.com>
Disable and unprepare the clocks when devm_reset_control_get_shared()
fails. This fixes the error path as this must disable the clocks which
were previously enabled.
Fixes: 1e355f21d3fb96 ("usb: dwc3: Add Amlogic A1 DWC3 glue")
Cc: Yue Wang <yue.wang@amlogic.com>
Cc: Hanjie Lin <hanjie.lin@amlogic.com>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
index bd744e82cad4..ce5388338389 100644
--- a/drivers/usb/dwc3/dwc3-meson-g12a.c
+++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
@@ -738,7 +738,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
if (IS_ERR(priv->reset)) {
ret = PTR_ERR(priv->reset);
dev_err(dev, "failed to get device reset, err=%d\n", ret);
- return ret;
+ goto err_disable_clks;
}
ret = reset_control_reset(priv->reset);
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related
* Re: next/master bisection: baseline.login on meson-sm1-sei610
From: Martin Blumenstingl @ 2020-05-26 20:32 UTC (permalink / raw)
To: Guillaume Tucker
Cc: Felipe Balbi, kernelci-results, Neil Armstrong,
Greg Kroah-Hartman, linux-usb, linux-kernel, linux-next,
Kevin Hilman, linux-amlogic, linux-arm-kernel
In-Reply-To: <ffe2c64c-62ed-9b59-3754-7ede0f0203be@collabora.com>
On Mon, May 25, 2020 at 10:39 AM Guillaume Tucker
<guillaume.tucker@collabora.com> wrote:
>
> Please see the bisection report below about a kernel Oops.
>
> Reports aren't automatically sent to the public while we're
> trialing new bisection features on kernelci.org but this one
> looks valid.
this one is valid indeed and I have sent a fix for it (plus an
unrelated fix): [0]
Also thank you for listening to feedback from a while ago.
This email reminded me to add the Reported-by tag :-)
Martin
[0] https://patchwork.kernel.org/cover/11571203/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [RFC 0/2] iommu: arm-smmu: Add support for early direct mappings
From: John Stultz @ 2020-05-26 20:34 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Robin Murphy, Joerg Roedel, iommu, Thierry Reding, linux-arm-msm,
linux-tegra, Will Deacon, linux-arm-kernel
In-Reply-To: <20200514193249.GE279327@builder.lan>
On Thu, May 14, 2020 at 12:34 PM <bjorn.andersson@linaro.org> wrote:
>
> On Thu 27 Feb 18:57 PST 2020, Bjorn Andersson wrote:
>
> Rob, Will, we're reaching the point where upstream has enough
> functionality that this is becoming a critical issue for us.
>
> E.g. Lenovo Yoga C630 is lacking this and a single dts patch to boot
> mainline with display, GPU, WiFi and audio working and the story is
> similar on several devboards.
>
> As previously described, the only thing I want is the stream mapping
> related to the display controller in place, either with the CB with
> translation disabled or possibly with a way to specify the framebuffer
> region (although this turns out to mess things up in the display
> driver...)
>
> I did pick this up again recently and concluded that by omitting the
> streams for the USB controllers causes an instability issue seen on one
> of the controller to disappear. So I would prefer if we somehow could
> have a mechanism to only pick the display streams and the context
> allocation for this.
>
>
> Can you please share some pointers/insights/wishes for how we can
> conclude on this subject?
Ping? I just wanted to follow up on this discussion as this small
series is crucial for booting mainline on the Dragonboard 845c
devboard. It would be really valuable to be able to get some solution
upstream so we can test mainline w/o adding additional patches.
The rest of the db845c series has been moving forward smoothly, but
this set seems to be very stuck with no visible progress since Dec.
Are there any pointers for what folks would prefer to see?
thanks
-john
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm
From: Will Deacon @ 2020-05-26 20:45 UTC (permalink / raw)
To: Nick Desaulniers, Catalin Marinas
Cc: Naohiro Aota, Stephen Boyd, Masahiro Yamada, linux-kernel,
Manoj Gupta, Luis Lozano, Nathan Chancellor, Vincenzo Frascino,
Will Deacon, linux-arm-kernel
In-Reply-To: <20200526173117.155339-1-ndesaulniers@google.com>
On Tue, 26 May 2020 10:31:14 -0700, Nick Desaulniers wrote:
> Custom toolchains that modify the default target to -mthumb cannot
> compile the arm64 compat vdso32, as
> arch/arm64/include/asm/vdso/compat_gettimeofday.h
> contains assembly that's invalid in -mthumb. Force the use of -marm,
> always.
Applied to arm64 (for-next/vdso), thanks!
[1/1] arm64: vdso32: force vdso32 to be compiled as -marm
https://git.kernel.org/arm64/c/20363b59ad4f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH] ACPI/IORT: Remove the unused __get_pci_rid()
From: Will Deacon @ 2020-05-26 20:45 UTC (permalink / raw)
To: sudeep.holla, guohanjun, lorenzo.pieralisi, Zenghui Yu
Cc: catalin.marinas, rjw, linux-kernel, linux-acpi, wanghaibin.wang,
Will Deacon, linux-arm-kernel, lenb
In-Reply-To: <20200509093430.1983-1-yuzenghui@huawei.com>
On Sat, 9 May 2020 17:34:30 +0800, Zenghui Yu wrote:
> Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for
> IOMMUs"), __get_pci_rid() has become actually unused and can be removed.
Applied to arm64 (for-next/acpi), thanks!
[1/1] ACPI/IORT: Remove the unused __get_pci_rid()
https://git.kernel.org/arm64/c/09cda9a71350
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v8 5/5] dt-bindings: chosen: Document linux,low-memory-range for arm64 kdump
From: Rob Herring @ 2020-05-26 21:18 UTC (permalink / raw)
To: chenzhou, James Morse
Cc: Simon Horman, John.p.donnelly, Baoquan He, Will Deacon,
devicetree, Catalin Marinas, Linux Doc Mailing List, kexec,
linux-kernel@vger.kernel.org, Ingo Molnar, Arnd Bergmann,
Hanjun Guo, Thomas Gleixner, pkushwaha, dyoung,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
In-Reply-To: <a419602e-6a85-ca35-39de-b3c26d433199@huawei.com>
On Fri, May 22, 2020 at 11:24:11AM +0800, chenzhou wrote:
> Hi Rob,
+James M (It's nice to Cc folks if you mention/quote them)
> On 2020/5/21 21:29, Rob Herring wrote:
> > On Thu, May 21, 2020 at 3:35 AM Chen Zhou <chenzhou10@huawei.com> wrote:
> >> Add documentation for DT property used by arm64 kdump:
> >> linux,low-memory-range.
> >> "linux,low-memory-range" is an another memory region used for crash
> >> dump kernel devices.
> >>
> >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> >> ---
> >> Documentation/devicetree/bindings/chosen.txt | 25 ++++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> > chosen is now a schema documented here[1].
> Ok, that is, i don't need to modify the doc in kernel, just create a pull request in github [1]?
>
> >
> >> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt
> >> index 45e79172a646..bfe6fb6976e6 100644
> >> --- a/Documentation/devicetree/bindings/chosen.txt
> >> +++ b/Documentation/devicetree/bindings/chosen.txt
> >> @@ -103,6 +103,31 @@ While this property does not represent a real hardware, the address
> >> and the size are expressed in #address-cells and #size-cells,
> >> respectively, of the root node.
> >>
> >> +linux,low-memory-range
> >> +----------------------
> >> +This property (arm64 only) holds a base address and size, describing a
> >> +limited region below 4G. Similar to "linux,usable-memory-range", it is
> >> +an another memory range which may be considered available for use by the
> >> +kernel.
> > Why can't you just add a range to "linux,usable-memory-range"? It
> > shouldn't be hard to figure out which part is below 4G.
> I did like this in my previous version, such as v5. After discussed with James, i modified it to the current way.
>
> We think the existing behavior should be unchanged, which helps with keeping compatibility with existing
> user-space and older kdump kernels.
>
> The comments from James:
> > linux,usable-memory-range = <BASE1 SIZE1 [BASE2 SIZE2]>.
> Won't this break if your kdump kernel doesn't know what the extra parameters are?
> Or if it expects two ranges, but only gets one? These DT properties should be treated as
> ABI between kernel versions, we can't really change it like this.
>
> I think the 'low' region is an optional-extra, that is never mapped by the first kernel. I
> think the simplest thing to do is to add an 'linux,low-memory-range' that we
> memblock_add() after memblock_cap_memory_range() has been called.
> If its missing, or the new kernel doesn't know what its for, everything keeps working.
I don't think there's a compatibility issue here though. The current
kernel doesn't care if the property is longer than 1 base+size. It only
checks if the size is less than 1 base+size. And yes, we can rely on
that implementation detail. It's only an ABI if an existing user
notices.
Now, if the low memory is listed first, then an older kdump kernel
would get a different memory range. If that's a problem, then define
that low memory goes last.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [GIT PULL] i.MX clock updates for 5.8
From: Stephen Boyd @ 2020-05-26 22:10 UTC (permalink / raw)
To: Shawn Guo
Cc: Stefan Agner, linux-imx, kernel, Fabio Estevam, linux-clk,
linux-arm-kernel
In-Reply-To: <20200523010732.GA9835@dragon>
Quoting Shawn Guo (2020-05-22 18:07:33)
> The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136:
>
> Linux 5.7-rc1 (2020-04-12 12:35:55 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git tags/clk-imx-5.8
>
> for you to fetch changes up to b1657ad708f761f9ca6d166d4dda685ca39b1254:
>
> clk: imx: use imx8m_clk_hw_composite_bus for i.MX8M bus clk slice (2020-05-21 22:37:48 +0800)
>
> ----------------------------------------------------------------
Thanks. Pulled into clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [GIT PULL 07/11] memory: tegra: Changes for v5.8-rc1
From: Stephen Boyd @ 2020-05-26 22:12 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding
Cc: Michael Turquette, Jon Hunter, SoC Team, arm-soc,
TEGRA ARCHITECTURE SUPPORT, linux-clk, Linux ARM
In-Reply-To: <20200526114054.GA2935745@ulmo>
Quoting Thierry Reding (2020-05-26 04:40:54)
> On Mon, May 25, 2020 at 11:52:30PM +0200, Arnd Bergmann wrote:
>
> > Waiting for clarification before I can pull this.
>
> Given the above, might be best to hold off on this for a bit until the
> clock branch was pulled by Mike or Stephen.
>
I pulled the clk branch into clk-next now.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V5 1/5] dt-bindings: clock: Convert i.MX6Q clock to json-schema
From: Rob Herring @ 2020-05-26 22:30 UTC (permalink / raw)
To: Anson Huang
Cc: devicetree, s.hauer, sboyd, festevam, mturquette, linux-kernel,
robh+dt, Linux-imx, kernel, shawnguo, linux-clk, linux-arm-kernel
In-Reply-To: <1589328684-1397-2-git-send-email-Anson.Huang@nxp.com>
On Wed, 13 May 2020 08:11:20 +0800, Anson Huang wrote:
> Convert the i.MX6Q clock binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
> Changes since V4:
> - add descriptions for interrupts and each item of it.
> ---
> .../devicetree/bindings/clock/imx6q-clock.txt | 41 ------------
> .../devicetree/bindings/clock/imx6q-clock.yaml | 72 ++++++++++++++++++++++
> 2 files changed, 72 insertions(+), 41 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.yaml
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V5 2/5] dt-bindings: clock: Convert i.MX6SX clock to json-schema
From: Rob Herring @ 2020-05-26 22:30 UTC (permalink / raw)
To: Anson Huang
Cc: devicetree, sboyd, shawnguo, mturquette, linux-kernel, linux-clk,
robh+dt, Linux-imx, kernel, festevam, s.hauer, linux-arm-kernel
In-Reply-To: <1589328684-1397-3-git-send-email-Anson.Huang@nxp.com>
On Wed, 13 May 2020 08:11:21 +0800, Anson Huang wrote:
> Convert the i.MX6SX clock binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
> Changes since V4:
> - add descriptions for interrupts and each item of it.
> ---
> .../devicetree/bindings/clock/imx6sx-clock.txt | 13 ----
> .../devicetree/bindings/clock/imx6sx-clock.yaml | 70 ++++++++++++++++++++++
> 2 files changed, 70 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/imx6sx-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/imx6sx-clock.yaml
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V5 3/5] dt-bindings: clock: Convert i.MX6SL clock to json-schema
From: Rob Herring @ 2020-05-26 22:31 UTC (permalink / raw)
To: Anson Huang
Cc: devicetree, s.hauer, sboyd, shawnguo, mturquette, linux-kernel,
robh+dt, Linux-imx, kernel, festevam, linux-clk, linux-arm-kernel
In-Reply-To: <1589328684-1397-4-git-send-email-Anson.Huang@nxp.com>
On Wed, 13 May 2020 08:11:22 +0800, Anson Huang wrote:
> Convert the i.MX6SL clock binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
> Changes since V4:
> - add descriptions for interrupts and each item of it.
> ---
> .../devicetree/bindings/clock/imx6sl-clock.txt | 10 -----
> .../devicetree/bindings/clock/imx6sl-clock.yaml | 48 ++++++++++++++++++++++
> 2 files changed, 48 insertions(+), 10 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/imx6sl-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/imx6sl-clock.yaml
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V5 4/5] dt-bindings: clock: Convert i.MX6SLL clock to json-schema
From: Rob Herring @ 2020-05-26 22:31 UTC (permalink / raw)
To: Anson Huang
Cc: devicetree, s.hauer, sboyd, festevam, mturquette, linux-kernel,
robh+dt, Linux-imx, kernel, shawnguo, linux-clk, linux-arm-kernel
In-Reply-To: <1589328684-1397-5-git-send-email-Anson.Huang@nxp.com>
On Wed, 13 May 2020 08:11:23 +0800, Anson Huang wrote:
> Convert the i.MX6SLL clock binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
> Changes since V4:
> - add descriptions for interrupts and each item of it.
> ---
> .../devicetree/bindings/clock/imx6sll-clock.txt | 36 ------------
> .../devicetree/bindings/clock/imx6sll-clock.yaml | 66 ++++++++++++++++++++++
> 2 files changed, 66 insertions(+), 36 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/imx6sll-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/imx6sll-clock.yaml
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v3 0/7] Statsfs: a new ram-based file system for Linux kernel statistics
From: Jakub Kicinski @ 2020-05-26 22:31 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito
Cc: linux-s390, kvm, linux-doc, netdev, Emanuele Giuseppe Esposito,
linux-kernel, kvm-ppc, Jonathan Adams, Christian Borntraeger,
Alexander Viro, David Rientjes, linux-fsdevel, Paolo Bonzini,
linux-mips, linuxppc-dev, linux-arm-kernel, Jim Mattson
In-Reply-To: <20200526110318.69006-1-eesposit@redhat.com>
On Tue, 26 May 2020 13:03:10 +0200 Emanuele Giuseppe Esposito wrote:
> There is currently no common way for Linux kernel subsystems to expose
> statistics to userspace shared throughout the Linux kernel; subsystems have
> to take care of gathering and displaying statistics by themselves, for
> example in the form of files in debugfs. For example KVM has its own code
> section that takes care of this in virt/kvm/kvm_main.c, where it sets up
> debugfs handlers for displaying values and aggregating them from various
> subfolders to obtain information about the system state (i.e. displaying
> the total number of exits, calculated by summing all exits of all cpus of
> all running virtual machines).
>
> Allowing each section of the kernel to do so has two disadvantages. First,
> it will introduce redundant code. Second, debugfs is anyway not the right
> place for statistics (for example it is affected by lockdown)
>
> In this patch series I introduce statsfs, a synthetic ram-based virtual
> filesystem that takes care of gathering and displaying statistics for the
> Linux kernel subsystems.
>
> The file system is mounted on /sys/kernel/stats and would be already used
> by kvm. Statsfs was initially introduced by Paolo Bonzini [1].
What's the direct motivation for this work? Moving KVM stats out of
debugfs?
In my experience stats belong in the API used for creating/enumerating
objects, statsfs sounds like going in the exact opposite direction -
creating a parallel structure / hierarchy for exposing stats. I know
nothing about KVM but are you sure all the info that has to be exposed
will be stats?
In case of networking we have the basic stats in sysfs, under the
netdevice's kobject. But since we're not using sysfs much any more
for config, new stats are added in netlink APIs. Again - same APIs
used for enumeration and config.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH V5 5/5] dt-bindings: clock: Convert i.MX6UL clock to json-schema
From: Rob Herring @ 2020-05-26 22:31 UTC (permalink / raw)
To: Anson Huang
Cc: devicetree, sboyd, festevam, s.hauer, linux-kernel, mturquette,
robh+dt, Linux-imx, kernel, shawnguo, linux-clk, linux-arm-kernel
In-Reply-To: <1589328684-1397-6-git-send-email-Anson.Huang@nxp.com>
On Wed, 13 May 2020 08:11:24 +0800, Anson Huang wrote:
> Convert the i.MX6UL clock binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
> Changes since V4:
> - add descriptions for interrupts and each item of it.
> ---
> .../devicetree/bindings/clock/imx6ul-clock.txt | 13 -----
> .../devicetree/bindings/clock/imx6ul-clock.yaml | 66 ++++++++++++++++++++++
> 2 files changed, 66 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/imx6ul-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* [PATCH] clk: versatile: remove redundant assignment to pointer clk
From: Colin King @ 2020-05-26 22:41 UTC (permalink / raw)
To: Linus Walleij, Michael Turquette, Stephen Boyd, linux-arm-kernel,
linux-clk
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer clk is being initialized with a value that is never read
and is being updated with a new value later on. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/clk/versatile/clk-versatile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/versatile/clk-versatile.c b/drivers/clk/versatile/clk-versatile.c
index fd54d5c0251c..8ed7a179f651 100644
--- a/drivers/clk/versatile/clk-versatile.c
+++ b/drivers/clk/versatile/clk-versatile.c
@@ -56,7 +56,7 @@ static const struct clk_icst_desc versatile_auxosc_desc __initconst = {
static void __init cm_osc_setup(struct device_node *np,
const struct clk_icst_desc *desc)
{
- struct clk *clk = ERR_PTR(-EINVAL);
+ struct clk *clk;
const char *clk_name = np->name;
const char *parent_name;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related
* Re: [PATCH v5 2/5] dt-bindings: atmel-tcb: convert bindings to json-schema
From: Rob Herring @ 2020-05-26 22:49 UTC (permalink / raw)
To: Kamel Bouhara
Cc: Mark Rutland, devicetree, Alexandre Belloni, linux-iio,
William Breathitt Gray, Ludovic Desroches, Thomas Petazzoni,
linux-input, linux-arm-kernel
In-Reply-To: <20200519083716.938384-3-kamel.bouhara@bootlin.com>
On Tue, May 19, 2020 at 10:37:13AM +0200, Kamel Bouhara wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> Convert Atmel Timer Counter Blocks bindings to DT schema format using
> json-schema.
>
> Also move it out of mfd as it is not and has never been related to mfd.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This should have your Sob too.
> ---
> .../devicetree/bindings/mfd/atmel-tcb.txt | 56 --------
> .../soc/microchip/atmel,at91rm9200-tcb.yaml | 126 ++++++++++++++++++
> 2 files changed, 126 insertions(+), 56 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-tcb.txt
> create mode 100644 Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt b/Documentation/devicetree/bindings/mfd/atmel-tcb.txt
> deleted file mode 100644
> index c4a83e364cb6..000000000000
> --- a/Documentation/devicetree/bindings/mfd/atmel-tcb.txt
> +++ /dev/null
> @@ -1,56 +0,0 @@
> -* Device tree bindings for Atmel Timer Counter Blocks
> -- compatible: Should be "atmel,<chip>-tcb", "simple-mfd", "syscon".
> - <chip> can be "at91rm9200" or "at91sam9x5"
> -- reg: Should contain registers location and length
> -- #address-cells: has to be 1
> -- #size-cells: has to be 0
> -- interrupts: Should contain all interrupts for the TC block
> - Note that you can specify several interrupt cells if the TC
> - block has one interrupt per channel.
> -- clock-names: tuple listing input clock names.
> - Required elements: "t0_clk", "slow_clk"
> - Optional elements: "t1_clk", "t2_clk"
> -- clocks: phandles to input clocks.
> -
> -The TCB can expose multiple subdevices:
> - * a timer
> - - compatible: Should be "atmel,tcb-timer"
> - - reg: Should contain the TCB channels to be used. If the
> - counter width is 16 bits (at91rm9200-tcb), two consecutive
> - channels are needed. Else, only one channel will be used.
> -
> -Examples:
> -
> -One interrupt per TC block:
> - tcb0: timer@fff7c000 {
> - compatible = "atmel,at91rm9200-tcb", "simple-mfd", "syscon";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0xfff7c000 0x100>;
> - interrupts = <18 4>;
> - clocks = <&tcb0_clk>, <&clk32k>;
> - clock-names = "t0_clk", "slow_clk";
> -
> - timer@0 {
> - compatible = "atmel,tcb-timer";
> - reg = <0>, <1>;
> - };
> -
> - timer@2 {
> - compatible = "atmel,tcb-timer";
> - reg = <2>;
> - };
> - };
> -
> -One interrupt per TC channel in a TC block:
> - tcb1: timer@fffdc000 {
> - compatible = "atmel,at91rm9200-tcb", "simple-mfd", "syscon";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0xfffdc000 0x100>;
> - interrupts = <26 4>, <27 4>, <28 4>;
> - clocks = <&tcb1_clk>, <&clk32k>;
> - clock-names = "t0_clk", "slow_clk";
> - };
> -
> -
> diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> new file mode 100644
> index 000000000000..4b683151265e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> @@ -0,0 +1,126 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/microchip/atmel,at91rm9200-tcb.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Atmel Timer Counter Block
> +
> +maintainers:
> + - Alexandre Belloni <alexandre.belloni@bootlin.com>
> +
> +description: |
> + The Atmel (now Microchip) SoCs have timers named Timer Counter Block. Each
> + timer has three channels with two counters each.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - atmel,at91rm9200-tcb
> + - atmel,at91sam9x5-tcb
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description:
> + List of interrupts. One interrupt per TCB channel if available or one
> + interrupt for the TC block
> + minItems: 1
> + maxItems: 3
> +
> + clock-names:
> + description:
> + List of clock names. Always includes t0_clk and slow clk. Also includes
> + t1_clk and t2_clk if a clock per channel is available.
This can express the 2nd sentence:
allOf:
- contains:
const: t0_clk
- contains:
const: slow_clk
> + minItems: 2
> + maxItems: 4
> + items:
> + enum:
> + - t0_clk
> + - t1_clk
> + - t2_clk
> + - slow_clk
> +
> + clocks:
> + minItems: 2
> + maxItems: 4
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +patternProperties:
> + "^timer@[0-2]$":
> + description: The timer block channels that are used as timers.
> + type: object
> + properties:
> + compatible:
> + const: atmel,tcb-timer
> + reg:
> + description:
> + List of channels to use for this particular timer.
> + minItems: 1
> + maxItems: 3
> +
> + required:
> + - compatible
> + - reg
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - '#address-cells'
> + - '#size-cells'
> +
> +examples:
> + - |
> + /* One interrupt per TC block: */
> + tcb0: timer@fff7c000 {
> + compatible = "atmel,at91rm9200-tcb", "simple-mfd", "syscon";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0xfff7c000 0x100>;
> + interrupts = <18 4>;
> + clocks = <&tcb0_clk>, <&clk32k>;
> + clock-names = "t0_clk", "slow_clk";
> +
> + timer@0 {
> + compatible = "atmel,tcb-timer";
> + reg = <0>, <1>;
> + };
> +
> + timer@2 {
> + compatible = "atmel,tcb-timer";
> + reg = <2>;
> + };
> + };
> +
> + /* One interrupt per TC channel in a TC block: */
> + tcb1: timer@fffdc000 {
> + compatible = "atmel,at91rm9200-tcb", "simple-mfd", "syscon";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0xfffdc000 0x100>;
> + interrupts = <26 4>, <27 4>, <28 4>;
> + clocks = <&tcb1_clk>, <&clk32k>;
> + clock-names = "t0_clk", "slow_clk";
> +
> + timer@0 {
> + compatible = "atmel,tcb-timer";
> + reg = <0>;
> + };
> +
> + timer@1 {
> + compatible = "atmel,tcb-timer";
> + reg = <1>;
> + };
> + };
> --
> 2.25.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v5 3/5] dt-bindings: microchip: atmel, at91rm9200-tcb: add sama5d2 compatible
From: Rob Herring @ 2020-05-26 22:50 UTC (permalink / raw)
To: Kamel Bouhara
Cc: Mark Rutland, devicetree, Alexandre Belloni, linux-iio,
William Breathitt Gray, Ludovic Desroches, Rob Herring,
Thomas Petazzoni, linux-input, linux-arm-kernel
In-Reply-To: <20200519083716.938384-4-kamel.bouhara@bootlin.com>
On Tue, 19 May 2020 10:37:14 +0200, Kamel Bouhara wrote:
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> The sama5d2 TC block TIMER_CLOCK1 is different from the at91sam9x5 one.
> Instead of being MCK / 2, it is the TCB GCLK.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> .../soc/microchip/atmel,at91rm9200-tcb.yaml | 36 +++++++++++++++----
> 1 file changed, 30 insertions(+), 6 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v5 4/5] dt-bindings: counter: microchip-tcb-capture counter
From: Rob Herring @ 2020-05-26 22:51 UTC (permalink / raw)
To: Kamel Bouhara
Cc: Mark Rutland, devicetree, Alexandre Belloni, linux-iio,
William Breathitt Gray, Ludovic Desroches, Rob Herring,
Thomas Petazzoni, linux-input, linux-arm-kernel
In-Reply-To: <20200519083716.938384-5-kamel.bouhara@bootlin.com>
On Tue, 19 May 2020 10:37:15 +0200, Kamel Bouhara wrote:
> Describe the devicetree binding for the Microchip TCB module.
> Each counter blocks exposes three independent counters.
>
> However, when configured in quadrature decoder, both channel <0> and <1>
> are required for speed/position and rotation capture (yet only the
> position is captured).
>
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> ---
> .../soc/microchip/atmel,at91rm9200-tcb.yaml | 32 +++++++++++++++++--
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v5 06/14] dt-bindings: PCI: cadence: Remove "mem" from reg binding
From: Rob Herring @ 2020-05-26 22:53 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: devicetree, Lorenzo Pieralisi, Arnd Bergmann, linux-pci,
linux-kernel, Tom Joseph, Greg Kroah-Hartman, Bjorn Helgaas,
linux-omap, linux-arm-kernel
In-Reply-To: <20200522033631.32574-7-kishon@ti.com>
On Fri, 22 May 2020 09:06:23 +0530, Kishon Vijay Abraham I wrote:
> "mem" is not a memory resource and it overlaps with PCIe config space
> and memory region. Removve "mem" from reg binding.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> .../devicetree/bindings/pci/cdns,cdns-pcie-host.yaml | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* [arm:cex7 88/106] arch/c6x/include/uapi/asm/swab.h:21:2: warning: 'px_is' may be used uninitialized in this function
From: kbuild test robot @ 2020-05-26 23:05 UTC (permalink / raw)
To: Peng Ma; +Cc: Russell King, kbuild-all, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 4683 bytes --]
tree: git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head: 96bd73e4644e76befe9ab998e070a679ae08388c
commit: 04d1ec3ed831580aadbdac12b36b6158ad80dad4 [88/106] ahci: qoriq: workaround for errata A-379364 on lx2160a
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 04d1ec3ed831580aadbdac12b36b6158ad80dad4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/ata/ahci_qoriq.c:19:
drivers/ata/ahci.h:384:16: warning: initialized field overwritten [-Woverride-init]
384 | .can_queue = AHCI_MAX_CMDS, | ^~~~~~~~~~~~~
drivers/ata/ahci_qoriq.c:304:2: note: in expansion of macro 'AHCI_SHT'
304 | AHCI_SHT(DRV_NAME),
| ^~~~~~~~
drivers/ata/ahci.h:384:16: note: (near initialization for 'ahci_qoriq_sht.can_queue')
384 | .can_queue = AHCI_MAX_CMDS, | ^~~~~~~~~~~~~
drivers/ata/ahci_qoriq.c:304:2: note: in expansion of macro 'AHCI_SHT'
304 | AHCI_SHT(DRV_NAME),
| ^~~~~~~~
drivers/ata/ahci.h:388:17: warning: initialized field overwritten [-Woverride-init]
388 | .sdev_attrs = ahci_sdev_attrs
| ^~~~~~~~~~~~~~~
drivers/ata/ahci_qoriq.c:304:2: note: in expansion of macro 'AHCI_SHT'
304 | AHCI_SHT(DRV_NAME),
| ^~~~~~~~
drivers/ata/ahci.h:388:17: note: (near initialization for 'ahci_qoriq_sht.sdev_attrs')
388 | .sdev_attrs = ahci_sdev_attrs
| ^~~~~~~~~~~~~~~
drivers/ata/ahci_qoriq.c:304:2: note: in expansion of macro 'AHCI_SHT'
304 | AHCI_SHT(DRV_NAME),
| ^~~~~~~~
In file included from include/uapi/linux/swab.h:8,
from include/linux/swab.h:5,
from include/uapi/linux/byteorder/big_endian.h:13,
from include/linux/byteorder/big_endian.h:5,
from arch/c6x/include/uapi/asm/byteorder.h:8,
from arch/c6x/include/asm/bitops.h:14,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from drivers/ata/ahci_qoriq.c:9:
drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
>> arch/c6x/include/uapi/asm/swab.h:21:2: warning: 'px_is' may be used uninitialized in this function [-Wmaybe-uninitialized]
21 | asm("swap4 .l1 %0,%0n"
| ^~~
drivers/ata/ahci_qoriq.c:229:14: note: 'px_is' was declared here
229 | u32 px_cmd, px_is, px_val;
| ^~~~~
In file included from include/uapi/linux/swab.h:8,
from include/linux/swab.h:5,
from include/uapi/linux/byteorder/big_endian.h:13,
from include/linux/byteorder/big_endian.h:5,
from arch/c6x/include/uapi/asm/byteorder.h:8,
from arch/c6x/include/asm/bitops.h:14,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from drivers/ata/ahci_qoriq.c:9:
>> arch/c6x/include/uapi/asm/swab.h:21:2: warning: 'px_cmd' may be used uninitialized in this function [-Wmaybe-uninitialized]
21 | asm("swap4 .l1 %0,%0n"
| ^~~
drivers/ata/ahci_qoriq.c:229:6: note: 'px_cmd' was declared here
229 | u32 px_cmd, px_is, px_val;
| ^~~~~~
vim +/px_is +21 arch/c6x/include/uapi/asm/swab.h
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 18
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 19 static inline __attribute_const__ __u32 __c6x_swab32(__u32 val)
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 20 {
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 @21 asm("swap4 .l1 %0,%0\n"
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 22 "swap2 .l1 %0,%0\n"
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 23 : "+a"(val));
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 24 return val;
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 25 }
a7f626c1948ab61 arch/c6x/include/asm/swab.h Aurelien Jacquiot 2011-10-04 26
:::::: The code at line 21 was first introduced by commit
:::::: a7f626c1948ab6178d2338831c5ffea7385e9f7f C6X: headers
:::::: TO: Aurelien Jacquiot <a-jacquiot@ti.com>
:::::: CC: Mark Salter <msalter@redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51758 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v3 09/13] dt-bindings: clock: Make marvell,mmp2-clock a power controller
From: Rob Herring @ 2020-05-26 23:05 UTC (permalink / raw)
To: Lubomir Rintel
Cc: devicetree, Stephen Boyd, Michael Turquette, linux-kernel,
linux-clk, linux-arm-kernel
In-Reply-To: <20200519224151.2074597-10-lkundrak@v3.sk>
On Wed, May 20, 2020 at 12:41:47AM +0200, Lubomir Rintel wrote:
> This is a binding for the MMP2 power management units. As such apart from
> providing the clocks, they also manage the power islands.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v2:
> - Added this patch
>
> .../devicetree/bindings/clock/marvell,mmp2-clock.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH v3 12/13] dt-bindings: clock: Add Marvell MMP Audio Clock Controller binding
From: Rob Herring @ 2020-05-26 23:06 UTC (permalink / raw)
To: Lubomir Rintel
Cc: devicetree, Stephen Boyd, Michael Turquette, linux-kernel,
Rob Herring, linux-clk, linux-arm-kernel
In-Reply-To: <20200519224151.2074597-13-lkundrak@v3.sk>
On Wed, 20 May 2020 00:41:50 +0200, Lubomir Rintel wrote:
> This describes the bindings for a controller that generates master and bit
> clocks for the I2S interface.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Fix commit message wording
> - Define MMP2_CLK_AUDIO_NR_CLKS
> - Make clock ids start at 0, not 1
> - Fix dt-bindings/clock/marvell,mmp2-audio.h file name
> - Rename node from "clocks" to "clock-controller"
>
> .../clock/marvell,mmp2-audio-clock.yaml | 74 +++++++++++++++++++
> .../dt-bindings/clock/marvell,mmp2-audio.h | 10 +++
> 2 files changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/marvell,mmp2-audio-clock.yaml
> create mode 100644 include/dt-bindings/clock/marvell,mmp2-audio.h
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH net 1/1] net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a
From: David Miller @ 2020-05-26 23:28 UTC (permalink / raw)
To: fugang.duan
Cc: p.zabel, alexandre.torgue, netdev, joabreu, mcoquelin.stm32, kuba,
peppe.cavallaro, linux-stm32, linux-arm-kernel
In-Reply-To: <1590394694-5505-1-git-send-email-fugang.duan@nxp.com>
From: Fugang Duan <fugang.duan@nxp.com>
Date: Mon, 25 May 2020 16:18:14 +0800
> For rx filter 'HWTSTAMP_FILTER_PTP_V2_EVENT', it should be
> PTP v2/802.AS1, any layer, any kind of event packet, but HW only
> take timestamp snapshot for below PTP message: sync, Pdelay_req,
> Pdelay_resp.
>
> Then it causes below issue when test E2E case:
> ptp4l[2479.534]: port 1: received DELAY_REQ without timestamp
> ptp4l[2481.423]: port 1: received DELAY_REQ without timestamp
> ptp4l[2481.758]: port 1: received DELAY_REQ without timestamp
> ptp4l[2483.524]: port 1: received DELAY_REQ without timestamp
> ptp4l[2484.233]: port 1: received DELAY_REQ without timestamp
> ptp4l[2485.750]: port 1: received DELAY_REQ without timestamp
> ptp4l[2486.888]: port 1: received DELAY_REQ without timestamp
> ptp4l[2487.265]: port 1: received DELAY_REQ without timestamp
> ptp4l[2487.316]: port 1: received DELAY_REQ without timestamp
>
> Timestamp snapshot dependency on register bits in received path:
> SNAPTYPSEL TSMSTRENA TSEVNTENA PTP_Messages
> 01 x 0 SYNC, Follow_Up, Delay_Req,
> Delay_Resp, Pdelay_Req, Pdelay_Resp,
> Pdelay_Resp_Follow_Up
> 01 0 1 SYNC, Pdelay_Req, Pdelay_Resp
>
> For dwmac v5.10a, enabling all events by setting register
> DWC_EQOS_TIME_STAMPING[SNAPTYPSEL] to 2’b01, clearing bit [TSEVNTENA]
> to 0’b0, which can support all required events.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Applied and queued up for -stable, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH 03/21] drm/arm: Use GEM CMA object functions
From: Liviu Dudau @ 2020-05-26 23:30 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexandre.belloni, linux-aspeed, narmstrong, airlied,
linus.walleij, stefan, philippe.cornu, paul, laurent.pinchart,
benjamin.gaignard, mihail.atanassov, sam, alexandre.torgue, marex,
festevam, abrodkin, ludovic.desroches, xinliang.liu,
kong.kongxinwei, tomi.valkeinen, james.qian.wang, joel, linux-imx,
p.zabel, puck.chen, s.hauer, alison.wang, maarten.lankhorst,
mripard, john.stultz, jsarha, wens, vincent.abriou, kernel,
linux-arm-kernel, mcoquelin.stm32, noralf, bbrezillon, andrew,
dri-devel, yannick.fertre, kieran.bingham+renesas, daniel,
khilman, zourongrong, shawnguo, brian.starkey
In-Reply-To: <20200522135246.10134-4-tzimmermann@suse.de>
On Fri, May 22, 2020 at 03:52:28PM +0200, Thomas Zimmermann wrote:
> The arm driver uses the default implementation for CMA functions. The
> DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver.
> All remaining operations are provided by CMA GEM object functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Thanks!
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index 194419f47c5e5..c83b81a3a582a 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -240,17 +240,7 @@ static struct drm_driver hdlcd_driver = {
> .irq_preinstall = hdlcd_irq_preinstall,
> .irq_postinstall = hdlcd_irq_postinstall,
> .irq_uninstall = hdlcd_irq_uninstall,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_print_info = drm_gem_cma_print_info,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = drm_gem_cma_dumb_create,
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + DRM_GEM_CMA_DRIVER_OPS,
> #ifdef CONFIG_DEBUG_FS
> .debugfs_init = hdlcd_debugfs_init,
> #endif
> --
> 2.26.2
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
* Re: [PATCH 10/21] drm/komeda: Use GEM CMA object functions
From: Liviu Dudau @ 2020-05-26 23:33 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexandre.belloni, linux-aspeed, narmstrong, airlied,
linus.walleij, stefan, philippe.cornu, paul, laurent.pinchart,
benjamin.gaignard, mihail.atanassov, sam, alexandre.torgue, marex,
festevam, abrodkin, ludovic.desroches, xinliang.liu,
kong.kongxinwei, tomi.valkeinen, james.qian.wang, joel, linux-imx,
p.zabel, puck.chen, s.hauer, alison.wang, maarten.lankhorst,
mripard, john.stultz, jsarha, wens, vincent.abriou, kernel,
linux-arm-kernel, mcoquelin.stm32, noralf, bbrezillon, andrew,
dri-devel, yannick.fertre, kieran.bingham+renesas, daniel,
khilman, zourongrong, shawnguo, brian.starkey
In-Reply-To: <20200522135246.10134-11-tzimmermann@suse.de>
On Fri, May 22, 2020 at 03:52:35PM +0200, Thomas Zimmermann wrote:
> The komeda driver uses the default implementation for CMA functions; except
> for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets
> these defaults and .dumb_create in struct drm_driver. All remaining
> operations are provided by CMA GEM object functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> index 6b85d5f4caa85..bdfbcbc416260 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -61,16 +61,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data)
> static struct drm_driver komeda_kms_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .lastclose = drm_fb_helper_lastclose,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = komeda_gem_cma_dumb_create,
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + __DRM_GEM_CMA_DRIVER_OPS(komeda_gem_cma_dumb_create),
> .fops = &komeda_cma_fops,
> .name = "komeda",
> .desc = "Arm Komeda Display Processor driver",
> --
> 2.26.2
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox