Re: [RFC WIP PATCH] venus: add qcom,no-low-power property

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 10/04/2024 14:18, Marc Gonzalez wrote:
> On 10/04/2024 15:14, Bryan O'Donoghue wrote:
> 
>> On 10/04/2024 13:23, Marc Gonzalez wrote:
>>
>>> FWIW, I get the same behavior with 854x480 and 2560x1440:
>>>
>>> 1) If mpv runs with '--length=N' (play only part of the file)
>>> then mpv exits cleanly, with no kernel messages.
>>
>> On -next ?
>>
>> I think you mentioned before you were doing your work on an older kernel
>> and forward porting patches ?
> 
> I work on v6.9-rc1
> Is -next that much different in that area?

No, I thought you were on a 4.x kernel for some reason.

6.9.x is fine

> 
>>> 2) If mpv plays the entire file, then mpv hangs at the end
>>> (needs CTRL-C to exit) and driver prints to kernel:
>>> [68643.935888] qcom-venus cc00000.video-codec: session error: event id:1001 (deadb000), session id:79d42000
>>> [68643.935995] qcom-venus-decoder cc00000.video-codec:video-decoder: dec: event : 1001
>>
>> Hmm
>>
>> #define HFI_ERR_SESSION_FATAL				0x1001
>>
>> Something is causing the firmware to return this packet to you.
>>
>> Probably worth tracing the last five messages sent by the firmware prior
>> to that to see if we can root-cause.
> 
> I'm not seeing anything from the FW in dmesg.
> I suppose I need to enable DEBUG in various places?

--- a/drivers/media/platform/qcom/venus/hfi_venus.c
+++ b/drivers/media/platform/qcom/venus/hfi_venus.c
@@ -129,7 +129,8 @@ struct venus_hfi_device {
         u8 dbg_buf[IFACEQ_VAR_HUGE_PKT_SIZE];
  };

-static bool venus_pkt_debug;
+#define DEBUG
+static bool venus_pkt_debug = true;

We can add additional flags - it'd be nice if these could be controlled 
by a module prameter or debugfs trigger - to this

venus_fw_debug = 0x2f;

But start with the default mask = int venus_fw_debug = 
HFI_DEBUG_MSG_ERROR | HFI_DEBUG_MSG_FATAL

---
bod