From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc: marijn.suijten@somainline.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
James Morse <james.morse@arm.com>,
D Scott Phillips <scott@os.amperecomputing.com>,
Michal Orzel <michal.orzel@arm.com>,
Linu Cherian <lcherian@marvell.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: Add a couple of missing part numbers
Date: Wed, 1 Feb 2023 11:40:32 +0100 [thread overview]
Message-ID: <11859977-4e29-e4d7-acd4-94e3d3227c27@linaro.org> (raw)
In-Reply-To: <e1688749-bcdf-14f4-ac34-137a602286e1@arm.com>
On 1.02.2023 05:50, Anshuman Khandual wrote:
>
>
> On 2/1/23 05:39, Konrad Dybcio wrote:
>> Add Cortex X1C and add/clarify various recent Qualcomm Kryo cores,
>> which almost exclusively mimic ARM IDs nowadays.
>
> Why add these cpu numbers ? Is there an errata being worked on for them ?
> Without specific implementation requirement, these might not be necessary.
Generally I was under the impression that this header
double-served as sort of a documentation. I checked
my board and they seem to even use the Arm implementer
ID (instead of their own, as they did in the past),
so I suppose they may be using actual Cortex parts
with no modifications and this patch is not very
beneficial.
Konrad
>
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> v1 -> v2:
>>
>> - Don't change the name of QCOM_CPU_PART_KRYO_4XX_SILVER
>>
>> arch/arm64/include/asm/cputype.h | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
>> index 683ca3af4084..a4260d3194fc 100644
>> --- a/arch/arm64/include/asm/cputype.h
>> +++ b/arch/arm64/include/asm/cputype.h
>> @@ -84,6 +84,7 @@
>> #define ARM_CPU_PART_CORTEX_X2 0xD48
>> #define ARM_CPU_PART_NEOVERSE_N2 0xD49
>> #define ARM_CPU_PART_CORTEX_A78C 0xD4B
>> +#define ARM_CPU_PART_CORTEX_X1C 0xD4C
>>
>> #define APM_CPU_PART_POTENZA 0x000
>>
>> @@ -107,9 +108,17 @@
>> #define QCOM_CPU_PART_KRYO 0x200
>> #define QCOM_CPU_PART_KRYO_2XX_GOLD 0x800
>> #define QCOM_CPU_PART_KRYO_2XX_SILVER 0x801
>> +#define QCOM_CPU_PART_KRYO_3XX_GOLD 0x802
>> #define QCOM_CPU_PART_KRYO_3XX_SILVER 0x803
>> #define QCOM_CPU_PART_KRYO_4XX_GOLD 0x804
>> #define QCOM_CPU_PART_KRYO_4XX_SILVER 0x805
>> +#define QCOM_CPU_PART_KRYO_5XX_GOLD ARM_CPU_PART_CORTEX_A77
>> +#define QCOM_CPU_PART_KRYO_6XX_GOLD ARM_CPU_PART_CORTEX_A78
>> +#define QCOM_CPU_PART_KRYO_6XX_GOLDPLUS ARM_CPU_PART_CORTEX_X1
>> +#define QCOM_CPU_PART_KRYO_6XX_SILVER_V1 ARM_CPU_PART_CORTEX_A55
>> +#define QCOM_CPU_PART_KRYO_7XX_GOLD ARM_CPU_PART_CORTEX_A710
>> +#define QCOM_CPU_PART_KRYO_7XX_GOLDPLUS ARM_CPU_PART_CORTEX_X2
>> +#define QCOM_CPU_PART_KRYO_7XX_SILVER ARM_CPU_PART_CORTEX_A510
>>
>> #define NVIDIA_CPU_PART_DENVER 0x003
>> #define NVIDIA_CPU_PART_CARMEL 0x004
prev parent reply other threads:[~2023-02-01 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 0:09 [PATCH v2] arm64: Add a couple of missing part numbers Konrad Dybcio
2023-02-01 4:50 ` Anshuman Khandual
2023-02-01 10:40 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11859977-4e29-e4d7-acd4-94e3d3227c27@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=maz@kernel.org \
--cc=michal.orzel@arm.com \
--cc=scott@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox