* [PATCH v2] arm64: Add a couple of missing part numbers
@ 2023-02-01 0:09 Konrad Dybcio
2023-02-01 4:50 ` Anshuman Khandual
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2023-02-01 0:09 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Catalin Marinas, Will Deacon,
Marc Zyngier, James Morse, D Scott Phillips, Michal Orzel,
Linu Cherian, linux-arm-kernel, linux-kernel
Add Cortex X1C and add/clarify various recent Qualcomm Kryo cores,
which almost exclusively mimic ARM IDs nowadays.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Don't change the name of QCOM_CPU_PART_KRYO_4XX_SILVER
arch/arm64/include/asm/cputype.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
index 683ca3af4084..a4260d3194fc 100644
--- a/arch/arm64/include/asm/cputype.h
+++ b/arch/arm64/include/asm/cputype.h
@@ -84,6 +84,7 @@
#define ARM_CPU_PART_CORTEX_X2 0xD48
#define ARM_CPU_PART_NEOVERSE_N2 0xD49
#define ARM_CPU_PART_CORTEX_A78C 0xD4B
+#define ARM_CPU_PART_CORTEX_X1C 0xD4C
#define APM_CPU_PART_POTENZA 0x000
@@ -107,9 +108,17 @@
#define QCOM_CPU_PART_KRYO 0x200
#define QCOM_CPU_PART_KRYO_2XX_GOLD 0x800
#define QCOM_CPU_PART_KRYO_2XX_SILVER 0x801
+#define QCOM_CPU_PART_KRYO_3XX_GOLD 0x802
#define QCOM_CPU_PART_KRYO_3XX_SILVER 0x803
#define QCOM_CPU_PART_KRYO_4XX_GOLD 0x804
#define QCOM_CPU_PART_KRYO_4XX_SILVER 0x805
+#define QCOM_CPU_PART_KRYO_5XX_GOLD ARM_CPU_PART_CORTEX_A77
+#define QCOM_CPU_PART_KRYO_6XX_GOLD ARM_CPU_PART_CORTEX_A78
+#define QCOM_CPU_PART_KRYO_6XX_GOLDPLUS ARM_CPU_PART_CORTEX_X1
+#define QCOM_CPU_PART_KRYO_6XX_SILVER_V1 ARM_CPU_PART_CORTEX_A55
+#define QCOM_CPU_PART_KRYO_7XX_GOLD ARM_CPU_PART_CORTEX_A710
+#define QCOM_CPU_PART_KRYO_7XX_GOLDPLUS ARM_CPU_PART_CORTEX_X2
+#define QCOM_CPU_PART_KRYO_7XX_SILVER ARM_CPU_PART_CORTEX_A510
#define NVIDIA_CPU_PART_DENVER 0x003
#define NVIDIA_CPU_PART_CARMEL 0x004
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: Add a couple of missing part numbers
2023-02-01 0:09 [PATCH v2] arm64: Add a couple of missing part numbers Konrad Dybcio
@ 2023-02-01 4:50 ` Anshuman Khandual
2023-02-01 10:40 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Anshuman Khandual @ 2023-02-01 4:50 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross,
krzysztof.kozlowski
Cc: marijn.suijten, Catalin Marinas, Will Deacon, Marc Zyngier,
James Morse, D Scott Phillips, Michal Orzel, Linu Cherian,
linux-arm-kernel, linux-kernel
On 2/1/23 05:39, Konrad Dybcio wrote:
> Add Cortex X1C and add/clarify various recent Qualcomm Kryo cores,
> which almost exclusively mimic ARM IDs nowadays.
Why add these cpu numbers ? Is there an errata being worked on for them ?
Without specific implementation requirement, these might not be necessary.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> v1 -> v2:
>
> - Don't change the name of QCOM_CPU_PART_KRYO_4XX_SILVER
>
> arch/arm64/include/asm/cputype.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index 683ca3af4084..a4260d3194fc 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -84,6 +84,7 @@
> #define ARM_CPU_PART_CORTEX_X2 0xD48
> #define ARM_CPU_PART_NEOVERSE_N2 0xD49
> #define ARM_CPU_PART_CORTEX_A78C 0xD4B
> +#define ARM_CPU_PART_CORTEX_X1C 0xD4C
>
> #define APM_CPU_PART_POTENZA 0x000
>
> @@ -107,9 +108,17 @@
> #define QCOM_CPU_PART_KRYO 0x200
> #define QCOM_CPU_PART_KRYO_2XX_GOLD 0x800
> #define QCOM_CPU_PART_KRYO_2XX_SILVER 0x801
> +#define QCOM_CPU_PART_KRYO_3XX_GOLD 0x802
> #define QCOM_CPU_PART_KRYO_3XX_SILVER 0x803
> #define QCOM_CPU_PART_KRYO_4XX_GOLD 0x804
> #define QCOM_CPU_PART_KRYO_4XX_SILVER 0x805
> +#define QCOM_CPU_PART_KRYO_5XX_GOLD ARM_CPU_PART_CORTEX_A77
> +#define QCOM_CPU_PART_KRYO_6XX_GOLD ARM_CPU_PART_CORTEX_A78
> +#define QCOM_CPU_PART_KRYO_6XX_GOLDPLUS ARM_CPU_PART_CORTEX_X1
> +#define QCOM_CPU_PART_KRYO_6XX_SILVER_V1 ARM_CPU_PART_CORTEX_A55
> +#define QCOM_CPU_PART_KRYO_7XX_GOLD ARM_CPU_PART_CORTEX_A710
> +#define QCOM_CPU_PART_KRYO_7XX_GOLDPLUS ARM_CPU_PART_CORTEX_X2
> +#define QCOM_CPU_PART_KRYO_7XX_SILVER ARM_CPU_PART_CORTEX_A510
>
> #define NVIDIA_CPU_PART_DENVER 0x003
> #define NVIDIA_CPU_PART_CARMEL 0x004
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: Add a couple of missing part numbers
2023-02-01 4:50 ` Anshuman Khandual
@ 2023-02-01 10:40 ` Konrad Dybcio
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-02-01 10:40 UTC (permalink / raw)
To: Anshuman Khandual, linux-arm-msm, andersson, agross,
krzysztof.kozlowski
Cc: marijn.suijten, Catalin Marinas, Will Deacon, Marc Zyngier,
James Morse, D Scott Phillips, Michal Orzel, Linu Cherian,
linux-arm-kernel, linux-kernel
On 1.02.2023 05:50, Anshuman Khandual wrote:
>
>
> On 2/1/23 05:39, Konrad Dybcio wrote:
>> Add Cortex X1C and add/clarify various recent Qualcomm Kryo cores,
>> which almost exclusively mimic ARM IDs nowadays.
>
> Why add these cpu numbers ? Is there an errata being worked on for them ?
> Without specific implementation requirement, these might not be necessary.
Generally I was under the impression that this header
double-served as sort of a documentation. I checked
my board and they seem to even use the Arm implementer
ID (instead of their own, as they did in the past),
so I suppose they may be using actual Cortex parts
with no modifications and this patch is not very
beneficial.
Konrad
>
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> v1 -> v2:
>>
>> - Don't change the name of QCOM_CPU_PART_KRYO_4XX_SILVER
>>
>> arch/arm64/include/asm/cputype.h | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
>> index 683ca3af4084..a4260d3194fc 100644
>> --- a/arch/arm64/include/asm/cputype.h
>> +++ b/arch/arm64/include/asm/cputype.h
>> @@ -84,6 +84,7 @@
>> #define ARM_CPU_PART_CORTEX_X2 0xD48
>> #define ARM_CPU_PART_NEOVERSE_N2 0xD49
>> #define ARM_CPU_PART_CORTEX_A78C 0xD4B
>> +#define ARM_CPU_PART_CORTEX_X1C 0xD4C
>>
>> #define APM_CPU_PART_POTENZA 0x000
>>
>> @@ -107,9 +108,17 @@
>> #define QCOM_CPU_PART_KRYO 0x200
>> #define QCOM_CPU_PART_KRYO_2XX_GOLD 0x800
>> #define QCOM_CPU_PART_KRYO_2XX_SILVER 0x801
>> +#define QCOM_CPU_PART_KRYO_3XX_GOLD 0x802
>> #define QCOM_CPU_PART_KRYO_3XX_SILVER 0x803
>> #define QCOM_CPU_PART_KRYO_4XX_GOLD 0x804
>> #define QCOM_CPU_PART_KRYO_4XX_SILVER 0x805
>> +#define QCOM_CPU_PART_KRYO_5XX_GOLD ARM_CPU_PART_CORTEX_A77
>> +#define QCOM_CPU_PART_KRYO_6XX_GOLD ARM_CPU_PART_CORTEX_A78
>> +#define QCOM_CPU_PART_KRYO_6XX_GOLDPLUS ARM_CPU_PART_CORTEX_X1
>> +#define QCOM_CPU_PART_KRYO_6XX_SILVER_V1 ARM_CPU_PART_CORTEX_A55
>> +#define QCOM_CPU_PART_KRYO_7XX_GOLD ARM_CPU_PART_CORTEX_A710
>> +#define QCOM_CPU_PART_KRYO_7XX_GOLDPLUS ARM_CPU_PART_CORTEX_X2
>> +#define QCOM_CPU_PART_KRYO_7XX_SILVER ARM_CPU_PART_CORTEX_A510
>>
>> #define NVIDIA_CPU_PART_DENVER 0x003
>> #define NVIDIA_CPU_PART_CARMEL 0x004
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-01 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-01 0:09 [PATCH v2] arm64: Add a couple of missing part numbers Konrad Dybcio
2023-02-01 4:50 ` Anshuman Khandual
2023-02-01 10:40 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox