* [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro
@ 2024-06-13 4:46 Jeff Johnson
2024-06-13 16:19 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnson @ 2024-06-13 4:46 UTC (permalink / raw)
To: Manivannan Sadhasivam, James E.J. Bottomley, Martin K. Petersen
Cc: linux-arm-msm, linux-scsi, linux-kernel, kernel-janitors,
Jeff Johnson
With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/ufs/host/ufs-qcom.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/ufs/host/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index cca190d1c577..72f95e2779ce 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1883,4 +1883,5 @@ static struct platform_driver ufs_qcom_pltform = {
};
module_platform_driver(ufs_qcom_pltform);
+MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
MODULE_LICENSE("GPL v2");
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240612-md-drivers-ufs-host-a8a0aad539f0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro
2024-06-13 4:46 [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-13 16:19 ` Bart Van Assche
2024-06-13 23:18 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2024-06-13 16:19 UTC (permalink / raw)
To: Jeff Johnson, Manivannan Sadhasivam, James E.J. Bottomley,
Martin K. Petersen, Can Guo
Cc: linux-arm-msm, linux-scsi, linux-kernel, kernel-janitors
On 6/12/24 9:46 PM, Jeff Johnson wrote:
> +MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
> MODULE_LICENSE("GPL v2");
That sounds weird to me. I think we are better of with no module
description than with the above description.
How about the following description?
"Qualcomm UFS host controller driver".
Thanks,
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro
2024-06-13 16:19 ` Bart Van Assche
@ 2024-06-13 23:18 ` Jeff Johnson
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-06-13 23:18 UTC (permalink / raw)
To: Bart Van Assche, Manivannan Sadhasivam, James E.J. Bottomley,
Martin K. Petersen, Can Guo
Cc: linux-arm-msm, linux-scsi, linux-kernel, kernel-janitors
On 6/13/2024 9:19 AM, Bart Van Assche wrote:
> On 6/12/24 9:46 PM, Jeff Johnson wrote:
>> +MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
>> MODULE_LICENSE("GPL v2");
>
> That sounds weird to me. I think we are better of with no module
> description than with the above description.
>
> How about the following description?
>
> "Qualcomm UFS host controller driver".
Sounds good to me. Will spin a v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-13 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-13 4:46 [PATCH] scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-13 16:19 ` Bart Van Assche
2024-06-13 23:18 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox