* [PATCH v2] thermal/drivers/tsens: fix missing put_device error
@ 2021-04-04 12:54 zhuguangqing83
2021-04-04 14:46 ` Bjorn Andersson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: zhuguangqing83 @ 2021-04-04 12:54 UTC (permalink / raw)
To: Amit Kucheria, Andy Gross, Bjorn Andersson, Zhang Rui,
Daniel Lezcano
Cc: linux-pm, linux-arm-msm, linux-kernel, Guangqing Zhu
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Fixes coccicheck error:
drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call
of_find_device_by_node on line 715, but without a corresponding object
release within this function.
Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into
tsens.c")
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
v2:
- Fix a error(missing a bracket) in v1.
---
drivers/thermal/qcom/tsens.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index d8ce3a687b80..3c4c0516e58a 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -755,8 +755,10 @@ int __init init_common(struct tsens_priv *priv)
for (i = VER_MAJOR; i <= VER_STEP; i++) {
priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map,
priv->fields[i]);
- if (IS_ERR(priv->rf[i]))
- return PTR_ERR(priv->rf[i]);
+ if (IS_ERR(priv->rf[i])) {
+ ret = PTR_ERR(priv->rf[i]);
+ goto err_put_device;
+ }
}
ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor);
if (ret)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] thermal/drivers/tsens: fix missing put_device error
2021-04-04 12:54 [PATCH v2] thermal/drivers/tsens: fix missing put_device error zhuguangqing83
@ 2021-04-04 14:46 ` Bjorn Andersson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-04-04 14:46 UTC (permalink / raw)
To: zhuguangqing83
Cc: Amit Kucheria, Andy Gross, Zhang Rui, Daniel Lezcano, linux-pm,
linux-arm-msm, linux-kernel
On Sun 04 Apr 07:54 CDT 2021, zhuguangqing83@gmail.com wrote:
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Fixes coccicheck error:
>
> drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call
> of_find_device_by_node on line 715, but without a corresponding object
> release within this function.
>
> Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into
> tsens.c")
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> v2:
> - Fix a error(missing a bracket) in v1.
>
> ---
> drivers/thermal/qcom/tsens.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index d8ce3a687b80..3c4c0516e58a 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -755,8 +755,10 @@ int __init init_common(struct tsens_priv *priv)
> for (i = VER_MAJOR; i <= VER_STEP; i++) {
> priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map,
> priv->fields[i]);
> - if (IS_ERR(priv->rf[i]))
> - return PTR_ERR(priv->rf[i]);
> + if (IS_ERR(priv->rf[i])) {
> + ret = PTR_ERR(priv->rf[i]);
> + goto err_put_device;
> + }
> }
> ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor);
> if (ret)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] thermal/drivers/tsens: fix missing put_device error
2021-04-04 12:54 [PATCH v2] thermal/drivers/tsens: fix missing put_device error zhuguangqing83
2021-04-04 14:46 ` Bjorn Andersson
@ 2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-05-26 19:03 UTC (permalink / raw)
To: guangqing zhu; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Sun, 4 Apr 2021 20:54:31 +0800 you wrote:
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Fixes coccicheck error:
>
> drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call
> of_find_device_by_node on line 715, but without a corresponding object
> release within this function.
>
> [...]
Here is the summary with links:
- [v2] thermal/drivers/tsens: fix missing put_device error
https://git.kernel.org/qcom/c/f4136863e889
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-26 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-04 12:54 [PATCH v2] thermal/drivers/tsens: fix missing put_device error zhuguangqing83
2021-04-04 14:46 ` Bjorn Andersson
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox