* [PATCH] soc: qcom: icc-bwmon: Convert to use maple tree register cache
@ 2024-03-09 7:28 wangkaiyuan
2024-03-09 9:54 ` Krzysztof Kozlowski
2024-03-17 16:27 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: wangkaiyuan @ 2024-03-09 7:28 UTC (permalink / raw)
To: krzysztof.kozlowski, andersson, konrad.dybcio
Cc: linux-arm-msm, linux-kernel, wangkaiyuan
The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.
Signed-off-by: wangkaiyuan <wangkaiyuan@inspur.com>
---
drivers/soc/qcom/icc-bwmon.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index 656706259353..fb323b3364db 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -282,7 +282,7 @@ static const struct regmap_config msm8998_bwmon_regmap_cfg = {
* Cache is necessary for using regmap fields with non-readable
* registers.
*/
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
};
static const struct regmap_config msm8998_bwmon_global_regmap_cfg = {
@@ -301,7 +301,7 @@ static const struct regmap_config msm8998_bwmon_global_regmap_cfg = {
* Cache is necessary for using regmap fields with non-readable
* registers.
*/
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
};
static const struct reg_field sdm845_cpu_bwmon_reg_fields[] = {
@@ -369,7 +369,7 @@ static const struct regmap_config sdm845_cpu_bwmon_regmap_cfg = {
* Cache is necessary for using regmap fields with non-readable
* registers.
*/
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
};
/* BWMON v5 */
@@ -446,7 +446,7 @@ static const struct regmap_config sdm845_llcc_bwmon_regmap_cfg = {
* Cache is necessary for using regmap fields with non-readable
* registers.
*/
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
};
static void bwmon_clear_counters(struct icc_bwmon *bwmon, bool clear_all)
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] soc: qcom: icc-bwmon: Convert to use maple tree register cache
2024-03-09 7:28 [PATCH] soc: qcom: icc-bwmon: Convert to use maple tree register cache wangkaiyuan
@ 2024-03-09 9:54 ` Krzysztof Kozlowski
2024-03-17 16:27 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-09 9:54 UTC (permalink / raw)
To: wangkaiyuan, andersson, konrad.dybcio; +Cc: linux-arm-msm, linux-kernel
On 09/03/2024 08:28, wangkaiyuan wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: wangkaiyuan <wangkaiyuan@inspur.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: icc-bwmon: Convert to use maple tree register cache
2024-03-09 7:28 [PATCH] soc: qcom: icc-bwmon: Convert to use maple tree register cache wangkaiyuan
2024-03-09 9:54 ` Krzysztof Kozlowski
@ 2024-03-17 16:27 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-03-17 16:27 UTC (permalink / raw)
To: krzysztof.kozlowski, konrad.dybcio, wangkaiyuan
Cc: linux-arm-msm, linux-kernel
On Sat, 09 Mar 2024 15:28:25 +0800, wangkaiyuan wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
>
Applied, thanks!
[1/1] soc: qcom: icc-bwmon: Convert to use maple tree register cache
commit: a8adf216136a16f8b31ece4455f60d59db3d6d62
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-17 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-09 7:28 [PATCH] soc: qcom: icc-bwmon: Convert to use maple tree register cache wangkaiyuan
2024-03-09 9:54 ` Krzysztof Kozlowski
2024-03-17 16:27 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox