* [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC
@ 2026-05-01 17:53 Komal Bajaj
2026-05-04 11:03 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Komal Bajaj @ 2026-05-01 17:53 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Guru Das Srinagesh
Cc: linux-arm-msm, devicetree, linux-kernel, Komal Bajaj
Document the SCM compatible for the Shikra SoC.
Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
index 7918d31f58b4..bb1e0a0d1d3c 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
@@ -65,6 +65,7 @@ properties:
- qcom,scm-sdx55
- qcom,scm-sdx65
- qcom,scm-sdx75
+ - qcom,scm-shikra
- qcom,scm-sm6115
- qcom,scm-sm6125
- qcom,scm-sm6350
@@ -146,6 +147,7 @@ allOf:
- qcom,scm-msm8974
- qcom,scm-msm8976
- qcom,scm-qcm2290
+ - qcom,scm-shikra
- qcom,scm-sm6375
then:
required:
@@ -165,6 +167,7 @@ allOf:
- qcom,scm-msm8660
- qcom,scm-msm8960
- qcom,scm-qcm2290
+ - qcom,scm-shikra
- qcom,scm-sm6375
then:
properties:
---
base-commit: 39704f00f747aba3144289870b5fd8ac230a9aaf
change-id: 20260501-shikra-scm-binding-a7ff5fabd0f2
Best regards,
--
Komal Bajaj <komal.bajaj@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC
2026-05-01 17:53 [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC Komal Bajaj
@ 2026-05-04 11:03 ` Krzysztof Kozlowski
2026-05-08 6:24 ` Komal Bajaj
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-04 11:03 UTC (permalink / raw)
To: Komal Bajaj
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Guru Das Srinagesh, linux-arm-msm,
devicetree, linux-kernel
On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote:
> Document the SCM compatible for the Shikra SoC.
>
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 7918d31f58b4..bb1e0a0d1d3c 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -65,6 +65,7 @@ properties:
> - qcom,scm-sdx55
> - qcom,scm-sdx65
> - qcom,scm-sdx75
> + - qcom,scm-shikra
> - qcom,scm-sm6115
> - qcom,scm-sm6125
> - qcom,scm-sm6350
> @@ -146,6 +147,7 @@ allOf:
> - qcom,scm-msm8974
> - qcom,scm-msm8976
> - qcom,scm-qcm2290
> + - qcom,scm-shikra
> - qcom,scm-sm6375
> then:
> required:
> @@ -165,6 +167,7 @@ allOf:
> - qcom,scm-msm8660
> - qcom,scm-msm8960
> - qcom,scm-qcm2290
> + - qcom,scm-shikra
> - qcom,scm-sm6375
This looks wrong or the diff hunks are confusing. Aren't you changing
one if:then: block for clocks and then second different one which
disallows clocks?
dtbs_check on your DTS would tell you...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC
2026-05-04 11:03 ` Krzysztof Kozlowski
@ 2026-05-08 6:24 ` Komal Bajaj
0 siblings, 0 replies; 3+ messages in thread
From: Komal Bajaj @ 2026-05-08 6:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Guru Das Srinagesh, linux-arm-msm,
devicetree, linux-kernel
On 5/4/2026 4:33 PM, Krzysztof Kozlowski wrote:
> On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote:
>> Document the SCM compatible for the Shikra SoC.
>>
>> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>> ---
>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index 7918d31f58b4..bb1e0a0d1d3c 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -65,6 +65,7 @@ properties:
>> - qcom,scm-sdx55
>> - qcom,scm-sdx65
>> - qcom,scm-sdx75
>> + - qcom,scm-shikra
>> - qcom,scm-sm6115
>> - qcom,scm-sm6125
>> - qcom,scm-sm6350
>> @@ -146,6 +147,7 @@ allOf:
>> - qcom,scm-msm8974
>> - qcom,scm-msm8976
>> - qcom,scm-qcm2290
>> + - qcom,scm-shikra
>> - qcom,scm-sm6375
>> then:
>> required:
>> @@ -165,6 +167,7 @@ allOf:
>> - qcom,scm-msm8660
>> - qcom,scm-msm8960
>> - qcom,scm-qcm2290
>> + - qcom,scm-shikra
>> - qcom,scm-sm6375
> This looks wrong or the diff hunks are confusing. Aren't you changing
> one if:then: block for clocks and then second different one which
> disallows clocks?
>
> dtbs_check on your DTS would tell you...
The two hunks touch two separate allOf blocks:
- Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all
- Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one
clock named core
Both hunks are intentional.
Verified with dtbs_check — no complaints.
Thanks
Komal
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-08 6:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 17:53 [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC Komal Bajaj
2026-05-04 11:03 ` Krzysztof Kozlowski
2026-05-08 6:24 ` Komal Bajaj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox