* [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
@ 2024-04-25 23:07 Sagar Cheluvegowda
2024-04-25 23:20 ` Abhishek Chauhan (ABC)
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sagar Cheluvegowda @ 2024-04-25 23:07 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: kernel, linux-arm-msm, devicetree, linux-kernel,
Sagar Cheluvegowda
Ethernet devices are cache coherent, mark it as such in the dtsi.
Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6
Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 231cea1f0fa8..5ab4ca978837 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -2504,6 +2504,7 @@ ethernet1: ethernet@23000000 {
phy-names = "serdes";
iommus = <&apps_smmu 0x140 0xf>;
+ dma-coherent;
snps,tso;
snps,pbl = <32>;
@@ -2538,6 +2539,7 @@ ethernet0: ethernet@23040000 {
phy-names = "serdes";
iommus = <&apps_smmu 0x120 0xf>;
+ dma-coherent;
snps,tso;
snps,pbl = <32>;
---
base-commit: a93289b830ce783955b22fbe5d1274a464c05acf
change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165
Best regards,
--
Sagar Cheluvegowda <quic_scheluve@quicinc.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
2024-04-25 23:07 [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent Sagar Cheluvegowda
@ 2024-04-25 23:20 ` Abhishek Chauhan (ABC)
2024-04-26 6:37 ` Krzysztof Kozlowski
2024-04-26 6:37 ` Krzysztof Kozlowski
2024-04-30 18:18 ` Andrew Halaney
2 siblings, 1 reply; 5+ messages in thread
From: Abhishek Chauhan (ABC) @ 2024-04-25 23:20 UTC (permalink / raw)
To: Sagar Cheluvegowda, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: kernel, linux-arm-msm, devicetree, linux-kernel
On 4/25/2024 4:07 PM, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
>
> Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6
Remove internal change id.
Not required for upstreaming any changes.
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 231cea1f0fa8..5ab4ca978837 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -2504,6 +2504,7 @@ ethernet1: ethernet@23000000 {
> phy-names = "serdes";
>
> iommus = <&apps_smmu 0x140 0xf>;
> + dma-coherent;
>
> snps,tso;
> snps,pbl = <32>;
> @@ -2538,6 +2539,7 @@ ethernet0: ethernet@23040000 {
> phy-names = "serdes";
>
> iommus = <&apps_smmu 0x120 0xf>;
> + dma-coherent;
>
> snps,tso;
> snps,pbl = <32>;
>
> ---
> base-commit: a93289b830ce783955b22fbe5d1274a464c05acf
> change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
2024-04-25 23:20 ` Abhishek Chauhan (ABC)
@ 2024-04-26 6:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-26 6:37 UTC (permalink / raw)
To: Abhishek Chauhan (ABC), Sagar Cheluvegowda, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: kernel, linux-arm-msm, devicetree, linux-kernel
On 26/04/2024 01:20, Abhishek Chauhan (ABC) wrote:
>
>
> On 4/25/2024 4:07 PM, Sagar Cheluvegowda wrote:
>> Ethernet devices are cache coherent, mark it as such in the dtsi.
>>
>> Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6
> Remove internal change id.
> Not required for upstreaming any changes.
Please trim your replies from unnecessary context.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
2024-04-25 23:07 [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent Sagar Cheluvegowda
2024-04-25 23:20 ` Abhishek Chauhan (ABC)
@ 2024-04-26 6:37 ` Krzysztof Kozlowski
2024-04-30 18:18 ` Andrew Halaney
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-26 6:37 UTC (permalink / raw)
To: Sagar Cheluvegowda, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: kernel, linux-arm-msm, devicetree, linux-kernel
On 26/04/2024 01:07, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
>
> Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6
ALWAYS run checkpatch before sending any patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
2024-04-25 23:07 [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent Sagar Cheluvegowda
2024-04-25 23:20 ` Abhishek Chauhan (ABC)
2024-04-26 6:37 ` Krzysztof Kozlowski
@ 2024-04-30 18:18 ` Andrew Halaney
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Halaney @ 2024-04-30 18:18 UTC (permalink / raw)
To: Sagar Cheluvegowda
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
kernel, linux-arm-msm, devicetree, linux-kernel
On Thu, Apr 25, 2024 at 04:07:10PM -0700, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
>
> Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
In addition to what others have said, I think you should include
fixes tags for this, so something like:
Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
to indicate this isn't just an improvement, but a proper bug fix.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-30 18:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-25 23:07 [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent Sagar Cheluvegowda
2024-04-25 23:20 ` Abhishek Chauhan (ABC)
2024-04-26 6:37 ` Krzysztof Kozlowski
2024-04-26 6:37 ` Krzysztof Kozlowski
2024-04-30 18:18 ` Andrew Halaney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox