From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Will Newton <will.newton@gmail.com>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: PM8916 RPM regulator supply names too long
Date: Tue, 12 Dec 2017 16:15:01 -0800 [thread overview]
Message-ID: <20171213001501.GH4803@minitux> (raw)
In-Reply-To: <CAFbHwiTH8-USmhwszSd9tMqKVw6WcWDrwuP+bXn2kbPsFm=fyw@mail.gmail.com>
On Tue 12 Dec 07:11 PST 2017, Will Newton wrote:
> Hi,
>
> I noticed that in drivers/regulator/qcom_smd-regulator.c there are
> supply names such as:
>
> "vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18"
>
> This gets looked up in the DT (with the string "-supply" appended) but
> this will always fail due to the name exceeding the 32 character
> maximum of a DT attribute and getting truncated.
That's not good, I guess we have to game the system and rename this
"vdd_l8-l18" or something like that.
> Is this a known issue? I'm curious as to why MSM8916 users are not
> finding this a problem in practice.
I haven't heard anyone complain about this before.
The reason why we haven't this this issue is because at least on db410c
the supply is vph_pwr which is an always on, fixed, 3.7V line, which we
don't describe in DT (but probably should for completeness).
Regards,
Bjorn
prev parent reply other threads:[~2017-12-13 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 15:11 PM8916 RPM regulator supply names too long Will Newton
2017-12-13 0:15 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213001501.GH4803@minitux \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox