* PM8916 RPM regulator supply names too long
@ 2017-12-12 15:11 Will Newton
2017-12-13 0:15 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Will Newton @ 2017-12-12 15:11 UTC (permalink / raw)
To: linux-arm-msm
Hi,
I noticed that in drivers/regulator/qcom_smd-regulator.c there are
supply names such as:
"vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18"
This gets looked up in the DT (with the string "-supply" appended) but
this will always fail due to the name exceeding the 32 character
maximum of a DT attribute and getting truncated. Is this a known
issue? I'm curious as to why MSM8916 users are not finding this a
problem in practice.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PM8916 RPM regulator supply names too long
2017-12-12 15:11 PM8916 RPM regulator supply names too long Will Newton
@ 2017-12-13 0:15 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2017-12-13 0:15 UTC (permalink / raw)
To: Will Newton; +Cc: linux-arm-msm
On Tue 12 Dec 07:11 PST 2017, Will Newton wrote:
> Hi,
>
> I noticed that in drivers/regulator/qcom_smd-regulator.c there are
> supply names such as:
>
> "vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18"
>
> This gets looked up in the DT (with the string "-supply" appended) but
> this will always fail due to the name exceeding the 32 character
> maximum of a DT attribute and getting truncated.
That's not good, I guess we have to game the system and rename this
"vdd_l8-l18" or something like that.
> Is this a known issue? I'm curious as to why MSM8916 users are not
> finding this a problem in practice.
I haven't heard anyone complain about this before.
The reason why we haven't this this issue is because at least on db410c
the supply is vph_pwr which is an always on, fixed, 3.7V line, which we
don't describe in DT (but probably should for completeness).
Regards,
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-13 0:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-12 15:11 PM8916 RPM regulator supply names too long Will Newton
2017-12-13 0:15 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox