[PATCH 1/2] regulator: qcom_smd: add get_voltage to MP5496

[PATCH 1/2] regulator: qcom_smd: add get_voltage to MP5496

[Robert Marko]

Add the get_voltage OP to MP5496 ops using the generic rpm_reg_get_voltage.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 drivers/regulator/qcom_smd-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 8490aa8eecb1..5ec68250e79d 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -205,6 +205,7 @@ static const struct regulator_ops rpm_mp5496_ops = {
 	.is_enabled = rpm_reg_is_enabled,
 	.list_voltage = regulator_list_voltage_linear_range,
 
+	.get_voltage = rpm_reg_get_voltage,
 	.set_voltage = rpm_reg_set_voltage,
 };
 
-- 
2.36.1

[PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges

[Robert Marko]

Currently set MP5496 Buck and LDO ranges dont match its datasheet[1].
According to the datasheet:
Buck range is 0.6-2.1875V with a 12.5mV step
LDO range is 0.8-3.975V with a 25mV step.

So, correct the ranges according to the datasheet[1].

[1] https://www.monolithicpower.com/en/documentview/productdocument/index/version/2/document_type/Datasheet/lang/en/sku/MP5496GR/document_id/6906/

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 drivers/regulator/qcom_smd-regulator.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 5ec68250e79d..6c69359b3ef2 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -724,19 +724,19 @@ static const struct regulator_desc pms405_pldo600 = {
 
 static const struct regulator_desc mp5496_smpa2 = {
 	.linear_ranges = (struct linear_range[]) {
-		REGULATOR_LINEAR_RANGE(725000, 0, 27, 12500),
+		REGULATOR_LINEAR_RANGE(600000, 0, 127, 12500),
 	},
 	.n_linear_ranges = 1,
-	.n_voltages = 28,
+	.n_voltages = 128,
 	.ops = &rpm_mp5496_ops,
 };
 
 static const struct regulator_desc mp5496_ldoa2 = {
 	.linear_ranges = (struct linear_range[]) {
-		REGULATOR_LINEAR_RANGE(1800000, 0, 60, 25000),
+		REGULATOR_LINEAR_RANGE(800000, 0, 127, 25000),
 	},
 	.n_linear_ranges = 1,
-	.n_voltages = 61,
+	.n_voltages = 128,
 	.ops = &rpm_mp5496_ops,
 };
 
-- 
2.36.1

Re: [PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Sat, Jun 04, 2022 at 09:33:00PM +0200, Robert Marko wrote:
> Currently set MP5496 Buck and LDO ranges dont match its datasheet[1].
> According to the datasheet:
> Buck range is 0.6-2.1875V with a 12.5mV step
> LDO range is 0.8-3.975V with a 25mV step.

Doesn't make much difference here but in general fixes like this should
come before new features in a series so they can be applied without
dependency issues.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges

[Robert Marko]

On Tue, 7 Jun 2022 at 21:21, Mark Brown <broonie@kernel.org> wrote:
>
> On Sat, Jun 04, 2022 at 09:33:00PM +0200, Robert Marko wrote:
> > Currently set MP5496 Buck and LDO ranges dont match its datasheet[1].
> > According to the datasheet:
> > Buck range is 0.6-2.1875V with a 12.5mV step
> > LDO range is 0.8-3.975V with a 25mV step.
>
> Doesn't make much difference here but in general fixes like this should
> come before new features in a series so they can be applied without
> dependency issues.

Will do it next time, thanks for the heads up.

Regards,
Robert

Re: [PATCH 1/2] regulator: qcom_smd: add get_voltage to MP5496

[Mark Brown]

On Sat, 4 Jun 2022 21:32:59 +0200, Robert Marko wrote:
> Add the get_voltage OP to MP5496 ops using the generic rpm_reg_get_voltage.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: qcom_smd: add get_voltage to MP5496
      commit: f210f387c8c05ae0bd5312b8b6b85398c20b94f9
[2/2] regulator: qcom_smd: correct MP5496 ranges
      commit: 122e951eb8045338089b086c8bd9b0b9afb04a92

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark