* [PATCH RFC 01/15] dt-bindings: mfd: Split out Qcom RPM MSG RAM
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 3:01 ` Rob Herring
2023-03-11 1:21 ` [PATCH RFC 02/15] arm64: dts: qcom: msm8916: Add simple-mfd to rpm_msg_ram Konrad Dybcio
` (14 subsequent siblings)
15 siblings, 1 reply; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
The RPM Message RAM is a part of the RPM low-power core's RAM that's a
MMIO-mapped region from the main ARM CPUs' POV. It contains sleep stats
divided per "RPM master" (ARM cluster, *DSP, ...), an interrupt controller
(MPM) that's vital in the low-power mode entry/exit sequence, as it
signals the readiness to enter sleep, replays the interrupts after a total
power collapse recovery and is able to receive external interrupts from
other IPs (like the PMIC, TSENS and USB) on the SoC to initiate a wakeup
sequence.
On top of that, it contains some regions that are (ab)used by SMEM (by
design!), but we're not completely sure what ranges are r/w to/from.
This would probably need to be determined on a SoC-by-SoC - or even worse
- firmware-by-firmware basis, but since this region is quite "wild west"
by design (it may be accessed and altered in one form or another by all of
the subsystems at the same time) this shouldn't really worry us..
Split out the bindings and re-model it as a simple-mfd to allow for better
representation of the partitions within and allow child devices (MPM,
master sleep stats - coming soon).
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml | 82 ++++++++++++++++++++++
Documentation/devicetree/bindings/sram/sram.yaml | 2 -
2 files changed, 82 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml b/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml
new file mode 100644
index 000000000000..b1fee2b2d923
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/qcom,rpm-msg-ram.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm RPM Message RAM
+
+maintainers:
+ - Konrad Dybcio <konrad.dybcio@linaro.org>
+
+description:
+ Part of the remote Resource Power Manager (RPM) core's RAM is exposed to
+ the main ARM cores as a MMIO-mapped device and referred to as the RPM
+ Message RAM. It contains per-RPM-master sleep statistics, an interrupt
+ controller (MPM) that's capable of replaying interrupts after a total power
+ collapse of a given master and some memory for mailbox-like functionality.
+ An RPM master is any remote core on the SoC, including APSS (the main ARM
+ clusters), ADSP etc., depending on the platform capabilities.
+
+properties:
+ compatible:
+ items:
+ - const: qcom,rpm-msg-ram
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ # The RPM message RAM should be <=0x7000-long so 1 cell is all it needs.
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ ranges: true
+
+required:
+ - compatible
+ - reg
+
+patternProperties:
+ # The MPM comes at fixed offsets: 0x1b8 on MSM8996 and later, 0x1d0 before it
+ "^interrupt-controller@(1d0|1b8)":
+ type: object
+ oneOf:
+ - $ref: /schemas/interrupt-controller/qcom,mpm.yaml#
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/mailbox/qcom-ipcc.h>
+
+ sram@45f0000 {
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
+ reg = <0x045f0000 0x7000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x045f0000 0x7000>;
+
+ wakegic: interrupt-controller@1b8 {
+ compatible = "qcom,mpm";
+ reg = <0x1b8 0x48>;
+ interrupts = <GIC_SPI 197 IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_SMP2P>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ #power-domain-cells = <0>;
+ interrupt-parent = <&intc>;
+ qcom,mpm-pin-count = <96>;
+ qcom,mpm-pin-map = <5 296>, /* Soundwire wake_irq */
+ <12 422>, /* DWC3 ss_phy_irq */
+ <86 183>, /* MPM wake, SPMI */
+ <89 314>, /* TSENS0 0C */
+ <90 315>, /* TSENS1 0C */
+ <93 164>, /* DWC3 dm_hs_phy_irq */
+ <94 165>; /* DWC3 dp_hs_phy_irq */
+ };
+ };
diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
index 993430be355b..2e9e57b2602f 100644
--- a/Documentation/devicetree/bindings/sram/sram.yaml
+++ b/Documentation/devicetree/bindings/sram/sram.yaml
@@ -34,7 +34,6 @@ properties:
- nvidia,tegra186-sysram
- nvidia,tegra194-sysram
- nvidia,tegra234-sysram
- - qcom,rpm-msg-ram
- rockchip,rk3288-pmu-sram
reg:
@@ -141,7 +140,6 @@ if:
compatible:
contains:
enum:
- - qcom,rpm-msg-ram
- rockchip,rk3288-pmu-sram
then:
required:
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH RFC 01/15] dt-bindings: mfd: Split out Qcom RPM MSG RAM
2023-03-11 1:21 ` [PATCH RFC 01/15] dt-bindings: mfd: Split out Qcom RPM MSG RAM Konrad Dybcio
@ 2023-03-11 3:01 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2023-03-11 3:01 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Rob Herring, Andy Gross, linux-kernel,
Krzysztof Kozlowski, devicetree, Lee Jones, linux-arm-msm
On Sat, 11 Mar 2023 02:21:31 +0100, Konrad Dybcio wrote:
> The RPM Message RAM is a part of the RPM low-power core's RAM that's a
> MMIO-mapped region from the main ARM CPUs' POV. It contains sleep stats
> divided per "RPM master" (ARM cluster, *DSP, ...), an interrupt controller
> (MPM) that's vital in the low-power mode entry/exit sequence, as it
> signals the readiness to enter sleep, replays the interrupts after a total
> power collapse recovery and is able to receive external interrupts from
> other IPs (like the PMIC, TSENS and USB) on the SoC to initiate a wakeup
> sequence.
>
> On top of that, it contains some regions that are (ab)used by SMEM (by
> design!), but we're not completely sure what ranges are r/w to/from.
> This would probably need to be determined on a SoC-by-SoC - or even worse
> - firmware-by-firmware basis, but since this region is quite "wild west"
> by design (it may be accessed and altered in one form or another by all of
> the subsystems at the same time) this shouldn't really worry us..
>
> Split out the bindings and re-model it as a simple-mfd to allow for better
> representation of the partitions within and allow child devices (MPM,
> master sleep stats - coming soon).
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml | 82 ++++++++++++++++++++++
> Documentation/devicetree/bindings/sram/sram.yaml | 2 -
> 2 files changed, 82 insertions(+), 2 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,smem.example.dtb: sram@fc428000: compatible: ['qcom,rpm-msg-ram'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.example.dtb: sram@45f0000: interrupt-controller@1b8: 'oneOf' conditional failed, one must be fixed:
'#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/qcom,rpm-msg-ram.example.dtb: interrupt-controller@1b8: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230311-topic-msg_ram-v1-1-e9c2094daf09@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH RFC 02/15] arm64: dts: qcom: msm8916: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 01/15] dt-bindings: mfd: Split out Qcom RPM MSG RAM Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 03/15] arm64: dts: qcom: msm8953: " Konrad Dybcio
` (13 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 0733c2f4f379..ce27709bd4a6 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -510,7 +510,7 @@ tsens_mode: mode@ec {
};
rpm_msg_ram: sram@60000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x00060000 0x8000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 03/15] arm64: dts: qcom: msm8953: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 01/15] dt-bindings: mfd: Split out Qcom RPM MSG RAM Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 02/15] arm64: dts: qcom: msm8916: Add simple-mfd to rpm_msg_ram Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 04/15] arm64: dts: qcom: msm8976: " Konrad Dybcio
` (12 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index 610f3e3fc0c2..2a8201ab0c37 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -351,7 +351,7 @@ soc: soc@0 {
compatible = "simple-bus";
rpm_msg_ram: sram@60000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x60000 0x8000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 04/15] arm64: dts: qcom: msm8976: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (2 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 03/15] arm64: dts: qcom: msm8953: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 05/15] arm64: dts: qcom: msm8994: " Konrad Dybcio
` (11 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi
index 2d360d05aa5e..93871d975fb6 100644
--- a/arch/arm64/boot/dts/qcom/msm8976.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi
@@ -457,7 +457,7 @@ rng@22000 {
};
rpm_msg_ram: sram@60000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x00060000 0x8000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 05/15] arm64: dts: qcom: msm8994: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (3 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 04/15] arm64: dts: qcom: msm8976: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 06/15] arm64: dts: qcom: msm8996: " Konrad Dybcio
` (10 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index 9ff9d35496d2..37f7c0b2fbdc 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -731,7 +731,7 @@ gcc: clock-controller@fc400000 {
};
rpm_msg_ram: sram@fc428000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0xfc428000 0x4000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 06/15] arm64: dts: qcom: msm8996: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (4 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 05/15] arm64: dts: qcom: msm8994: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 07/15] arm64: dts: qcom: msm8998: " Konrad Dybcio
` (9 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 905678e7175d..9a0c1ebf1e52 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -679,7 +679,7 @@ pciephy_2: phy@3000 {
};
rpm_msg_ram: sram@68000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x00068000 0x6000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 07/15] arm64: dts: qcom: msm8998: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (5 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 06/15] arm64: dts: qcom: msm8996: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 08/15] arm64: dts: qcom: qcs404: " Konrad Dybcio
` (8 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 8bc1c59127e5..6efa1bd138bc 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -833,7 +833,7 @@ gcc: clock-controller@100000 {
};
rpm_msg_ram: sram@778000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x00778000 0x7000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 08/15] arm64: dts: qcom: qcs404: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (6 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 07/15] arm64: dts: qcom: msm8998: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 09/15] arm64: dts: qcom: sdm630: " Konrad Dybcio
` (7 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index bc2ed73afb74..474a042f89f3 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -317,7 +317,7 @@ turingcc: clock-controller@800000 {
};
rpm_msg_ram: sram@60000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x00060000 0x6000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 09/15] arm64: dts: qcom: sdm630: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (7 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 08/15] arm64: dts: qcom: qcs404: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 10/15] arm64: dts: qcom: sm6115: " Konrad Dybcio
` (6 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index 5827cda270a0..e85ec7979d4e 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -548,7 +548,7 @@ gcc: clock-controller@100000 {
};
rpm_msg_ram: sram@778000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x00778000 0x7000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 10/15] arm64: dts: qcom: sm6115: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (8 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 09/15] arm64: dts: qcom: sdm630: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 11/15] arm64: dts: qcom: sm6125: " Konrad Dybcio
` (5 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index fbd67d2c8d78..985c9bd55f05 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -705,7 +705,7 @@ tsens0: thermal-sensor@4410000 {
};
rpm_msg_ram: sram@45f0000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x0 0x045f0000 0x0 0x7000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 11/15] arm64: dts: qcom: sm6125: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (9 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 10/15] arm64: dts: qcom: sm6115: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 12/15] arm64: dts: qcom: sm6375: " Konrad Dybcio
` (4 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
index 65033227718a..fb3cb9c39daf 100644
--- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
@@ -678,7 +678,7 @@ hsusb_phy1: phy@1613000 {
};
rpm_msg_ram: sram@45f0000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0x045f0000 0x7000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 12/15] arm64: dts: qcom: sm6375: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (10 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 11/15] arm64: dts: qcom: sm6125: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 13/15] ARM: dts: qcom-apq8084: " Konrad Dybcio
` (3 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6375.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6375.dtsi b/arch/arm64/boot/dts/qcom/sm6375.dtsi
index 068ee4f72485..7fb158cae948 100644
--- a/arch/arm64/boot/dts/qcom/sm6375.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6375.dtsi
@@ -714,7 +714,7 @@ spmi_bus: spmi@1c40000 {
};
rpm_msg_ram: sram@45f0000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0 0x045f0000 0 0x7000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 13/15] ARM: dts: qcom-apq8084: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (11 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 12/15] arm64: dts: qcom: sm6375: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 14/15] ARM: dts: qcom-msm8226: " Konrad Dybcio
` (2 subsequent siblings)
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm/boot/dts/qcom-apq8084.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
index fabd7455eb8f..c6b33dce6fe8 100644
--- a/arch/arm/boot/dts/qcom-apq8084.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
@@ -716,7 +716,7 @@ tcsr_mutex: hwlock@fd484000 {
};
rpm_msg_ram: sram@fc428000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0xfc428000 0x4000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 14/15] ARM: dts: qcom-msm8226: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (12 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 13/15] ARM: dts: qcom-apq8084: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 1:21 ` [PATCH RFC 15/15] ARM: dts: qcom-msm8974: " Konrad Dybcio
2023-03-11 11:24 ` [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Dmitry Baryshkov
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm/boot/dts/qcom-msm8226.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
index c373081bc21b..b4fb6749fdf8 100644
--- a/arch/arm/boot/dts/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
@@ -587,7 +587,7 @@ frame@f9028000 {
};
rpm_msg_ram: sram@fc428000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0xfc428000 0x4000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH RFC 15/15] ARM: dts: qcom-msm8974: Add simple-mfd to rpm_msg_ram
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (13 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 14/15] ARM: dts: qcom-msm8226: " Konrad Dybcio
@ 2023-03-11 1:21 ` Konrad Dybcio
2023-03-11 11:24 ` [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Dmitry Baryshkov
15 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 1:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Add the missing compatible to make the node compliant with the bindings.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 834ad95515b1..fdc0522fcc0f 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -1064,7 +1064,7 @@ gcc: clock-controller@fc400000 {
};
rpm_msg_ram: sram@fc428000 {
- compatible = "qcom,rpm-msg-ram";
+ compatible = "qcom,rpm-msg-ram", "simple-mfd";
reg = <0xfc428000 0x4000>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd
2023-03-11 1:21 [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Konrad Dybcio
` (14 preceding siblings ...)
2023-03-11 1:21 ` [PATCH RFC 15/15] ARM: dts: qcom-msm8974: " Konrad Dybcio
@ 2023-03-11 11:24 ` Dmitry Baryshkov
2023-03-11 12:40 ` Konrad Dybcio
15 siblings, 1 reply; 19+ messages in thread
From: Dmitry Baryshkov @ 2023-03-11 11:24 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Rob Herring, linux-arm-msm, devicetree,
linux-kernel
On Sat, 11 Mar 2023 at 03:21, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> The Qualcomm RPM message RAM is a part of the RPM low-power processor's
> actual RAM that's exposed to the Application Processors as a MMIO-mapped
> region. It contains a couple of things, most notably the RPM master stats,
> detailing per-master (read: per-subsystem) sleep/wake statistics and an
> interrupt controller that's crucial to achieving full SoC clock and/or
> power collapse states (the MPM). This series tries to prepare the MSG
> RAM node to be a host for such devices.
>
> Depends on https://lore.kernel.org/linux-arm-msm/20230308011705.291337-1-konrad.dybcio@linaro.org/
>
> to solve a warning in the example.
>
> The DTS commits don't add -cells or -ranges, as without children they're
> not of very much use. They'll be introduced along with subnodes.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Konrad Dybcio (15):
> dt-bindings: mfd: Split out Qcom RPM MSG RAM
> arm64: dts: qcom: msm8916: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: msm8953: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: msm8976: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: msm8994: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: msm8996: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: msm8998: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: qcs404: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: sdm630: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: sm6115: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: sm6125: Add simple-mfd to rpm_msg_ram
> arm64: dts: qcom: sm6375: Add simple-mfd to rpm_msg_ram
> ARM: dts: qcom-apq8084: Add simple-mfd to rpm_msg_ram
> ARM: dts: qcom-msm8226: Add simple-mfd to rpm_msg_ram
> ARM: dts: qcom-msm8974: Add simple-mfd to rpm_msg_ram
These commits do not demonstrate the need for simple-mfd (other than
qcom,mpm being mentioned in bindings). I'd suggest limiting the RFC to
a single platform populated with rpm_msg_ram child devices. This way
we can better understand the needs and the requirements for these
patches.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd
2023-03-11 11:24 ` [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd Dmitry Baryshkov
@ 2023-03-11 12:40 ` Konrad Dybcio
0 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2023-03-11 12:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Rob Herring, linux-arm-msm, devicetree,
linux-kernel
On 11.03.2023 12:24, Dmitry Baryshkov wrote:
> On Sat, 11 Mar 2023 at 03:21, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> The Qualcomm RPM message RAM is a part of the RPM low-power processor's
>> actual RAM that's exposed to the Application Processors as a MMIO-mapped
>> region. It contains a couple of things, most notably the RPM master stats,
>> detailing per-master (read: per-subsystem) sleep/wake statistics and an
>> interrupt controller that's crucial to achieving full SoC clock and/or
>> power collapse states (the MPM). This series tries to prepare the MSG
>> RAM node to be a host for such devices.
>>
>> Depends on https://lore.kernel.org/linux-arm-msm/20230308011705.291337-1-konrad.dybcio@linaro.org/
>>
>> to solve a warning in the example.
>>
>> The DTS commits don't add -cells or -ranges, as without children they're
>> not of very much use. They'll be introduced along with subnodes.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> Konrad Dybcio (15):
>> dt-bindings: mfd: Split out Qcom RPM MSG RAM
>> arm64: dts: qcom: msm8916: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: msm8953: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: msm8976: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: msm8994: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: msm8996: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: msm8998: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: qcs404: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: sdm630: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: sm6115: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: sm6125: Add simple-mfd to rpm_msg_ram
>> arm64: dts: qcom: sm6375: Add simple-mfd to rpm_msg_ram
>> ARM: dts: qcom-apq8084: Add simple-mfd to rpm_msg_ram
>> ARM: dts: qcom-msm8226: Add simple-mfd to rpm_msg_ram
>> ARM: dts: qcom-msm8974: Add simple-mfd to rpm_msg_ram
>
> These commits do not demonstrate the need for simple-mfd (other than
> qcom,mpm being mentioned in bindings). I'd suggest limiting the RFC to
> a single platform populated with rpm_msg_ram child devices. This way
> we can better understand the needs and the requirements for these
> patches.
Right.. I was debating whether to just send the bindings as a RFC, but
then I'd have to make simple-mfd optional just to retire it soon..
Konrad
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread