* [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins
@ 2024-03-13 10:27 Paweł Owoc
2024-03-18 5:50 ` Kathiravan Thirumoorthy
2024-04-04 21:22 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Paweł Owoc @ 2024-03-13 10:27 UTC (permalink / raw)
Cc: Robert Marko, Paweł Owoc, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
gpio16 will only be used for LCD support, as its NAND/LCDC data[8]
so its bit 9 of the parallel QPIC interface, and ONFI NAND is only 8
or 16-bit with only 8-bit one being supported in our case so that pin
is unused.
It should be dropped from the default NAND pinctrl configuration
as its unused and only needed for LCD.
Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index e5b89753aa5c..8bed34174460 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -349,7 +349,7 @@ qpic_pins: qpic-state {
"gpio5", "gpio6", "gpio7",
"gpio8", "gpio10", "gpio11",
"gpio12", "gpio13", "gpio14",
- "gpio15", "gpio16", "gpio17";
+ "gpio15", "gpio17";
function = "qpic";
drive-strength = <8>;
bias-disable;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins
2024-03-13 10:27 [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins Paweł Owoc
@ 2024-03-18 5:50 ` Kathiravan Thirumoorthy
2024-04-04 21:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Kathiravan Thirumoorthy @ 2024-03-18 5:50 UTC (permalink / raw)
To: Paweł Owoc
Cc: Robert Marko, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 3/13/2024 3:57 PM, Paweł Owoc wrote:
> gpio16 will only be used for LCD support, as its NAND/LCDC data[8]
> so its bit 9 of the parallel QPIC interface, and ONFI NAND is only 8
> or 16-bit with only 8-bit one being supported in our case so that pin
> is unused.
>
> It should be dropped from the default NAND pinctrl configuration
> as its unused and only needed for LCD.
Matches with downstream.
Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
>
> Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index e5b89753aa5c..8bed34174460 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -349,7 +349,7 @@ qpic_pins: qpic-state {
> "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio10", "gpio11",
> "gpio12", "gpio13", "gpio14",
> - "gpio15", "gpio16", "gpio17";
> + "gpio15", "gpio17";
> function = "qpic";
> drive-strength = <8>;
> bias-disable;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins
2024-03-13 10:27 [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins Paweł Owoc
2024-03-18 5:50 ` Kathiravan Thirumoorthy
@ 2024-04-04 21:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-04-04 21:22 UTC (permalink / raw)
To: Paweł Owoc
Cc: Robert Marko, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Wed, 13 Mar 2024 11:27:06 +0100, Paweł Owoc wrote:
> gpio16 will only be used for LCD support, as its NAND/LCDC data[8]
> so its bit 9 of the parallel QPIC interface, and ONFI NAND is only 8
> or 16-bit with only 8-bit one being supported in our case so that pin
> is unused.
>
> It should be dropped from the default NAND pinctrl configuration
> as its unused and only needed for LCD.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins
commit: 5f78d9213ae753e2242b0f6a5d4a5e98e55ddc76
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-04 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 10:27 [PATCH] arm64: dts: qcom: ipq8074: Remove unused gpio from QPIC pins Paweł Owoc
2024-03-18 5:50 ` Kathiravan Thirumoorthy
2024-04-04 21:22 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox