* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel
2024-11-14 22:07 ` [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel Jakob Hauser
@ 2024-11-15 15:13 ` Rob Herring (Arm)
2024-12-11 0:32 ` Jakob Hauser
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2024-11-15 15:13 UTC (permalink / raw)
To: Jakob Hauser
Cc: ~postmarketos/upstreaming, linux-kernel, Stephan Gerhold,
phone-devel, Konrad Dybcio, linux-arm-msm, Bjorn Andersson
On Thu, 14 Nov 2024 23:07:18 +0100, Jakob Hauser wrote:
> From: Stephan Gerhold <stephan@gerhold.net>
>
> Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the
> Samsung Galaxy S4 Mini Value Edition. By default the panel displays
> everything horizontally flipped, so add "flip-horizontal" to the panel
> node to correct that.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Co-developed-by: Jakob Hauser <jahau@rocketmail.com>
> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
> ---
> Patch base is kernel/git/qcom/linux.git current branch "arm64-for-6.13".
>
> The panel driver was recently added to linux-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c?h=next-20241101
>
> The associated dt-binding in linux-next is:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml?h=next-20241101
> ---
> .../dts/qcom/msm8916-samsung-serranove.dts | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/msm8916-samsung-serranove.dtb' for 20241114220718.12248-1-jahau@rocketmail.com:
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb: /soc@0/power-manager@b088000: failed to match any schema with compatible: ['qcom,msm8916-acc']
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb: /soc@0/power-manager@b098000: failed to match any schema with compatible: ['qcom,msm8916-acc']
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb: /soc@0/power-manager@b0a8000: failed to match any schema with compatible: ['qcom,msm8916-acc']
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb: /soc@0/power-manager@b0b8000: failed to match any schema with compatible: ['qcom,msm8916-acc']
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel
2024-11-14 22:07 ` [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel Jakob Hauser
2024-11-15 15:13 ` Rob Herring (Arm)
@ 2024-12-11 0:32 ` Jakob Hauser
2024-12-14 22:27 ` Konrad Dybcio
2025-01-09 18:27 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Jakob Hauser @ 2024-12-11 0:32 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-kernel, phone-devel,
~postmarketos/upstreaming
Hi Bjorn, Hi Konrad,
gentle reminder that this patch is still open.
Link:
https://lore.kernel.org/linux-arm-msm/20241114220718.12248-1-jahau@rocketmail.com/T/#u
On 14.11.24 23:07, Jakob Hauser wrote:
> From: Stephan Gerhold <stephan@gerhold.net>
>
> Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the
> Samsung Galaxy S4 Mini Value Edition. By default the panel displays
> everything horizontally flipped, so add "flip-horizontal" to the panel
> node to correct that.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Co-developed-by: Jakob Hauser <jahau@rocketmail.com>
> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
> ---
> Patch base is kernel/git/qcom/linux.git current branch "arm64-for-6.13".
>
> The panel driver was recently added to linux-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c?h=next-20241101
>
> The associated dt-binding in linux-next is:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml?h=next-20241101
> ---
> .../dts/qcom/msm8916-samsung-serranove.dts | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
> index 5ce8f1350abc..caad1dead2e0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
> @@ -321,6 +321,41 @@ &blsp_uart2 {
> status = "okay";
> };
>
> +&gpu {
> + status = "okay";
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dsi0 {
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&mdss_default>;
> + pinctrl-1 = <&mdss_sleep>;
> +
> + panel@0 {
> + compatible = "samsung,s6e88a0-ams427ap24";
> + reg = <0>;
> +
> + vdd3-supply = <&pm8916_l17>;
> + vci-supply = <&pm8916_l6>;
> + reset-gpios = <&tlmm 25 GPIO_ACTIVE_LOW>;
> + flip-horizontal;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +};
> +
> +&mdss_dsi0_out {
> + data-lanes = <0 1>;
> + remote-endpoint = <&panel_in>;
> +};
> +
> &mpss_mem {
> reg = <0x0 0x86800000 0x0 0x5a00000>;
> };
> @@ -330,6 +365,13 @@ &pm8916_resin {
> linux,code = <KEY_VOLUMEDOWN>;
> };
>
> +&pm8916_rpm_regulators {
> + pm8916_l17: l17 {
> + regulator-min-microvolt = <2850000>;
> + regulator-max-microvolt = <2850000>;
> + };
> +};
> +
> &pm8916_vib {
> status = "okay";
> };
> @@ -425,6 +467,22 @@ imu_irq_default: imu-irq-default-state {
> bias-disable;
> };
>
> + mdss_default: mdss-default-state {
> + pins = "gpio25";
> + function = "gpio";
> +
> + drive-strength = <8>;
> + bias-disable;
> + };
> +
> + mdss_sleep: mdss-sleep-state {
> + pins = "gpio25";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> muic_i2c_default: muic-i2c-default-state {
> pins = "gpio105", "gpio106";
> function = "gpio";
Kind regards,
Jakob
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel
2024-11-14 22:07 ` [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel Jakob Hauser
2024-11-15 15:13 ` Rob Herring (Arm)
2024-12-11 0:32 ` Jakob Hauser
@ 2024-12-14 22:27 ` Konrad Dybcio
2025-01-09 18:27 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-12-14 22:27 UTC (permalink / raw)
To: Jakob Hauser, Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-kernel, phone-devel,
~postmarketos/upstreaming
On 14.11.2024 11:07 PM, Jakob Hauser wrote:
> From: Stephan Gerhold <stephan@gerhold.net>
>
> Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the
> Samsung Galaxy S4 Mini Value Edition. By default the panel displays
> everything horizontally flipped, so add "flip-horizontal" to the panel
> node to correct that.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Co-developed-by: Jakob Hauser <jahau@rocketmail.com>
> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel
2024-11-14 22:07 ` [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel Jakob Hauser
` (2 preceding siblings ...)
2024-12-14 22:27 ` Konrad Dybcio
@ 2025-01-09 18:27 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2025-01-09 18:27 UTC (permalink / raw)
To: Konrad Dybcio, Jakob Hauser
Cc: Stephan Gerhold, linux-arm-msm, linux-kernel, phone-devel,
~postmarketos/upstreaming
On Thu, 14 Nov 2024 23:07:18 +0100, Jakob Hauser wrote:
> Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the
> Samsung Galaxy S4 Mini Value Edition. By default the panel displays
> everything horizontally flipped, so add "flip-horizontal" to the panel
> node to correct that.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel
commit: 46316370e9257647d81c13782a6201a2256d6f1d
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread