Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: gcc-x1e80100: Enable runtime PM
@ 2025-10-12 23:06 Val Packett
  2025-10-21  9:29 ` Taniya Das
  2025-10-29  9:56 ` Konrad Dybcio
  0 siblings, 2 replies; 3+ messages in thread
From: Val Packett @ 2025-10-12 23:06 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: Val Packett, linux-arm-msm, linux-clk, linux-kernel

Enable the main clock controller driver to participate in runtime
power management.

Signed-off-by: Val Packett <val@packett.cool>
---
Seems like this would be one of the prerequisites for actually reaching
deeper power states.. I've been running with this patch on a Dell
Latitude 7455 for quite a while, did not see any harm for sure.
---
 drivers/clk/qcom/gcc-x1e80100.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c
index 301fc9fc32d8..96bb604c6378 100644
--- a/drivers/clk/qcom/gcc-x1e80100.c
+++ b/drivers/clk/qcom/gcc-x1e80100.c
@@ -6721,6 +6721,7 @@ static const struct qcom_cc_desc gcc_x1e80100_desc = {
 	.num_resets = ARRAY_SIZE(gcc_x1e80100_resets),
 	.gdscs = gcc_x1e80100_gdscs,
 	.num_gdscs = ARRAY_SIZE(gcc_x1e80100_gdscs),
+	.use_rpm = true,
 };
 
 static const struct of_device_id gcc_x1e80100_match_table[] = {
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: gcc-x1e80100: Enable runtime PM
  2025-10-12 23:06 [PATCH] clk: qcom: gcc-x1e80100: Enable runtime PM Val Packett
@ 2025-10-21  9:29 ` Taniya Das
  2025-10-29  9:56 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Taniya Das @ 2025-10-21  9:29 UTC (permalink / raw)
  To: Val Packett, Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: linux-arm-msm, linux-clk, linux-kernel



On 10/13/2025 4:36 AM, Val Packett wrote:
> Enable the main clock controller driver to participate in runtime
> power management.
> 
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> Seems like this would be one of the prerequisites for actually reaching
> deeper power states.. I've been running with this patch on a Dell
> Latitude 7455 for quite a while, did not see any harm for sure.
> ---
>  drivers/clk/qcom/gcc-x1e80100.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c
> index 301fc9fc32d8..96bb604c6378 100644
> --- a/drivers/clk/qcom/gcc-x1e80100.c
> +++ b/drivers/clk/qcom/gcc-x1e80100.c
> @@ -6721,6 +6721,7 @@ static const struct qcom_cc_desc gcc_x1e80100_desc = {
>  	.num_resets = ARRAY_SIZE(gcc_x1e80100_resets),
>  	.gdscs = gcc_x1e80100_gdscs,
>  	.num_gdscs = ARRAY_SIZE(gcc_x1e80100_gdscs),
> +	.use_rpm = true,

This is not required to be set for the global clock controller as 'CX'
is the rail powering this clock controller.

>  };
>  
>  static const struct of_device_id gcc_x1e80100_match_table[] = {

-- 
Thanks,
Taniya Das


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: gcc-x1e80100: Enable runtime PM
  2025-10-12 23:06 [PATCH] clk: qcom: gcc-x1e80100: Enable runtime PM Val Packett
  2025-10-21  9:29 ` Taniya Das
@ 2025-10-29  9:56 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-10-29  9:56 UTC (permalink / raw)
  To: Val Packett, Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: linux-arm-msm, linux-clk, linux-kernel

On 10/13/25 1:06 AM, Val Packett wrote:
> Enable the main clock controller driver to participate in runtime
> power management.

The commit message does not explain whether there's any observable
benefits to this change

> Signed-off-by: Val Packett <val@packett.cool>
> ---
> Seems like this would be one of the prerequisites for actually reaching
> deeper power states.. I've been running with this patch on a Dell
> Latitude 7455 for quite a while, did not see any harm for sure.

"seems like" is vague.. is there any change in behavior that suggests
this really makes a difference?

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-29  9:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-12 23:06 [PATCH] clk: qcom: gcc-x1e80100: Enable runtime PM Val Packett
2025-10-21  9:29 ` Taniya Das
2025-10-29  9:56 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox