From: Qiang Yu <qiang.yu@oss.qualcomm.com>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Qiang Yu <qiang.yu@oss.qualcomm.com>
Subject: [PATCH 4/5] PCI: qcom: Remove MSI-X Capability for Root Ports
Date: Sun, 09 Nov 2025 22:59:43 -0800 [thread overview]
Message-ID: <20251109-remove_cap-v1-4-2208f46f4dc2@oss.qualcomm.com> (raw)
In-Reply-To: <20251109-remove_cap-v1-0-2208f46f4dc2@oss.qualcomm.com>
On some platforms like Glymur, the hardware does not support MSI-X in RC
mode, yet still exposes the MSI-X capability. However, it omits the
required MSI-X Table and PBA structures.
This mismatch can lead to issues where the PCIe port driver requests MSI-X
instead of MSI, causing the Root Port to trigger interrupts by writing to
an uninitialized address, resulting in SMMU faults.
To address this, remove MSI-X capability unconditionally for Root Ports.
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
---
drivers/pci/controller/dwc/pcie-qcom.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 805edbbfe7eba496bc99ca82051dee43d240f359..09443ffbb150e9c91bfd3b2adf15286ef2f00a2a 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1350,6 +1350,8 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp)
goto err_disable_phy;
}
+ dw_pcie_remove_capability(pcie->pci, PCI_CAP_ID_MSIX);
+
qcom_ep_reset_deassert(pcie);
if (pcie->cfg->ops->config_sid) {
--
2.34.1
next prev parent reply other threads:[~2025-11-10 6:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 6:59 [PATCH 0/5] PCI: Remove unsupported or incomplete PCIe Capabilities Qiang Yu
2025-11-10 6:59 ` [PATCH 1/5] PCI: Add preceding capability position support and update drivers Qiang Yu
2025-11-10 6:59 ` [PATCH 2/5] PCI: dwc: Add new APIs to remove standard and extended Capability Qiang Yu
2025-12-23 7:24 ` Niklas Cassel
2025-12-24 6:20 ` Qiang Yu
2025-12-26 21:07 ` Bjorn Helgaas
2025-12-27 5:10 ` Manivannan Sadhasivam
2025-12-28 7:49 ` Qiang Yu
2026-01-09 7:59 ` Qiang Yu
2025-11-10 6:59 ` [PATCH 3/5] PCI: dwc: Remove MSI/MSIX capability if iMSI-RX is used as MSI controller Qiang Yu
2025-11-20 11:18 ` Manivannan Sadhasivam
2025-11-20 14:06 ` Shawn Lin
2025-11-20 17:00 ` Manivannan Sadhasivam
2025-11-21 4:04 ` Shawn Lin
2025-11-21 7:56 ` Qiang Yu
2025-11-28 9:57 ` Qiang Yu
2025-11-28 10:02 ` Shawn Lin
2025-12-04 1:27 ` Brian Norris
2025-12-26 21:25 ` Bjorn Helgaas
2025-12-27 4:58 ` Manivannan Sadhasivam
2025-12-04 1:51 ` Brian Norris
2025-12-18 7:31 ` Manivannan Sadhasivam
2025-12-26 21:31 ` Bjorn Helgaas
2025-12-27 5:21 ` Manivannan Sadhasivam
2025-12-28 7:02 ` Qiang Yu
2025-11-10 6:59 ` Qiang Yu [this message]
2025-11-10 6:59 ` [PATCH 5/5] PCI: qcom: Remove DPC Extended Capability Qiang Yu
2025-12-18 7:35 ` [PATCH 0/5] PCI: Remove unsupported or incomplete PCIe Capabilities Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251109-remove_cap-v1-4-2208f46f4dc2@oss.qualcomm.com \
--to=qiang.yu@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox