* [PATCH] drm/msm: Fix a7xx per pipe register programming
@ 2025-11-26 23:46 Anna Maniscalco
2025-11-27 14:25 ` Konrad Dybcio
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Anna Maniscalco @ 2025-11-26 23:46 UTC (permalink / raw)
To: Rob Clark, Sean Paul, Konrad Dybcio, Akhil P Oommen,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Marijn Suijten,
David Airlie, Simona Vetter, Antonino Maniscalco
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable,
Anna Maniscalco
GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
but it needs to be programmed for both.
Program both pipes in hw_init and introducea separate reglist for it in
order to add this register to the dynamic reglist which supports
restoring registers per pipe.
Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info")
Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
---
drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 +++++++++++++++++++++++++++++--
drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
4 files changed, 109 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
index 29107b362346..c8d0b1d59b68 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
@@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = {
REG_A6XX_UCHE_MODE_CNTL,
REG_A6XX_RB_NC_MODE_CNTL,
REG_A6XX_RB_CMP_DBG_ECO_CNTL,
- REG_A7XX_GRAS_NC_MODE_CNTL,
REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
REG_A6XX_UCHE_GBIF_GX_CONFIG,
REG_A6XX_UCHE_CLIENT_PF,
@@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
+static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
+ { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
+};
+
+DECLARE_ADRENO_REGLIST_PIPE_LIST(a750_reglist_pipe);
+
static const struct adreno_info a7xx_gpus[] = {
{
.chip_ids = ADRENO_CHIP_IDS(0x07000200),
@@ -1548,6 +1553,7 @@ static const struct adreno_info a7xx_gpus[] = {
.protect = &a730_protect,
.pwrup_reglist = &a7xx_pwrup_reglist,
.ifpc_reglist = &a750_ifpc_reglist,
+ .pipe_reglist = &a750_reglist_pipe,
.gbif_cx = a640_gbif,
.gmu_chipid = 0x7050001,
.gmu_cgc_mode = 0x00020202,
@@ -1590,6 +1596,7 @@ static const struct adreno_info a7xx_gpus[] = {
.protect = &a730_protect,
.pwrup_reglist = &a7xx_pwrup_reglist,
.ifpc_reglist = &a750_ifpc_reglist,
+ .pipe_reglist = &a750_reglist_pipe,
.gbif_cx = a640_gbif,
.gmu_chipid = 0x7090100,
.gmu_cgc_mode = 0x00020202,
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index 0200a7e71cdf..b98f3e93d0a8 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -16,6 +16,72 @@
#define GPU_PAS_ID 13
+static void a7xx_aperture_slice_set(struct msm_gpu *gpu, enum adreno_pipe pipe)
+{
+ struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+ struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
+ u32 val;
+
+ val = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe);
+
+ if (a6xx_gpu->cached_aperture == val)
+ return;
+
+ gpu_write(gpu, REG_A7XX_CP_APERTURE_CNTL_HOST, val);
+
+ a6xx_gpu->cached_aperture = val;
+}
+
+static void a7xx_aperture_acquire(struct msm_gpu *gpu, enum adreno_pipe pipe, unsigned long *flags)
+{
+ struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+ struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
+
+ spin_lock_irqsave(&a6xx_gpu->aperture_lock, *flags);
+
+ a7xx_aperture_slice_set(gpu, pipe);
+}
+
+static void a7xx_aperture_release(struct msm_gpu *gpu, unsigned long flags)
+{
+ struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+ struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
+
+ spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
+}
+
+static void a7xx_aperture_clear(struct msm_gpu *gpu)
+{
+ unsigned long flags;
+
+ a7xx_aperture_acquire(gpu, PIPE_NONE, &flags);
+ a7xx_aperture_release(gpu, flags);
+}
+
+static void a7xx_write_pipe(struct msm_gpu *gpu, enum adreno_pipe pipe, u32 offset, u32 data)
+{
+ unsigned long flags;
+
+ a7xx_aperture_acquire(gpu, pipe, &flags);
+ gpu_write(gpu, offset, data);
+ a7xx_aperture_release(gpu, flags);
+}
+
+static u32 a7xx_read_pipe(struct msm_gpu *gpu, enum adreno_pipe pipe, u32 offset)
+{
+ struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+ struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
+ unsigned long flags;
+ u32 val;
+
+ spin_lock_irqsave(&a6xx_gpu->aperture_lock, flags);
+ a7xx_aperture_slice_set(gpu, pipe);
+ val = gpu_read(gpu, offset);
+ spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
+
+ return val;
+}
+
static u64 read_gmu_ao_counter(struct a6xx_gpu *a6xx_gpu)
{
u64 count_hi, count_lo, temp;
@@ -849,9 +915,12 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
min_acc_len_64b << 3 |
hbb_lo << 1 | ubwc_mode);
- if (adreno_is_a7xx(adreno_gpu))
- gpu_write(gpu, REG_A7XX_GRAS_NC_MODE_CNTL,
- FIELD_PREP(GENMASK(8, 5), hbb_lo));
+ if (adreno_is_a7xx(adreno_gpu)) {
+ for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++)
+ a7xx_write_pipe(gpu, pipe_id, REG_A7XX_GRAS_NC_MODE_CNTL,
+ FIELD_PREP(GENMASK(8, 5), hbb_lo));
+ a7xx_aperture_clear(gpu);
+ }
gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL,
min_acc_len_64b << 23 | hbb_lo << 21);
@@ -865,9 +934,11 @@ static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
const struct adreno_reglist_list *reglist;
+ const struct adreno_reglist_pipe_list *pipe_reglist;
void *ptr = a6xx_gpu->pwrup_reglist_ptr;
struct cpu_gpu_lock *lock = ptr;
u32 *dest = (u32 *)&lock->regs[0];
+ u32 pipe_reglist_count = 0;
int i;
lock->gpu_req = lock->cpu_req = lock->turn = 0;
@@ -907,7 +978,19 @@ static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
* (<aperture, shifted 12 bits> <address> <data>), and the length is
* stored as number for triplets in dynamic_list_len.
*/
- lock->dynamic_list_len = 0;
+ pipe_reglist = adreno_gpu->info->a6xx->pipe_reglist;
+ for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++) {
+ for (i = 0; i < pipe_reglist->count; i++) {
+ if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
+ continue;
+ *dest++ = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe_id);
+ *dest++ = pipe_reglist->regs[i].offset;
+ *dest++ = a7xx_read_pipe(gpu, pipe_id,
+ pipe_reglist->regs[i].offset);
+ pipe_reglist_count++;
+ }
+ }
+ lock->dynamic_list_len = pipe_reglist_count;
}
static int a7xx_preempt_start(struct msm_gpu *gpu)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
index 6820216ec5fc..0a1d6acbc638 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
@@ -46,6 +46,7 @@ struct a6xx_info {
const struct adreno_protect *protect;
const struct adreno_reglist_list *pwrup_reglist;
const struct adreno_reglist_list *ifpc_reglist;
+ const struct adreno_reglist_pipe_list *pipe_reglist;
const struct adreno_reglist *gbif_cx;
const struct adreno_reglist_pipe *nonctxt_reglist;
u32 max_slices;
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index 0f8d3de97636..cd1846c1375e 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -182,12 +182,25 @@ struct adreno_reglist_list {
u32 count;
};
+struct adreno_reglist_pipe_list {
+ /** @reg: List of register **/
+ const struct adreno_reglist_pipe *regs;
+ /** @count: Number of registers in the list **/
+ u32 count;
+};
+
#define DECLARE_ADRENO_REGLIST_LIST(name) \
static const struct adreno_reglist_list name = { \
.regs = name ## _regs, \
.count = ARRAY_SIZE(name ## _regs), \
};
+#define DECLARE_ADRENO_REGLIST_PIPE_LIST(name) \
+static const struct adreno_reglist_pipe_list name = { \
+ .regs = name ## _regs, \
+ .count = ARRAY_SIZE(name ## _regs), \
+};
+
struct adreno_gpu {
struct msm_gpu base;
const struct adreno_info *info;
---
base-commit: 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530
change-id: 20251126-gras_nc_mode_fix-7224ee506a39
Best regards,
--
Anna Maniscalco <anna.maniscalco2000@gmail.com>
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-26 23:46 [PATCH] drm/msm: Fix a7xx per pipe register programming Anna Maniscalco
@ 2025-11-27 14:25 ` Konrad Dybcio
2025-11-27 18:14 ` Anna Maniscalco
2025-11-27 21:57 ` Akhil P Oommen
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2025-11-27 14:25 UTC (permalink / raw)
To: Anna Maniscalco, Rob Clark, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, Antonino Maniscalco
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable
On 11/27/25 12:46 AM, Anna Maniscalco wrote:
> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
> but it needs to be programmed for both.
>
> Program both pipes in hw_init and introducea separate reglist for it in
> order to add this register to the dynamic reglist which supports
> restoring registers per pipe.
>
> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info")
> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 +++++++++++++++++++++++++++++--
> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
> 4 files changed, 109 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> index 29107b362346..c8d0b1d59b68 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = {
> REG_A6XX_UCHE_MODE_CNTL,
> REG_A6XX_RB_NC_MODE_CNTL,
> REG_A6XX_RB_CMP_DBG_ECO_CNTL,
> - REG_A7XX_GRAS_NC_MODE_CNTL,
> REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
> REG_A6XX_UCHE_GBIF_GX_CONFIG,
> REG_A6XX_UCHE_CLIENT_PF,
> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
>
> DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
>
> +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
> + { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
At a glance at kgsl, all gen7 GPUs that support concurrent binning (i.e.
not gen7_3_0/a710? and gen7_14_0/whatever that translates to) need this
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-27 14:25 ` Konrad Dybcio
@ 2025-11-27 18:14 ` Anna Maniscalco
2025-11-27 18:23 ` Konrad Dybcio
0 siblings, 1 reply; 9+ messages in thread
From: Anna Maniscalco @ 2025-11-27 18:14 UTC (permalink / raw)
To: Konrad Dybcio, Rob Clark, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, Antonino Maniscalco
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable
On 11/27/25 3:25 PM, Konrad Dybcio wrote:
> On 11/27/25 12:46 AM, Anna Maniscalco wrote:
>> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
>> but it needs to be programmed for both.
>>
>> Program both pipes in hw_init and introducea separate reglist for it in
>> order to add this register to the dynamic reglist which supports
>> restoring registers per pipe.
>>
>> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info")
>> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
>> ---
>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 +++++++++++++++++++++++++++++--
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
>> 4 files changed, 109 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> index 29107b362346..c8d0b1d59b68 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = {
>> REG_A6XX_UCHE_MODE_CNTL,
>> REG_A6XX_RB_NC_MODE_CNTL,
>> REG_A6XX_RB_CMP_DBG_ECO_CNTL,
>> - REG_A7XX_GRAS_NC_MODE_CNTL,
>> REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
>> REG_A6XX_UCHE_GBIF_GX_CONFIG,
>> REG_A6XX_UCHE_CLIENT_PF,
>> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
>>
>> DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
>>
>> +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
>> + { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
> At a glance at kgsl, all gen7 GPUs that support concurrent binning (i.e.
> not gen7_3_0/a710? and gen7_14_0/whatever that translates to) need this
Right.
I wonder if gen7_14_0 could be a702?
If we do support one of those a7xx GPUs that don't have concurrent
binning then I need to have a condition in hw_init for it when
initializing REG_A7XX_GRAS_NC_MODE_CNTL
>
> Konrad
Best regards,
--
Anna Maniscalco <anna.maniscalco2000@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-27 18:14 ` Anna Maniscalco
@ 2025-11-27 18:23 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-11-27 18:23 UTC (permalink / raw)
To: Anna Maniscalco, Rob Clark, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, Antonino Maniscalco
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, stable
On 11/27/25 7:14 PM, Anna Maniscalco wrote:
> On 11/27/25 3:25 PM, Konrad Dybcio wrote:
>> On 11/27/25 12:46 AM, Anna Maniscalco wrote:
>>> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
>>> but it needs to be programmed for both.
>>>
>>> Program both pipes in hw_init and introducea separate reglist for it in
>>> order to add this register to the dynamic reglist which supports
>>> restoring registers per pipe.
>>>
>>> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info")
>>> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
>>> ---
>>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 +++++++++++++++++++++++++++++--
>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
>>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
>>> 4 files changed, 109 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>>> index 29107b362346..c8d0b1d59b68 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>>> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = {
>>> REG_A6XX_UCHE_MODE_CNTL,
>>> REG_A6XX_RB_NC_MODE_CNTL,
>>> REG_A6XX_RB_CMP_DBG_ECO_CNTL,
>>> - REG_A7XX_GRAS_NC_MODE_CNTL,
>>> REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
>>> REG_A6XX_UCHE_GBIF_GX_CONFIG,
>>> REG_A6XX_UCHE_CLIENT_PF,
>>> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
>>> DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
>>> +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
>>> + { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
>> At a glance at kgsl, all gen7 GPUs that support concurrent binning (i.e.
>> not gen7_3_0/a710? and gen7_14_0/whatever that translates to) need this
>
> Right.
>
> I wonder if gen7_14_0 could be a702?
No, a702 is a702 in kgsl
Konrad
>
> If we do support one of those a7xx GPUs that don't have concurrent binning then I need to have a condition in hw_init for it when initializing REG_A7XX_GRAS_NC_MODE_CNTL
>
>>
>> Konrad
>
>
> Best regards,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-26 23:46 [PATCH] drm/msm: Fix a7xx per pipe register programming Anna Maniscalco
2025-11-27 14:25 ` Konrad Dybcio
@ 2025-11-27 21:57 ` Akhil P Oommen
2025-11-27 23:12 ` Anna Maniscalco
2025-11-28 1:59 ` kernel test robot
2025-11-28 2:52 ` kernel test robot
3 siblings, 1 reply; 9+ messages in thread
From: Akhil P Oommen @ 2025-11-27 21:57 UTC (permalink / raw)
To: Anna Maniscalco
Cc: Rob Clark, Sean Paul, Konrad Dybcio, Dmitry Baryshkov,
Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie,
Simona Vetter, Antonino Maniscalco, linux-arm-msm, dri-devel,
freedreno, linux-kernel, stable
On 11/27/2025 5:16 AM, Anna Maniscalco wrote:
> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
> but it needs to be programmed for both.
>
> Program both pipes in hw_init and introducea separate reglist for it in
> order to add this register to the dynamic reglist which supports
> restoring registers per pipe.
>
> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info")
> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 +++++++++++++++++++++++++++++--
> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
> 4 files changed, 109 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> index 29107b362346..c8d0b1d59b68 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = {
> REG_A6XX_UCHE_MODE_CNTL,
> REG_A6XX_RB_NC_MODE_CNTL,
> REG_A6XX_RB_CMP_DBG_ECO_CNTL,
> - REG_A7XX_GRAS_NC_MODE_CNTL,
> REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
> REG_A6XX_UCHE_GBIF_GX_CONFIG,
> REG_A6XX_UCHE_CLIENT_PF,
> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
>
> DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
>
> +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
> + { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
> +};
> +
> +DECLARE_ADRENO_REGLIST_PIPE_LIST(a750_reglist_pipe);
> +
> static const struct adreno_info a7xx_gpus[] = {
> {
> .chip_ids = ADRENO_CHIP_IDS(0x07000200),
> @@ -1548,6 +1553,7 @@ static const struct adreno_info a7xx_gpus[] = {
> .protect = &a730_protect,
> .pwrup_reglist = &a7xx_pwrup_reglist,
> .ifpc_reglist = &a750_ifpc_reglist,
> + .pipe_reglist = &a750_reglist_pipe,
> .gbif_cx = a640_gbif,
> .gmu_chipid = 0x7050001,
> .gmu_cgc_mode = 0x00020202,
> @@ -1590,6 +1596,7 @@ static const struct adreno_info a7xx_gpus[] = {
> .protect = &a730_protect,
> .pwrup_reglist = &a7xx_pwrup_reglist,
> .ifpc_reglist = &a750_ifpc_reglist,
> + .pipe_reglist = &a750_reglist_pipe,
> .gbif_cx = a640_gbif,
> .gmu_chipid = 0x7090100,
> .gmu_cgc_mode = 0x00020202,
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index 0200a7e71cdf..b98f3e93d0a8 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -16,6 +16,72 @@
>
> #define GPU_PAS_ID 13
>
> +static void a7xx_aperture_slice_set(struct msm_gpu *gpu, enum adreno_pipe pipe)
> +{
> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
> + u32 val;
> +
> + val = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe);
> +
> + if (a6xx_gpu->cached_aperture == val)
> + return;
> +
> + gpu_write(gpu, REG_A7XX_CP_APERTURE_CNTL_HOST, val);
> +
> + a6xx_gpu->cached_aperture = val;
> +}
> +
> +static void a7xx_aperture_acquire(struct msm_gpu *gpu, enum adreno_pipe pipe, unsigned long *flags)
> +{
> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
> +
> + spin_lock_irqsave(&a6xx_gpu->aperture_lock, *flags);
> +
> + a7xx_aperture_slice_set(gpu, pipe);
> +}
> +
> +static void a7xx_aperture_release(struct msm_gpu *gpu, unsigned long flags)
> +{
> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
> +
> + spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
> +}
> +
> +static void a7xx_aperture_clear(struct msm_gpu *gpu)
> +{
> + unsigned long flags;
> +
> + a7xx_aperture_acquire(gpu, PIPE_NONE, &flags);
> + a7xx_aperture_release(gpu, flags);
> +}
> +
> +static void a7xx_write_pipe(struct msm_gpu *gpu, enum adreno_pipe pipe, u32 offset, u32 data)
> +{
> + unsigned long flags;
> +
> + a7xx_aperture_acquire(gpu, pipe, &flags);
> + gpu_write(gpu, offset, data);
> + a7xx_aperture_release(gpu, flags);
> +}
> +
> +static u32 a7xx_read_pipe(struct msm_gpu *gpu, enum adreno_pipe pipe, u32 offset)
> +{
> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
> + unsigned long flags;
> + u32 val;
> +
> + spin_lock_irqsave(&a6xx_gpu->aperture_lock, flags);
> + a7xx_aperture_slice_set(gpu, pipe);
> + val = gpu_read(gpu, offset);
> + spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
> +
> + return val;
> +}
> +
All of the above helper routines are unncessary because we access only a
single register under the aperture in a7x hw_init(). Lets drop these and
program the aperture register directly below.
> static u64 read_gmu_ao_counter(struct a6xx_gpu *a6xx_gpu)
> {
> u64 count_hi, count_lo, temp;
> @@ -849,9 +915,12 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
> min_acc_len_64b << 3 |
> hbb_lo << 1 | ubwc_mode);
>
> - if (adreno_is_a7xx(adreno_gpu))
> - gpu_write(gpu, REG_A7XX_GRAS_NC_MODE_CNTL,
> - FIELD_PREP(GENMASK(8, 5), hbb_lo));
> + if (adreno_is_a7xx(adreno_gpu)) {
> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++)
> + a7xx_write_pipe(gpu, pipe_id, REG_A7XX_GRAS_NC_MODE_CNTL,
> + FIELD_PREP(GENMASK(8, 5), hbb_lo));
> + a7xx_aperture_clear(gpu);
> + }
>
> gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL,
> min_acc_len_64b << 23 | hbb_lo << 21);
> @@ -865,9 +934,11 @@ static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
> struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
> const struct adreno_reglist_list *reglist;
> + const struct adreno_reglist_pipe_list *pipe_reglist;
> void *ptr = a6xx_gpu->pwrup_reglist_ptr;
> struct cpu_gpu_lock *lock = ptr;
> u32 *dest = (u32 *)&lock->regs[0];
> + u32 pipe_reglist_count = 0;
> int i;
>
> lock->gpu_req = lock->cpu_req = lock->turn = 0;
> @@ -907,7 +978,19 @@ static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
> * (<aperture, shifted 12 bits> <address> <data>), and the length is
> * stored as number for triplets in dynamic_list_len.
> */
> - lock->dynamic_list_len = 0;
> + pipe_reglist = adreno_gpu->info->a6xx->pipe_reglist;
> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++) {
> + for (i = 0; i < pipe_reglist->count; i++) {
> + if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
> + continue;
> + *dest++ = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe_id);
> + *dest++ = pipe_reglist->regs[i].offset;
> + *dest++ = a7xx_read_pipe(gpu, pipe_id,
> + pipe_reglist->regs[i].offset);
> + pipe_reglist_count++;
> + }
> + }
> + lock->dynamic_list_len = pipe_reglist_count;
> }
>
> static int a7xx_preempt_start(struct msm_gpu *gpu)
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
> index 6820216ec5fc..0a1d6acbc638 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
> @@ -46,6 +46,7 @@ struct a6xx_info {
> const struct adreno_protect *protect;
> const struct adreno_reglist_list *pwrup_reglist;
> const struct adreno_reglist_list *ifpc_reglist;
> + const struct adreno_reglist_pipe_list *pipe_reglist;
> const struct adreno_reglist *gbif_cx;
> const struct adreno_reglist_pipe *nonctxt_reglist;
> u32 max_slices;
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> index 0f8d3de97636..cd1846c1375e 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> @@ -182,12 +182,25 @@ struct adreno_reglist_list {
> u32 count;
> };
>
> +struct adreno_reglist_pipe_list {
> + /** @reg: List of register **/
> + const struct adreno_reglist_pipe *regs;
> + /** @count: Number of registers in the list **/
> + u32 count;
> +};
> +
Please move this chunk down, just above the DECLARE_ADRENO_REGLIST_PIPE_LIST
-Akhil
> #define DECLARE_ADRENO_REGLIST_LIST(name) \
> static const struct adreno_reglist_list name = { \
> .regs = name ## _regs, \
> .count = ARRAY_SIZE(name ## _regs), \
> };
>
> +#define DECLARE_ADRENO_REGLIST_PIPE_LIST(name) \
> +static const struct adreno_reglist_pipe_list name = { \
> + .regs = name ## _regs, \
> + .count = ARRAY_SIZE(name ## _regs), \
> +};
> +
> struct adreno_gpu {
> struct msm_gpu base;
> const struct adreno_info *info;
>
> ---
> base-commit: 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530
> change-id: 20251126-gras_nc_mode_fix-7224ee506a39
>
> Best regards,
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-27 21:57 ` Akhil P Oommen
@ 2025-11-27 23:12 ` Anna Maniscalco
2025-11-28 5:27 ` Akhil P Oommen
0 siblings, 1 reply; 9+ messages in thread
From: Anna Maniscalco @ 2025-11-27 23:12 UTC (permalink / raw)
To: Akhil P Oommen
Cc: Rob Clark, Sean Paul, Konrad Dybcio, Dmitry Baryshkov,
Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie,
Simona Vetter, Antonino Maniscalco, linux-arm-msm, dri-devel,
freedreno, linux-kernel, stable
On 11/27/25 10:57 PM, Akhil P Oommen wrote:
> On 11/27/2025 5:16 AM, Anna Maniscalco wrote:
>> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
>> but it needs to be programmed for both.
>>
>> Program both pipes in hw_init and introducea separate reglist for it in
>> order to add this register to the dynamic reglist which supports
>> restoring registers per pipe.
>>
>> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info")
>> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
>> ---
>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 +++++++++++++++++++++++++++++--
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
>> 4 files changed, 109 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> index 29107b362346..c8d0b1d59b68 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = {
>> REG_A6XX_UCHE_MODE_CNTL,
>> REG_A6XX_RB_NC_MODE_CNTL,
>> REG_A6XX_RB_CMP_DBG_ECO_CNTL,
>> - REG_A7XX_GRAS_NC_MODE_CNTL,
>> REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
>> REG_A6XX_UCHE_GBIF_GX_CONFIG,
>> REG_A6XX_UCHE_CLIENT_PF,
>> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
>>
>> DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
>>
>> +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
>> + { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
>> +};
>> +
>> +DECLARE_ADRENO_REGLIST_PIPE_LIST(a750_reglist_pipe);
>> +
>> static const struct adreno_info a7xx_gpus[] = {
>> {
>> .chip_ids = ADRENO_CHIP_IDS(0x07000200),
>> @@ -1548,6 +1553,7 @@ static const struct adreno_info a7xx_gpus[] = {
>> .protect = &a730_protect,
>> .pwrup_reglist = &a7xx_pwrup_reglist,
>> .ifpc_reglist = &a750_ifpc_reglist,
>> + .pipe_reglist = &a750_reglist_pipe,
>> .gbif_cx = a640_gbif,
>> .gmu_chipid = 0x7050001,
>> .gmu_cgc_mode = 0x00020202,
>> @@ -1590,6 +1596,7 @@ static const struct adreno_info a7xx_gpus[] = {
>> .protect = &a730_protect,
>> .pwrup_reglist = &a7xx_pwrup_reglist,
>> .ifpc_reglist = &a750_ifpc_reglist,
>> + .pipe_reglist = &a750_reglist_pipe,
>> .gbif_cx = a640_gbif,
>> .gmu_chipid = 0x7090100,
>> .gmu_cgc_mode = 0x00020202,
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> index 0200a7e71cdf..b98f3e93d0a8 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> @@ -16,6 +16,72 @@
>>
>> #define GPU_PAS_ID 13
>>
>> +static void a7xx_aperture_slice_set(struct msm_gpu *gpu, enum adreno_pipe pipe)
>> +{
>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>> + u32 val;
>> +
>> + val = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe);
>> +
>> + if (a6xx_gpu->cached_aperture == val)
>> + return;
>> +
>> + gpu_write(gpu, REG_A7XX_CP_APERTURE_CNTL_HOST, val);
>> +
>> + a6xx_gpu->cached_aperture = val;
>> +}
>> +
>> +static void a7xx_aperture_acquire(struct msm_gpu *gpu, enum adreno_pipe pipe, unsigned long *flags)
>> +{
>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>> +
>> + spin_lock_irqsave(&a6xx_gpu->aperture_lock, *flags);
>> +
>> + a7xx_aperture_slice_set(gpu, pipe);
>> +}
>> +
>> +static void a7xx_aperture_release(struct msm_gpu *gpu, unsigned long flags)
>> +{
>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>> +
>> + spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
>> +}
>> +
>> +static void a7xx_aperture_clear(struct msm_gpu *gpu)
>> +{
>> + unsigned long flags;
>> +
>> + a7xx_aperture_acquire(gpu, PIPE_NONE, &flags);
>> + a7xx_aperture_release(gpu, flags);
>> +}
>> +
>> +static void a7xx_write_pipe(struct msm_gpu *gpu, enum adreno_pipe pipe, u32 offset, u32 data)
>> +{
>> + unsigned long flags;
>> +
>> + a7xx_aperture_acquire(gpu, pipe, &flags);
>> + gpu_write(gpu, offset, data);
>> + a7xx_aperture_release(gpu, flags);
>> +}
>> +
>> +static u32 a7xx_read_pipe(struct msm_gpu *gpu, enum adreno_pipe pipe, u32 offset)
>> +{
>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>> + unsigned long flags;
>> + u32 val;
>> +
>> + spin_lock_irqsave(&a6xx_gpu->aperture_lock, flags);
>> + a7xx_aperture_slice_set(gpu, pipe);
>> + val = gpu_read(gpu, offset);
>> + spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
>> +
>> + return val;
>> +}
>> +
> All of the above helper routines are unncessary because we access only a
> single register under the aperture in a7x hw_init(). Lets drop these and
> program the aperture register directly below.
We also access (read) it in a7xx_patch_pwrup_reglist though, so do we
want to inline it twice?
>
>
>> static u64 read_gmu_ao_counter(struct a6xx_gpu *a6xx_gpu)
>> {
>> u64 count_hi, count_lo, temp;
>> @@ -849,9 +915,12 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
>> min_acc_len_64b << 3 |
>> hbb_lo << 1 | ubwc_mode);
>>
>> - if (adreno_is_a7xx(adreno_gpu))
>> - gpu_write(gpu, REG_A7XX_GRAS_NC_MODE_CNTL,
>> - FIELD_PREP(GENMASK(8, 5), hbb_lo));
>> + if (adreno_is_a7xx(adreno_gpu)) {
>> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++)
>> + a7xx_write_pipe(gpu, pipe_id, REG_A7XX_GRAS_NC_MODE_CNTL,
>> + FIELD_PREP(GENMASK(8, 5), hbb_lo));
>> + a7xx_aperture_clear(gpu);
>> + }
>>
>> gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL,
>> min_acc_len_64b << 23 | hbb_lo << 21);
>> @@ -865,9 +934,11 @@ static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
>> struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>> struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>> const struct adreno_reglist_list *reglist;
>> + const struct adreno_reglist_pipe_list *pipe_reglist;
>> void *ptr = a6xx_gpu->pwrup_reglist_ptr;
>> struct cpu_gpu_lock *lock = ptr;
>> u32 *dest = (u32 *)&lock->regs[0];
>> + u32 pipe_reglist_count = 0;
>> int i;
>>
>> lock->gpu_req = lock->cpu_req = lock->turn = 0;
>> @@ -907,7 +978,19 @@ static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
>> * (<aperture, shifted 12 bits> <address> <data>), and the length is
>> * stored as number for triplets in dynamic_list_len.
>> */
>> - lock->dynamic_list_len = 0;
>> + pipe_reglist = adreno_gpu->info->a6xx->pipe_reglist;
>> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++) {
>> + for (i = 0; i < pipe_reglist->count; i++) {
>> + if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
>> + continue;
>> + *dest++ = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe_id);
>> + *dest++ = pipe_reglist->regs[i].offset;
>> + *dest++ = a7xx_read_pipe(gpu, pipe_id,
>> + pipe_reglist->regs[i].offset);
>> + pipe_reglist_count++;
>> + }
>> + }
>> + lock->dynamic_list_len = pipe_reglist_count;
>> }
>>
>> static int a7xx_preempt_start(struct msm_gpu *gpu)
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
>> index 6820216ec5fc..0a1d6acbc638 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
>> @@ -46,6 +46,7 @@ struct a6xx_info {
>> const struct adreno_protect *protect;
>> const struct adreno_reglist_list *pwrup_reglist;
>> const struct adreno_reglist_list *ifpc_reglist;
>> + const struct adreno_reglist_pipe_list *pipe_reglist;
>> const struct adreno_reglist *gbif_cx;
>> const struct adreno_reglist_pipe *nonctxt_reglist;
>> u32 max_slices;
>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> index 0f8d3de97636..cd1846c1375e 100644
>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> @@ -182,12 +182,25 @@ struct adreno_reglist_list {
>> u32 count;
>> };
>>
>> +struct adreno_reglist_pipe_list {
>> + /** @reg: List of register **/
>> + const struct adreno_reglist_pipe *regs;
>> + /** @count: Number of registers in the list **/
>> + u32 count;
>> +};
>> +
> Please move this chunk down, just above the DECLARE_ADRENO_REGLIST_PIPE_LIST
>
> -Akhil
>
>> #define DECLARE_ADRENO_REGLIST_LIST(name) \
>> static const struct adreno_reglist_list name = { \
>> .regs = name ## _regs, \
>> .count = ARRAY_SIZE(name ## _regs), \
>> };
>>
>> +#define DECLARE_ADRENO_REGLIST_PIPE_LIST(name) \
>> +static const struct adreno_reglist_pipe_list name = { \
>> + .regs = name ## _regs, \
>> + .count = ARRAY_SIZE(name ## _regs), \
>> +};
>> +
>> struct adreno_gpu {
>> struct msm_gpu base;
>> const struct adreno_info *info;
>>
>> ---
>> base-commit: 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530
>> change-id: 20251126-gras_nc_mode_fix-7224ee506a39
>>
>> Best regards,
Best regards,
--
Anna Maniscalco <anna.maniscalco2000@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-27 23:12 ` Anna Maniscalco
@ 2025-11-28 5:27 ` Akhil P Oommen
0 siblings, 0 replies; 9+ messages in thread
From: Akhil P Oommen @ 2025-11-28 5:27 UTC (permalink / raw)
To: Anna Maniscalco
Cc: Rob Clark, Sean Paul, Konrad Dybcio, Dmitry Baryshkov,
Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie,
Simona Vetter, Antonino Maniscalco, linux-arm-msm, dri-devel,
freedreno, linux-kernel, stable
On 11/28/2025 4:42 AM, Anna Maniscalco wrote:
> On 11/27/25 10:57 PM, Akhil P Oommen wrote:
>> On 11/27/2025 5:16 AM, Anna Maniscalco wrote:
>>> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe
>>> but it needs to be programmed for both.
>>>
>>> Program both pipes in hw_init and introducea separate reglist for it in
>>> order to add this register to the dynamic reglist which supports
>>> restoring registers per pipe.
>>>
>>> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to
>>> a6xx_info")
>>> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
>>> ---
>>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 9 ++-
>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 91 ++++++++++++++++++++
>>> +++++++++--
>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
>>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 +++++
>>> 4 files changed, 109 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/
>>> drm/msm/adreno/a6xx_catalog.c
>>> index 29107b362346..c8d0b1d59b68 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
>>> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[]
>>> = {
>>> REG_A6XX_UCHE_MODE_CNTL,
>>> REG_A6XX_RB_NC_MODE_CNTL,
>>> REG_A6XX_RB_CMP_DBG_ECO_CNTL,
>>> - REG_A7XX_GRAS_NC_MODE_CNTL,
>>> REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE,
>>> REG_A6XX_UCHE_GBIF_GX_CONFIG,
>>> REG_A6XX_UCHE_CLIENT_PF,
>>> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = {
>>> DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist);
>>> +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = {
>>> + { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) },
>>> +};
>>> +
>>> +DECLARE_ADRENO_REGLIST_PIPE_LIST(a750_reglist_pipe);
>>> +
>>> static const struct adreno_info a7xx_gpus[] = {
>>> {
>>> .chip_ids = ADRENO_CHIP_IDS(0x07000200),
>>> @@ -1548,6 +1553,7 @@ static const struct adreno_info a7xx_gpus[] = {
>>> .protect = &a730_protect,
>>> .pwrup_reglist = &a7xx_pwrup_reglist,
>>> .ifpc_reglist = &a750_ifpc_reglist,
>>> + .pipe_reglist = &a750_reglist_pipe,
>>> .gbif_cx = a640_gbif,
>>> .gmu_chipid = 0x7050001,
>>> .gmu_cgc_mode = 0x00020202,
>>> @@ -1590,6 +1596,7 @@ static const struct adreno_info a7xx_gpus[] = {
>>> .protect = &a730_protect,
>>> .pwrup_reglist = &a7xx_pwrup_reglist,
>>> .ifpc_reglist = &a750_ifpc_reglist,
>>> + .pipe_reglist = &a750_reglist_pipe,
>>> .gbif_cx = a640_gbif,
>>> .gmu_chipid = 0x7090100,
>>> .gmu_cgc_mode = 0x00020202,
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/
>>> msm/adreno/a6xx_gpu.c
>>> index 0200a7e71cdf..b98f3e93d0a8 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>>> @@ -16,6 +16,72 @@
>>> #define GPU_PAS_ID 13
>>> +static void a7xx_aperture_slice_set(struct msm_gpu *gpu, enum
>>> adreno_pipe pipe)
>>> +{
>>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>>> + u32 val;
>>> +
>>> + val = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe);
>>> +
>>> + if (a6xx_gpu->cached_aperture == val)
>>> + return;
>>> +
>>> + gpu_write(gpu, REG_A7XX_CP_APERTURE_CNTL_HOST, val);
>>> +
>>> + a6xx_gpu->cached_aperture = val;
>>> +}
>>> +
>>> +static void a7xx_aperture_acquire(struct msm_gpu *gpu, enum
>>> adreno_pipe pipe, unsigned long *flags)
>>> +{
>>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>>> +
>>> + spin_lock_irqsave(&a6xx_gpu->aperture_lock, *flags);
>>> +
>>> + a7xx_aperture_slice_set(gpu, pipe);
>>> +}
>>> +
>>> +static void a7xx_aperture_release(struct msm_gpu *gpu, unsigned long
>>> flags)
>>> +{
>>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>>> +
>>> + spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
>>> +}
>>> +
>>> +static void a7xx_aperture_clear(struct msm_gpu *gpu)
>>> +{
>>> + unsigned long flags;
>>> +
>>> + a7xx_aperture_acquire(gpu, PIPE_NONE, &flags);
>>> + a7xx_aperture_release(gpu, flags);
>>> +}
>>> +
>>> +static void a7xx_write_pipe(struct msm_gpu *gpu, enum adreno_pipe
>>> pipe, u32 offset, u32 data)
>>> +{
>>> + unsigned long flags;
>>> +
>>> + a7xx_aperture_acquire(gpu, pipe, &flags);
>>> + gpu_write(gpu, offset, data);
>>> + a7xx_aperture_release(gpu, flags);
>>> +}
>>> +
>>> +static u32 a7xx_read_pipe(struct msm_gpu *gpu, enum adreno_pipe
>>> pipe, u32 offset)
>>> +{
>>> + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>>> + struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>>> + unsigned long flags;
>>> + u32 val;
>>> +
>>> + spin_lock_irqsave(&a6xx_gpu->aperture_lock, flags);
>>> + a7xx_aperture_slice_set(gpu, pipe);
>>> + val = gpu_read(gpu, offset);
>>> + spin_unlock_irqrestore(&a6xx_gpu->aperture_lock, flags);
>>> +
>>> + return val;
>>> +}
>>> +
>> All of the above helper routines are unncessary because we access only a
>> single register under the aperture in a7x hw_init(). Lets drop these and
>> program the aperture register directly below.
> We also access (read) it in a7xx_patch_pwrup_reglist though, so do we
> want to inline it twice?
Yeah.
>>
>>
>>> static u64 read_gmu_ao_counter(struct a6xx_gpu *a6xx_gpu)
>>> {
>>> u64 count_hi, count_lo, temp;
>>> @@ -849,9 +915,12 @@ static void a6xx_set_ubwc_config(struct msm_gpu
>>> *gpu)
>>> min_acc_len_64b << 3 |
>>> hbb_lo << 1 | ubwc_mode);
>>> - if (adreno_is_a7xx(adreno_gpu))
>>> - gpu_write(gpu, REG_A7XX_GRAS_NC_MODE_CNTL,
>>> - FIELD_PREP(GENMASK(8, 5), hbb_lo));
>>> + if (adreno_is_a7xx(adreno_gpu)) {
>>> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++)
>>> + a7xx_write_pipe(gpu, pipe_id, REG_A7XX_GRAS_NC_MODE_CNTL,
>>> + FIELD_PREP(GENMASK(8, 5), hbb_lo));
>>> + a7xx_aperture_clear(gpu);
>>> + }
>>> gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL,
>>> min_acc_len_64b << 23 | hbb_lo << 21);
>>> @@ -865,9 +934,11 @@ static void a7xx_patch_pwrup_reglist(struct
>>> msm_gpu *gpu)
>>> struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
>>> struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
>>> const struct adreno_reglist_list *reglist;
>>> + const struct adreno_reglist_pipe_list *pipe_reglist;
>>> void *ptr = a6xx_gpu->pwrup_reglist_ptr;
>>> struct cpu_gpu_lock *lock = ptr;
>>> u32 *dest = (u32 *)&lock->regs[0];
>>> + u32 pipe_reglist_count = 0;
>>> int i;
>>> lock->gpu_req = lock->cpu_req = lock->turn = 0;
>>> @@ -907,7 +978,19 @@ static void a7xx_patch_pwrup_reglist(struct
>>> msm_gpu *gpu)
>>> * (<aperture, shifted 12 bits> <address> <data>), and the
>>> length is
>>> * stored as number for triplets in dynamic_list_len.
>>> */
>>> - lock->dynamic_list_len = 0;
>>> + pipe_reglist = adreno_gpu->info->a6xx->pipe_reglist;
NULL check for pipe_reglist?
-Akhil
>>> + for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++) {
>>> + for (i = 0; i < pipe_reglist->count; i++) {
>>> + if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
>>> + continue;
>>> + *dest++ = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe_id);
>>> + *dest++ = pipe_reglist->regs[i].offset;
>>> + *dest++ = a7xx_read_pipe(gpu, pipe_id,
>>> + pipe_reglist->regs[i].offset);
>>> + pipe_reglist_count++;
>>> + }
>>> + }
>>> + lock->dynamic_list_len = pipe_reglist_count;
>>> }
>>> static int a7xx_preempt_start(struct msm_gpu *gpu)
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/
>>> msm/adreno/a6xx_gpu.h
>>> index 6820216ec5fc..0a1d6acbc638 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
>>> @@ -46,6 +46,7 @@ struct a6xx_info {
>>> const struct adreno_protect *protect;
>>> const struct adreno_reglist_list *pwrup_reglist;
>>> const struct adreno_reglist_list *ifpc_reglist;
>>> + const struct adreno_reglist_pipe_list *pipe_reglist;
>>> const struct adreno_reglist *gbif_cx;
>>> const struct adreno_reglist_pipe *nonctxt_reglist;
>>> u32 max_slices;
>>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/
>>> drm/msm/adreno/adreno_gpu.h
>>> index 0f8d3de97636..cd1846c1375e 100644
>>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>> @@ -182,12 +182,25 @@ struct adreno_reglist_list {
>>> u32 count;
>>> };
>>> +struct adreno_reglist_pipe_list {
>>> + /** @reg: List of register **/
>>> + const struct adreno_reglist_pipe *regs;
>>> + /** @count: Number of registers in the list **/
>>> + u32 count;
>>> +};
>>> +
>> Please move this chunk down, just above the
>> DECLARE_ADRENO_REGLIST_PIPE_LIST
>>
>> -Akhil
>>
>>> #define DECLARE_ADRENO_REGLIST_LIST(name) \
>>> static const struct adreno_reglist_list name = { \
>>> .regs = name ## _regs, \
>>> .count = ARRAY_SIZE(name ## _regs), \
>>> };
>>> +#define DECLARE_ADRENO_REGLIST_PIPE_LIST(name) \
>>> +static const struct adreno_reglist_pipe_list name = { \
>>> + .regs = name ## _regs, \
>>> + .count = ARRAY_SIZE(name ## _regs), \
>>> +};
>>> +
>>> struct adreno_gpu {
>>> struct msm_gpu base;
>>> const struct adreno_info *info;
>>>
>>> ---
>>> base-commit: 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530
>>> change-id: 20251126-gras_nc_mode_fix-7224ee506a39
>>>
>>> Best regards,
>
>
> Best regards,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-26 23:46 [PATCH] drm/msm: Fix a7xx per pipe register programming Anna Maniscalco
2025-11-27 14:25 ` Konrad Dybcio
2025-11-27 21:57 ` Akhil P Oommen
@ 2025-11-28 1:59 ` kernel test robot
2025-11-28 2:52 ` kernel test robot
3 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2025-11-28 1:59 UTC (permalink / raw)
To: Anna Maniscalco, Rob Clark, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, Antonino Maniscalco
Cc: oe-kbuild-all, linux-arm-msm, dri-devel, freedreno, linux-kernel,
stable, Anna Maniscalco
Hi Anna,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530]
url: https://github.com/intel-lab-lkp/linux/commits/Anna-Maniscalco/drm-msm-Fix-a7xx-per-pipe-register-programming/20251127-074833
base: 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530
patch link: https://lore.kernel.org/r/20251127-gras_nc_mode_fix-v1-1-5c0cf616401f%40gmail.com
patch subject: [PATCH] drm/msm: Fix a7xx per pipe register programming
config: loongarch-randconfig-001-20251128 (https://download.01.org/0day-ci/archive/20251128/202511280900.x5OzOOoJ-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251128/202511280900.x5OzOOoJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511280900.x5OzOOoJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/msm/adreno/a6xx_gpu.c: In function 'a7xx_patch_pwrup_reglist':
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c:984:71: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
984 | if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
vim +984 drivers/gpu/drm/msm/adreno/a6xx_gpu.c
931
932 static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
933 {
934 struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
935 struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
936 const struct adreno_reglist_list *reglist;
937 const struct adreno_reglist_pipe_list *pipe_reglist;
938 void *ptr = a6xx_gpu->pwrup_reglist_ptr;
939 struct cpu_gpu_lock *lock = ptr;
940 u32 *dest = (u32 *)&lock->regs[0];
941 u32 pipe_reglist_count = 0;
942 int i;
943
944 lock->gpu_req = lock->cpu_req = lock->turn = 0;
945
946 reglist = adreno_gpu->info->a6xx->ifpc_reglist;
947 lock->ifpc_list_len = reglist->count;
948
949 /*
950 * For each entry in each of the lists, write the offset and the current
951 * register value into the GPU buffer
952 */
953 for (i = 0; i < reglist->count; i++) {
954 *dest++ = reglist->regs[i];
955 *dest++ = gpu_read(gpu, reglist->regs[i]);
956 }
957
958 reglist = adreno_gpu->info->a6xx->pwrup_reglist;
959 lock->preemption_list_len = reglist->count;
960
961 for (i = 0; i < reglist->count; i++) {
962 *dest++ = reglist->regs[i];
963 *dest++ = gpu_read(gpu, reglist->regs[i]);
964 }
965
966 /*
967 * The overall register list is composed of
968 * 1. Static IFPC-only registers
969 * 2. Static IFPC + preemption registers
970 * 3. Dynamic IFPC + preemption registers (ex: perfcounter selects)
971 *
972 * The first two lists are static. Size of these lists are stored as
973 * number of pairs in ifpc_list_len and preemption_list_len
974 * respectively. With concurrent binning, Some of the perfcounter
975 * registers being virtualized, CP needs to know the pipe id to program
976 * the aperture inorder to restore the same. Thus, third list is a
977 * dynamic list with triplets as
978 * (<aperture, shifted 12 bits> <address> <data>), and the length is
979 * stored as number for triplets in dynamic_list_len.
980 */
981 pipe_reglist = adreno_gpu->info->a6xx->pipe_reglist;
982 for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++) {
983 for (i = 0; i < pipe_reglist->count; i++) {
> 984 if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
985 continue;
986 *dest++ = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe_id);
987 *dest++ = pipe_reglist->regs[i].offset;
988 *dest++ = a7xx_read_pipe(gpu, pipe_id,
989 pipe_reglist->regs[i].offset);
990 pipe_reglist_count++;
991 }
992 }
993 lock->dynamic_list_len = pipe_reglist_count;
994 }
995
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/msm: Fix a7xx per pipe register programming
2025-11-26 23:46 [PATCH] drm/msm: Fix a7xx per pipe register programming Anna Maniscalco
` (2 preceding siblings ...)
2025-11-28 1:59 ` kernel test robot
@ 2025-11-28 2:52 ` kernel test robot
3 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2025-11-28 2:52 UTC (permalink / raw)
To: Anna Maniscalco, Rob Clark, Sean Paul, Konrad Dybcio,
Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Marijn Suijten, David Airlie, Simona Vetter, Antonino Maniscalco
Cc: llvm, oe-kbuild-all, linux-arm-msm, dri-devel, freedreno,
linux-kernel, stable, Anna Maniscalco
Hi Anna,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530]
url: https://github.com/intel-lab-lkp/linux/commits/Anna-Maniscalco/drm-msm-Fix-a7xx-per-pipe-register-programming/20251127-074833
base: 7bc29d5fb6faff2f547323c9ee8d3a0790cd2530
patch link: https://lore.kernel.org/r/20251127-gras_nc_mode_fix-v1-1-5c0cf616401f%40gmail.com
patch subject: [PATCH] drm/msm: Fix a7xx per pipe register programming
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20251128/202511281253.rIkrIiqt-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251128/202511281253.rIkrIiqt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511281253.rIkrIiqt-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c:984:35: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]
984 | if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/adreno/a6xx_gpu.c:984:35: note: place parentheses around the '==' expression to silence this warning
984 | if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
| ^ ~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/adreno/a6xx_gpu.c:984:35: note: place parentheses around the & expression to evaluate it first
984 | if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
1 warning generated.
vim +984 drivers/gpu/drm/msm/adreno/a6xx_gpu.c
931
932 static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu)
933 {
934 struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
935 struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
936 const struct adreno_reglist_list *reglist;
937 const struct adreno_reglist_pipe_list *pipe_reglist;
938 void *ptr = a6xx_gpu->pwrup_reglist_ptr;
939 struct cpu_gpu_lock *lock = ptr;
940 u32 *dest = (u32 *)&lock->regs[0];
941 u32 pipe_reglist_count = 0;
942 int i;
943
944 lock->gpu_req = lock->cpu_req = lock->turn = 0;
945
946 reglist = adreno_gpu->info->a6xx->ifpc_reglist;
947 lock->ifpc_list_len = reglist->count;
948
949 /*
950 * For each entry in each of the lists, write the offset and the current
951 * register value into the GPU buffer
952 */
953 for (i = 0; i < reglist->count; i++) {
954 *dest++ = reglist->regs[i];
955 *dest++ = gpu_read(gpu, reglist->regs[i]);
956 }
957
958 reglist = adreno_gpu->info->a6xx->pwrup_reglist;
959 lock->preemption_list_len = reglist->count;
960
961 for (i = 0; i < reglist->count; i++) {
962 *dest++ = reglist->regs[i];
963 *dest++ = gpu_read(gpu, reglist->regs[i]);
964 }
965
966 /*
967 * The overall register list is composed of
968 * 1. Static IFPC-only registers
969 * 2. Static IFPC + preemption registers
970 * 3. Dynamic IFPC + preemption registers (ex: perfcounter selects)
971 *
972 * The first two lists are static. Size of these lists are stored as
973 * number of pairs in ifpc_list_len and preemption_list_len
974 * respectively. With concurrent binning, Some of the perfcounter
975 * registers being virtualized, CP needs to know the pipe id to program
976 * the aperture inorder to restore the same. Thus, third list is a
977 * dynamic list with triplets as
978 * (<aperture, shifted 12 bits> <address> <data>), and the length is
979 * stored as number for triplets in dynamic_list_len.
980 */
981 pipe_reglist = adreno_gpu->info->a6xx->pipe_reglist;
982 for (u32 pipe_id = PIPE_BR; pipe_id <= PIPE_BV; pipe_id++) {
983 for (i = 0; i < pipe_reglist->count; i++) {
> 984 if (pipe_reglist->regs[i].pipe & BIT(pipe_id) == 0)
985 continue;
986 *dest++ = A7XX_CP_APERTURE_CNTL_HOST_PIPE(pipe_id);
987 *dest++ = pipe_reglist->regs[i].offset;
988 *dest++ = a7xx_read_pipe(gpu, pipe_id,
989 pipe_reglist->regs[i].offset);
990 pipe_reglist_count++;
991 }
992 }
993 lock->dynamic_list_len = pipe_reglist_count;
994 }
995
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-11-28 5:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 23:46 [PATCH] drm/msm: Fix a7xx per pipe register programming Anna Maniscalco
2025-11-27 14:25 ` Konrad Dybcio
2025-11-27 18:14 ` Anna Maniscalco
2025-11-27 18:23 ` Konrad Dybcio
2025-11-27 21:57 ` Akhil P Oommen
2025-11-27 23:12 ` Anna Maniscalco
2025-11-28 5:27 ` Akhil P Oommen
2025-11-28 1:59 ` kernel test robot
2025-11-28 2:52 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox