[PATCH 0/2] Adds SPMI bus, PMIC and peripherals for qcs8300-ride

[PATCH 0/2] Adds SPMI bus, PMIC and peripherals for qcs8300-ride

[Tingguo Cheng]

Enable SPMI bus, PMIC and PMIC peripherals for qcs8300-ride board. The 
qcs8300-ride use 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).

This patch series depends on the patch series:
https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
Tingguo Cheng (2):
      arm64: dts: qcom: qcs8300: Adds SPMI support
      arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/qcs8300.dtsi     | 22 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)
---
base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
change-id: 20241122-adds-spmi-pmic-peripherals-for-qcs8300-0a3c4458cf7e
prerequisite-change-id: 20240925-qcs8300_initial_dtsi-ea614fe45341:v2
prerequisite-patch-id: 73c78f31fa1d504124d4a82b578a6a14126cccd8
prerequisite-patch-id: 5a01283c8654ae7c696d9c69cb21505b71c5ca27
prerequisite-patch-id: dc633d5aaac790776a8a213ea2faa4890a3f665d
prerequisite-patch-id: 9ecf4cb8b5842ac64e51d6baa0e6c1fbe449ee66

Best regards,
-- 
Tingguo Cheng <quic_tingguoc@quicinc.com>

[PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support

[Tingguo Cheng]

Add the SPMI bus arbiter node for QCS8300 SoC which connected
with PMICs on QCS8300 boards.

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
 			#clock-cells = <0>;
 		};
 
+		spmi_bus: spmi@c440000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0x0 0x0c440000 0x0 0x1100>,
+			      <0x0 0x0c600000 0x0 0x2000000>,
+			      <0x0 0x0e600000 0x0 0x100000>,
+			      <0x0 0x0e700000 0x0 0xa0000>,
+			      <0x0 0x0c40a000 0x0 0x26000>;
+			reg-names = "core",
+				    "chnls",
+				    "obsrvr",
+				    "intr",
+				    "cnfg";
+			qcom,channel = <0>;
+			qcom,ee = <0>;
+			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "periph_irq";
+			interrupt-controller;
+			#interrupt-cells = <4>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+		};
+
 		tlmm: pinctrl@f100000 {
 			compatible = "qcom,qcs8300-tlmm";
 			reg = <0x0 0x0f100000 0x0 0x300000>;

-- 
2.34.1

[PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Tingguo Cheng]

Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).

Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -9,6 +9,7 @@
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 
 #include "qcs8300.dtsi"
+#include "sa8775p-pmics.dtsi"
 / {
 	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
 	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
@@ -223,6 +224,28 @@ &gcc {
 		 <0>;
 };
 
+&pmm8654au_0_pon_resin{
+	linux,code = <KEY_VOLUMEDOWN>;
+
+	status = "okay";
+};
+
+&pmm8654au_2{
+	status = "disabled";
+};
+
+&pmm8654au_2_thermal{
+	status = "disabled";
+};
+
+&pmm8654au_3{
+	status = "disabled";
+};
+
+&pmm8654au_3_thermal{
+	status = "disabled";
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };

-- 
2.34.1

Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support

[Dmitry Baryshkov]

On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
> Add the SPMI bus arbiter node for QCS8300 SoC which connected
> with PMICs on QCS8300 boards.

Could you please comment, what is the version of the SPMI controller /
arbiter?

> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> @@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>  			#clock-cells = <0>;
>  		};
>  
> +		spmi_bus: spmi@c440000 {
> +			compatible = "qcom,spmi-pmic-arb";
> +			reg = <0x0 0x0c440000 0x0 0x1100>,
> +			      <0x0 0x0c600000 0x0 0x2000000>,
> +			      <0x0 0x0e600000 0x0 0x100000>,
> +			      <0x0 0x0e700000 0x0 0xa0000>,
> +			      <0x0 0x0c40a000 0x0 0x26000>;
> +			reg-names = "core",
> +				    "chnls",
> +				    "obsrvr",
> +				    "intr",
> +				    "cnfg";
> +			qcom,channel = <0>;
> +			qcom,ee = <0>;
> +			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "periph_irq";
> +			interrupt-controller;
> +			#interrupt-cells = <4>;
> +			#address-cells = <2>;
> +			#size-cells = <0>;
> +		};
> +
>  		tlmm: pinctrl@f100000 {
>  			compatible = "qcom,qcs8300-tlmm";
>  			reg = <0x0 0x0f100000 0x0 0x300000>;
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Dmitry Baryshkov]

On Tue, Nov 26, 2024 at 05:35:06PM +0800, Tingguo Cheng wrote:
> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -9,6 +9,7 @@
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  
>  #include "qcs8300.dtsi"
> +#include "sa8775p-pmics.dtsi"
>  / {
>  	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>  	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
> @@ -223,6 +224,28 @@ &gcc {
>  		 <0>;
>  };
>  
> +&pmm8654au_0_pon_resin{

Missing space between the curve bracket (here and in all other entries).

> +	linux,code = <KEY_VOLUMEDOWN>;
> +
> +	status = "okay";
> +};
> +
> +&pmm8654au_2{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_2_thermal{
> +	status = "disabled";

Does it work this way?

> +};
> +
> +&pmm8654au_3{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_3_thermal{
> +	status = "disabled";
> +};
> +
>  &qupv3_id_0 {
>  	status = "okay";
>  };
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support

[Tingguo Cheng]

On 11/26/2024 7:50 PM, Dmitry Baryshkov wrote:
> On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
>> Add the SPMI bus arbiter node for QCS8300 SoC which connected
>> with PMICs on QCS8300 boards.
> 
> Could you please comment, what is the version of the SPMI controller /
> arbiter?
Sure, let me add the version information in the commit message.
> 
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>> index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>> @@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>>   			#clock-cells = <0>;
>>   		};
>>   
>> +		spmi_bus: spmi@c440000 {
>> +			compatible = "qcom,spmi-pmic-arb";
>> +			reg = <0x0 0x0c440000 0x0 0x1100>,
>> +			      <0x0 0x0c600000 0x0 0x2000000>,
>> +			      <0x0 0x0e600000 0x0 0x100000>,
>> +			      <0x0 0x0e700000 0x0 0xa0000>,
>> +			      <0x0 0x0c40a000 0x0 0x26000>;
>> +			reg-names = "core",
>> +				    "chnls",
>> +				    "obsrvr",
>> +				    "intr",
>> +				    "cnfg";
>> +			qcom,channel = <0>;
>> +			qcom,ee = <0>;
>> +			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
>> +			interrupt-names = "periph_irq";
>> +			interrupt-controller;
>> +			#interrupt-cells = <4>;
>> +			#address-cells = <2>;
>> +			#size-cells = <0>;
>> +		};
>> +
>>   		tlmm: pinctrl@f100000 {
>>   			compatible = "qcom,qcs8300-tlmm";
>>   			reg = <0x0 0x0f100000 0x0 0x300000>;
>>
>> -- 
>> 2.34.1
>>
> 

-- 
Thank you & BRs
Tingguo

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 11/26/2024 7:54 PM, Dmitry Baryshkov wrote:
> On Tue, Nov 26, 2024 at 05:35:06PM +0800, Tingguo Cheng wrote:
>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -9,6 +9,7 @@
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   
>>   #include "qcs8300.dtsi"
>> +#include "sa8775p-pmics.dtsi"
>>   / {
>>   	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>   	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>> @@ -223,6 +224,28 @@ &gcc {
>>   		 <0>;
>>   };
>>   
>> +&pmm8654au_0_pon_resin{
> 
> Missing space between the curve bracket (here and in all other entries).
Added a space here in next version:v2
> 
>> +	linux,code = <KEY_VOLUMEDOWN>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&pmm8654au_2{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_2_thermal{
>> +	status = "disabled";
> 
> Does it work this way?
Yes, it works. functions are all working as expected. The result is the 
same as the way from writing the DTS nodes from scratch.
> 
>> +};
>> +
>> +&pmm8654au_3{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3_thermal{
>> +	status = "disabled";
>> +};
>> +
>>   &qupv3_id_0 {
>>   	status = "okay";
>>   };
>>
>> -- 
>> 2.34.1
>>
> 

-- 
Thank you & BRs
Tingguo

Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support

[Dmitry Baryshkov]

On Thu, Nov 28, 2024 at 03:55:31PM +0800, Tingguo Cheng wrote:
> 
> 
> On 11/26/2024 7:50 PM, Dmitry Baryshkov wrote:
> > On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
> > > Add the SPMI bus arbiter node for QCS8300 SoC which connected
> > > with PMICs on QCS8300 boards.
> > 
> > Could you please comment, what is the version of the SPMI controller /
> > arbiter?
> Sure, let me add the version information in the commit message.

Answering here would have been easier to follow.

> > 
> > > 
> > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
> > >   1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> > > index 2c35f96c3f289d5e2e57e0e30ef5e17cd1286188..03bf72d6ec5c9ec92f6f53df9253c8c5953e13c4 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
> > > @@ -939,6 +939,28 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
> > >   			#clock-cells = <0>;
> > >   		};
> > > +		spmi_bus: spmi@c440000 {
> > > +			compatible = "qcom,spmi-pmic-arb";
> > > +			reg = <0x0 0x0c440000 0x0 0x1100>,
> > > +			      <0x0 0x0c600000 0x0 0x2000000>,
> > > +			      <0x0 0x0e600000 0x0 0x100000>,
> > > +			      <0x0 0x0e700000 0x0 0xa0000>,
> > > +			      <0x0 0x0c40a000 0x0 0x26000>;
> > > +			reg-names = "core",
> > > +				    "chnls",
> > > +				    "obsrvr",
> > > +				    "intr",
> > > +				    "cnfg";
> > > +			qcom,channel = <0>;
> > > +			qcom,ee = <0>;
> > > +			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> > > +			interrupt-names = "periph_irq";
> > > +			interrupt-controller;
> > > +			#interrupt-cells = <4>;
> > > +			#address-cells = <2>;
> > > +			#size-cells = <0>;
> > > +		};
> > > +
> > >   		tlmm: pinctrl@f100000 {
> > >   			compatible = "qcom,qcs8300-tlmm";
> > >   			reg = <0x0 0x0f100000 0x0 0x300000>;
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > 
> 
> -- 
> Thank you & BRs
> Tingguo
> 

-- 
With best wishes
Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: qcs8300: Adds SPMI support

[Konrad Dybcio]

On 28.11.2024 1:56 PM, Dmitry Baryshkov wrote:
> On Thu, Nov 28, 2024 at 03:55:31PM +0800, Tingguo Cheng wrote:
>>
>>
>> On 11/26/2024 7:50 PM, Dmitry Baryshkov wrote:
>>> On Tue, Nov 26, 2024 at 05:35:05PM +0800, Tingguo Cheng wrote:
>>>> Add the SPMI bus arbiter node for QCS8300 SoC which connected
>>>> with PMICs on QCS8300 boards.
>>>
>>> Could you please comment, what is the version of the SPMI controller /
>>> arbiter?
>> Sure, let me add the version information in the commit message.
> 
> Answering here would have been easier to follow.

Computer suggests v5.2.0

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Konrad Dybcio]

On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
> 
> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -9,6 +9,7 @@
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  
>  #include "qcs8300.dtsi"
> +#include "sa8775p-pmics.dtsi"
>  / {
>  	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>  	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
> @@ -223,6 +224,28 @@ &gcc {
>  		 <0>;
>  };
>  
> +&pmm8654au_0_pon_resin{
> +	linux,code = <KEY_VOLUMEDOWN>;
> +
> +	status = "okay";
> +};
> +
> +&pmm8654au_2{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_2_thermal{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_3{
> +	status = "disabled";
> +};
> +
> +&pmm8654au_3_thermal{
> +	status = "disabled";
> +};

Are all these PMICs absent?

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Konrad Dybcio]

On 29.11.2024 12:14 PM, Konrad Dybcio wrote:
> On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>
>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -9,6 +9,7 @@
>>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>  
>>  #include "qcs8300.dtsi"
>> +#include "sa8775p-pmics.dtsi"
>>  / {
>>  	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>  	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>> @@ -223,6 +224,28 @@ &gcc {
>>  		 <0>;
>>  };
>>  
>> +&pmm8654au_0_pon_resin{
>> +	linux,code = <KEY_VOLUMEDOWN>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&pmm8654au_2{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_2_thermal{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3{
>> +	status = "disabled";
>> +};
>> +
>> +&pmm8654au_3_thermal{
>> +	status = "disabled";
>> +};
> 
> Are all these PMICs absent?

OK I re-read the commit message..

Disabling a lot of things usually points to a backwards approach,
are there any other PMICs on board?

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 11/29/2024 7:30 PM, Konrad Dybcio wrote:
> On 29.11.2024 12:14 PM, Konrad Dybcio wrote:
>> On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
>>> Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
>>> 300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
>>> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
>>>
>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
>>>   1 file changed, 23 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -9,6 +9,7 @@
>>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>   
>>>   #include "qcs8300.dtsi"
>>> +#include "sa8775p-pmics.dtsi"
>>>   / {
>>>   	model = "Qualcomm Technologies, Inc. QCS8300 Ride";
>>>   	compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
>>> @@ -223,6 +224,28 @@ &gcc {
>>>   		 <0>;
>>>   };
>>>   
>>> +&pmm8654au_0_pon_resin{
>>> +	linux,code = <KEY_VOLUMEDOWN>;
>>> +
>>> +	status = "okay";
>>> +};
>>> +
>>> +&pmm8654au_2{
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&pmm8654au_2_thermal{
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&pmm8654au_3{
>>> +	status = "disabled";
>>> +};
>>> +
>>> +&pmm8654au_3_thermal{
>>> +	status = "disabled";
>>> +};
>>
>> Are all these PMICs absent?
 >
Yes, sa8775p/qcs9100 -ride devices get 4 pmics inside, but qcs8300-ride 
gets only 2 pmics inside(0 and 1). So pmm8654au_2 and pmm8654au_3 are 
going to be removed to align with the board configuration.
> 
> OK I re-read the commit message..
> 
> Disabling a lot of things usually points to a backwards approach,
> are there any other PMICs on board?
 >
No any other PMICs on board. There are only 2 PMICs on this type of 
board. And the 2 PMICs is the variant of the PMICs used on 
sa8775p/qcs9100 -ride. From this perspective, just like qcs615-ride 
device, so I reused the original xxx-pmics.dtsi to reflect the 
relationship of "variant".

> 
> Konrad

-- 
Thank you & BRs
Tingguo