[PATCH v2 0/3] Enable Watchdog on QCS8300

[PATCH v2 0/3] Enable Watchdog on QCS8300

[Xin Liu]

Add Watchdog support to the QCS8300 Ride platform. Include the relevant
binding documents accordingly. Additionally, configure Watchdog-related
clock and interrupt in the device tree.

This patch series depends on below patch series:
https://lore.kernel.org/linux-arm-msm/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
--- 
Changes in v2:
- PATCH 1/3：Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
- PATCH 2/3：Drop the Reviewed-by tag that received by v1. Assign a label to
  the wachdog node.
- Link to v1: https://lore.kernel.org/all/20241029031222.1653123-1-quic_liuxin@quicinc.com/

--- 

Xin Liu (3):
  dt-bindings: watchdog: Document Qualcomm QCS8300 watchdog
  arm64: dts: qcom: qcs8300: Add watchdog node
  arm64: dts: qcom: qcs8300-ride: Add watchdog node

 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts                | 4 ++++
 arch/arm64/boot/dts/qcom/qcs8300.dtsi                    | 6 ++++++
 3 files changed, 11 insertions(+)
---
base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422

-- 
2.34.1

[PATCH v2 1/3] dt-bindings: watchdog: Document Qualcomm QCS8300 watchdog

[Xin Liu]

Add devicetree binding for watchdog present on Qualcomm
QCS8300 SoC.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 932393f8c649..200071227d4f 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -26,6 +26,7 @@ properties:
               - qcom,apss-wdt-msm8994
               - qcom,apss-wdt-qcm2290
               - qcom,apss-wdt-qcs404
+              - qcom,apss-wdt-qcs8300
               - qcom,apss-wdt-sa8255p
               - qcom,apss-wdt-sa8775p
               - qcom,apss-wdt-sc7180
-- 
2.34.1

[PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node

[Xin Liu]

Add the watchdog node for QCS8300 SoC.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
index 2c35f96c3f28..13321b1a8af6 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
@@ -1122,6 +1122,12 @@ intc: interrupt-controller@17a00000 {
 			redistributor-stride = <0x0 0x20000>;
 		};
 
+		watchdog: watchdog@17c10000 {
+			compatible = "qcom,apss-wdt-qcs8300", "qcom,kpss-wdt";
+			reg = <0x0 0x17c10000 0x0 0x1000>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		memtimer: timer@17c20000 {
 			compatible = "arm,armv7-timer-mem";
 			reg = <0x0 0x17c20000 0x0 0x1000>;
-- 
2.34.1

Re: [PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node

[Krzysztof Kozlowski]

On 19/11/2024 11:23, Xin Liu wrote:
> Add the watchdog node for QCS8300 SoC.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> ---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

>  arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.
Best regards,
Krzysztof

Re: [PATCH v2 2/3] arm64: dts: qcom: qcs8300: Add watchdog node

[Xin Liu]

在 2024/11/21 1:00, Krzysztof Kozlowski 写道:
> On 19/11/2024 11:23, Xin Liu wrote:
>> Add the watchdog node for QCS8300 SoC.
>>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> ---
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
Thank you for your comments. In my cover letter:
PATCH 2/3：Drop the Reviewed-by tag that received by v1. Assign a label
to the wachdog node.

I have made modifications to the code. Should the reviewed by tag be 
removed in this situation.
>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.
> Best regards,
> Krzysztof

[PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Xin Liu]

Add watchdog clock on the Qualcomm QCS8300 Ride platform.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c3..3024338bcfbc 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -265,3 +265,7 @@ &ufs_mem_phy {
 	vdda-pll-supply = <&vreg_l5a>;
 	status = "okay";
 };
+
+&watchdog {
+    clocks = <&sleep_clk>;
+};
\ No newline at end of file
-- 
2.34.1

Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Krzysztof Kozlowski]

On 19/11/2024 11:23, Xin Liu wrote:
> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 7eed19a694c3..3024338bcfbc 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>  	vdda-pll-supply = <&vreg_l5a>;
>  	status = "okay";
>  };
> +
> +&watchdog {
> +    clocks = <&sleep_clk>;
> +};
> \ No newline at end of file

Look, your patches have errors...


Best regards,
Krzysztof

Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Xin Liu]

在 2024/11/21 0:59, Krzysztof Kozlowski 写道:
> On 19/11/2024 11:23, Xin Liu wrote:
>> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
>>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 7eed19a694c3..3024338bcfbc 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>>   	vdda-pll-supply = <&vreg_l5a>;
>>   	status = "okay";
>>   };
>> +
>> +&watchdog {
>> +    clocks = <&sleep_clk>;
>> +};
>> \ No newline at end of file
> 
> Look, your patches have errors...
> 
This is the information when I apply my patch.
../linux-next$ git am ./wdt/test.patch
Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node
../linux-next$

There are no error messages here.
> 
> Best regards,
> Krzysztof

Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Krzysztof Kozlowski]

On 21/11/2024 10:44, Xin Liu wrote:
> 
> 
> 在 2024/11/21 0:59, Krzysztof Kozlowski 写道:
>> On 19/11/2024 11:23, Xin Liu wrote:
>>> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
>>>
>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index 7eed19a694c3..3024338bcfbc 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>>>   	vdda-pll-supply = <&vreg_l5a>;
>>>   	status = "okay";
>>>   };
>>> +
>>> +&watchdog {
>>> +    clocks = <&sleep_clk>;
>>> +};
>>> \ No newline at end of file
>>
>> Look, your patches have errors...
>>
> This is the information when I apply my patch.
> ../linux-next$ git am ./wdt/test.patch
> Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node
> ../linux-next$
> 
> There are no error messages here.

So I made up that above error message? You sent patch with an error
message. I responded directly under it, so what can I say more?

You refuse to fix this, so I NAK this patch.
Best regards,
Krzysztof

Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Xin Liu]

在 2024/11/21 18:19, Krzysztof Kozlowski 写道:
> On 21/11/2024 10:44, Xin Liu wrote:
>>
>>
>> 在 2024/11/21 0:59, Krzysztof Kozlowski 写道:
>>> On 19/11/2024 11:23, Xin Liu wrote:
>>>> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
>>>>
>>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>>> index 7eed19a694c3..3024338bcfbc 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>>> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>>>>    	vdda-pll-supply = <&vreg_l5a>;
>>>>    	status = "okay";
>>>>    };
>>>> +
>>>> +&watchdog {
>>>> +    clocks = <&sleep_clk>;
>>>> +};
>>>> \ No newline at end of file
>>>
>>> Look, your patches have errors...
>>>
>> This is the information when I apply my patch.
>> ../linux-next$ git am ./wdt/test.patch
>> Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node
>> ../linux-next$
>>
>> There are no error messages here.
> 
> So I made up that above error message? You sent patch with an error
> message. I responded directly under it, so what can I say more?
> 
> You refuse to fix this, so I NAK this patch.
Sorry, that's not what I meant. I realize my mistake and I will fix this 
issue in the next version. Thank you for your comments.
> Best regards,
> Krzysztof

Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

[Dmitry Baryshkov]

On Wed, Nov 20, 2024 at 05:59:21PM +0100, Krzysztof Kozlowski wrote:
> On 19/11/2024 11:23, Xin Liu wrote:
> > Add watchdog clock on the Qualcomm QCS8300 Ride platform.
> > 
> > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> > ---
> >  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > index 7eed19a694c3..3024338bcfbc 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > @@ -265,3 +265,7 @@ &ufs_mem_phy {
> >  	vdda-pll-supply = <&vreg_l5a>;
> >  	status = "okay";
> >  };
> > +
> > +&watchdog {
> > +    clocks = <&sleep_clk>;
> > +};
> > \ No newline at end of file
> 
> Look, your patches have errors...

But it's not an error, it is a part of the patch format, telling that
there was no \n on the last line. We might prefer having files with tail
\n, but I'd not call it an error.

Nevertheless, I agree, it should be fixed.

-- 
With best wishes
Dmitry