Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
	andersson@kernel.org, konrad.dybcio@linaro.org,
	djakov@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
	quic_rgottimu@quicinc.com, quic_kshivnan@quicinc.com,
	conor+dt@kernel.org, dmitry.baryshkov@linaro.org,
	abel.vesa@linaro.org
Subject: Re: [PATCH 2/4] soc: qcom: icc-bwmon: Allow for interrupts to be shared across instances
Date: Fri, 14 Jun 2024 10:24:14 +0200	[thread overview]
Message-ID: <672b6156-e425-4f3b-86f4-02a34cab2b67@linaro.org> (raw)
In-Reply-To: <5df5dc6b-872f-34c5-a6d2-a64f9c881193@quicinc.com>

On 13/06/2024 19:02, Sibi Sankar wrote:
> 
> 
> On 6/4/24 12:16, Krzysztof Kozlowski wrote:
>> On 04/06/2024 03:11, Sibi Sankar wrote:
>>> The multiple BWMONv4 instances available on the X1E80100 SoC use the
>>> same interrupt number. Mark them are shared to allow for re-use across
>>> instances.
> 
> Hey Krzysztof,
> 
> Thanks for taking time to review the series :)
> 
>>
>> Would be nice if you also mention you checked that it is safe to have
>> both devm and shared interrupts (so you investigated possibility of race
>> on exit path).
> 
> I didn't see any problems with devm being used with SHARED when I posted
> it out. After your review comments I went back again to vett the exit
> path for races and ran into an pre-existing splat [1] but the bwmon
> instances work as expected on module removal/re-insertion.

Using devm and shared interrupts is in general sign of possible race
issues and should be avoided. Just "not seeing problems" is not an
argument for me, to be honest.

Best regards,
Krzysztof


  reply	other threads:[~2024-06-14  8:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  1:11 [PATCH 0/4] arm64: dts: qcom: x1e80100: Enable bwmon and fastrpc support Sibi Sankar
2024-06-04  1:11 ` [PATCH 1/4] dt-bindings: interconnect: qcom,msm8998-bwmon: Add X1E80100 BWMON instances Sibi Sankar
2024-06-04  6:46   ` Krzysztof Kozlowski
2024-06-04  1:11 ` [PATCH 2/4] soc: qcom: icc-bwmon: Allow for interrupts to be shared across instances Sibi Sankar
2024-06-04  6:46   ` Krzysztof Kozlowski
2024-06-13 17:02     ` Sibi Sankar
2024-06-14  8:24       ` Krzysztof Kozlowski [this message]
2024-06-14 20:19         ` Sibi Sankar
2024-06-14 21:42           ` Dmitry Baryshkov
2024-06-15  2:15             ` Sibi Sankar
2024-06-04  1:11 ` [PATCH 3/4] arm64: dts: qcom: x1e80100: Add BWMONs Sibi Sankar
2024-06-06  9:09   ` Shivnandan Kumar
2024-06-13 16:51     ` Sibi Sankar
2024-06-06  9:56   ` Konrad Dybcio
2024-06-13 17:18     ` Sibi Sankar
2024-06-04  1:11 ` [PATCH 4/4] arm64: dts: qcom: x1e80100: Add fastrpc nodes Sibi Sankar
2024-06-06  2:45   ` Bjorn Andersson
2024-06-13 16:50     ` Sibi Sankar
2024-06-06 10:30 ` [PATCH 0/4] arm64: dts: qcom: x1e80100: Enable bwmon and fastrpc support Konrad Dybcio
2024-06-13 17:27   ` Sibi Sankar
2024-06-18 14:39     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=672b6156-e425-4f3b-86f4-02a34cab2b67@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_kshivnan@quicinc.com \
    --cc=quic_rgottimu@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox