From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>
Subject: Re: [v2,18/50] drm/msm/dpu: split SM8550 catalog entry to the separate file
Date: Wed, 29 Mar 2023 22:25:57 +0200 [thread overview]
Message-ID: <72ec4076-3d7b-0deb-7691-eaa6e66ee354@linaro.org> (raw)
In-Reply-To: <20230211231259.1308718-19-dmitry.baryshkov@linaro.org>
On 12.02.2023 00:12, Dmitry Baryshkov wrote:
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 178 +++++++++++++++++
> .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 181 +-----------------
> 2 files changed, 180 insertions(+), 179 deletions(-)
> create mode 100644 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h
> new file mode 100644
> index 000000000000..b44b9981431b
> --- /dev/null
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h
> @@ -0,0 +1,178 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Copyright (c) 2022. Qualcomm Innovation Center, Inc. All rights reserved.
> + * Copyright (c) 2015-2018, 2020 The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DPU_9_0_SM8550_H
> +#define _DPU_9_0_SM8550_H
> +
> +static const struct dpu_caps sm8550_dpu_caps = {
> + .max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> + .max_mixer_blendstages = 0xb,
> + .qseed_type = DPU_SSPP_SCALER_QSEED4,
> + .smart_dma_rev = DPU_SSPP_SMART_DMA_V2, /* TODO: v2.5 */
That needs to be rebased on:
a4188f96d0a0 ("drm/msm/dpu: drop smart_dma_rev from dpu_caps")
But with that:
Reviewed-by: Konrad DYbcio <konrad.dybcio@linaro.org>
Konrad
> + .has_src_split = true,
> + .has_dim_layer = true,
> + .has_idle_pc = true,
> + .has_3d_merge = true,
> + .max_linewidth = 5120,
> + .pixel_ram_size = DEFAULT_PIXEL_RAM_SIZE,
> +};
> +
> +static const struct dpu_ubwc_cfg sm8550_ubwc_cfg = {
> + .ubwc_version = DPU_HW_UBWC_VER_40,
> + .highest_bank_bit = 0x3, /* TODO: 2 for LP_DDR4 */
> +};
> +
> +static const struct dpu_mdp_cfg sm8550_mdp[] = {
> + {
> + .name = "top_0", .id = MDP_TOP,
> + .base = 0, .len = 0x494,
> + .features = BIT(DPU_MDP_PERIPH_0_REMOVED),
> + .clk_ctrls[DPU_CLK_CTRL_VIG0] = { .reg_off = 0x4330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_VIG1] = { .reg_off = 0x6330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_VIG2] = { .reg_off = 0x8330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_VIG3] = { .reg_off = 0xa330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_DMA0] = { .reg_off = 0x24330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_DMA1] = { .reg_off = 0x26330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_DMA2] = { .reg_off = 0x28330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_DMA3] = { .reg_off = 0x2a330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_DMA4] = { .reg_off = 0x2c330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_DMA5] = { .reg_off = 0x2e330, .bit_off = 0 },
> + .clk_ctrls[DPU_CLK_CTRL_REG_DMA] = { .reg_off = 0x2bc, .bit_off = 20 },
> + },
> +};
> +
> +static const struct dpu_ctl_cfg sm8550_ctl[] = {
> + {
> + .name = "ctl_0", .id = CTL_0,
> + .base = 0x15000, .len = 0x290,
> + .features = CTL_SM8550_MASK | BIT(DPU_CTL_SPLIT_DISPLAY),
> + .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 9),
> + },
> + {
> + .name = "ctl_1", .id = CTL_1,
> + .base = 0x16000, .len = 0x290,
> + .features = CTL_SM8550_MASK | BIT(DPU_CTL_SPLIT_DISPLAY),
> + .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 10),
> + },
> + {
> + .name = "ctl_2", .id = CTL_2,
> + .base = 0x17000, .len = 0x290,
> + .features = CTL_SM8550_MASK,
> + .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 11),
> + },
> + {
> + .name = "ctl_3", .id = CTL_3,
> + .base = 0x18000, .len = 0x290,
> + .features = CTL_SM8550_MASK,
> + .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 12),
> + },
> + {
> + .name = "ctl_4", .id = CTL_4,
> + .base = 0x19000, .len = 0x290,
> + .features = CTL_SM8550_MASK,
> + .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 13),
> + },
> + {
> + .name = "ctl_5", .id = CTL_5,
> + .base = 0x1a000, .len = 0x290,
> + .features = CTL_SM8550_MASK,
> + .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 23),
> + },
> +};
> +
> +static const struct dpu_sspp_cfg sm8550_sspp[] = {
> + SSPP_BLK("sspp_0", SSPP_VIG0, 0x4000, 0x344, VIG_SC7180_MASK,
> + sm8550_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
> + SSPP_BLK("sspp_1", SSPP_VIG1, 0x6000, 0x344, VIG_SC7180_MASK,
> + sm8550_vig_sblk_1, 4, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG1),
> + SSPP_BLK("sspp_2", SSPP_VIG2, 0x8000, 0x344, VIG_SC7180_MASK,
> + sm8550_vig_sblk_2, 8, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG2),
> + SSPP_BLK("sspp_3", SSPP_VIG3, 0xa000, 0x344, VIG_SC7180_MASK,
> + sm8550_vig_sblk_3, 12, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG3),
> + SSPP_BLK("sspp_8", SSPP_DMA0, 0x24000, 0x344, DMA_SDM845_MASK,
> + sdm845_dma_sblk_0, 1, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA0),
> + SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, 0x344, DMA_SDM845_MASK,
> + sdm845_dma_sblk_1, 5, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA1),
> + SSPP_BLK("sspp_10", SSPP_DMA2, 0x28000, 0x344, DMA_SDM845_MASK,
> + sdm845_dma_sblk_2, 9, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA2),
> + SSPP_BLK("sspp_11", SSPP_DMA3, 0x2a000, 0x344, DMA_SDM845_MASK,
> + sdm845_dma_sblk_3, 13, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA3),
> + SSPP_BLK("sspp_12", SSPP_DMA4, 0x2c000, 0x344, DMA_CURSOR_SDM845_MASK,
> + sm8550_dma_sblk_4, 14, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA4),
> + SSPP_BLK("sspp_13", SSPP_DMA5, 0x2e000, 0x344, DMA_CURSOR_SDM845_MASK,
> + sm8550_dma_sblk_5, 15, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA5),
> +};
> +
> +static const struct dpu_pingpong_cfg sm8550_pp[] = {
> + PP_BLK_DIPHER("pingpong_0", PINGPONG_0, 0x69000, MERGE_3D_0, sc7280_pp_sblk,
> + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8),
> + -1),
> + PP_BLK_DIPHER("pingpong_1", PINGPONG_1, 0x6a000, MERGE_3D_0, sc7280_pp_sblk,
> + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 9),
> + -1),
> + PP_BLK_DIPHER("pingpong_2", PINGPONG_2, 0x6b000, MERGE_3D_1, sc7280_pp_sblk,
> + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 10),
> + -1),
> + PP_BLK_DIPHER("pingpong_3", PINGPONG_3, 0x6c000, MERGE_3D_1, sc7280_pp_sblk,
> + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 11),
> + -1),
> + PP_BLK_DIPHER("pingpong_4", PINGPONG_4, 0x6d000, MERGE_3D_2, sc7280_pp_sblk,
> + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30),
> + -1),
> + PP_BLK_DIPHER("pingpong_5", PINGPONG_5, 0x6e000, MERGE_3D_2, sc7280_pp_sblk,
> + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 31),
> + -1),
> + PP_BLK_DIPHER("pingpong_6", PINGPONG_6, 0x66000, MERGE_3D_3, sc7280_pp_sblk,
> + -1,
> + -1),
> + PP_BLK_DIPHER("pingpong_7", PINGPONG_7, 0x66400, MERGE_3D_3, sc7280_pp_sblk,
> + -1,
> + -1),
> +};
> +
> +static const struct dpu_merge_3d_cfg sm8550_merge_3d[] = {
> + MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x4e000),
> + MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x4f000),
> + MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x50000),
> + MERGE_3D_BLK("merge_3d_3", MERGE_3D_3, 0x66700),
> +};
> +
> +static const struct dpu_intf_cfg sm8550_intf[] = {
> + INTF_BLK("intf_0", INTF_0, 0x34000, 0x300, INTF_DP, MSM_DP_CONTROLLER_0, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 24, 25),
> + /* TODO TE sub-blocks for intf1 & intf2 */
> + INTF_BLK("intf_1", INTF_1, 0x35000, 0x300, INTF_DSI, 0, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 26, 27),
> + INTF_BLK("intf_2", INTF_2, 0x36000, 0x300, INTF_DSI, 1, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 28, 29),
> + INTF_BLK("intf_3", INTF_3, 0x37000, 0x300, INTF_DP, MSM_DP_CONTROLLER_1, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 30, 31),
> +};
> +
> +static const struct dpu_mdss_cfg sm8550_dpu_cfg = {
> + .caps = &sm8550_dpu_caps,
> + .ubwc = &sm8550_ubwc_cfg,
> + .mdp_count = ARRAY_SIZE(sm8550_mdp),
> + .mdp = sm8550_mdp,
> + .ctl_count = ARRAY_SIZE(sm8550_ctl),
> + .ctl = sm8550_ctl,
> + .sspp_count = ARRAY_SIZE(sm8550_sspp),
> + .sspp = sm8550_sspp,
> + .mixer_count = ARRAY_SIZE(sm8150_lm),
> + .mixer = sm8150_lm,
> + .dspp_count = ARRAY_SIZE(sm8150_dspp),
> + .dspp = sm8150_dspp,
> + .pingpong_count = ARRAY_SIZE(sm8550_pp),
> + .pingpong = sm8550_pp,
> + .merge_3d_count = ARRAY_SIZE(sm8550_merge_3d),
> + .merge_3d = sm8550_merge_3d,
> + .intf_count = ARRAY_SIZE(sm8550_intf),
> + .intf = sm8550_intf,
> + .vbif_count = ARRAY_SIZE(sdm845_vbif),
> + .vbif = sdm845_vbif,
> + .reg_dma_count = 1,
> + .dma_cfg = &sm8450_regdma,
> + .perf = &sm8450_perf_data,
> + .mdss_irqs = IRQ_SM8450_MASK,
> +};
> +
> +#endif
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index bd213b2913f5..d97cdabed396 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -442,19 +442,6 @@ static const struct dpu_caps sm8450_dpu_caps = {
> .pixel_ram_size = DEFAULT_PIXEL_RAM_SIZE,
> };
>
> -static const struct dpu_caps sm8550_dpu_caps = {
> - .max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> - .max_mixer_blendstages = 0xb,
> - .qseed_type = DPU_SSPP_SCALER_QSEED4,
> - .smart_dma_rev = DPU_SSPP_SMART_DMA_V2, /* TODO: v2.5 */
> - .has_src_split = true,
> - .has_dim_layer = true,
> - .has_idle_pc = true,
> - .has_3d_merge = true,
> - .max_linewidth = 5120,
> - .pixel_ram_size = DEFAULT_PIXEL_RAM_SIZE,
> -};
> -
> static const struct dpu_caps sc7280_dpu_caps = {
> .max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
> .max_mixer_blendstages = 0x7,
> @@ -524,11 +511,6 @@ static const struct dpu_ubwc_cfg sm8450_ubwc_cfg = {
> .ubwc_swizzle = 0x6,
> };
>
> -static const struct dpu_ubwc_cfg sm8550_ubwc_cfg = {
> - .ubwc_version = DPU_HW_UBWC_VER_40,
> - .highest_bank_bit = 0x3, /* TODO: 2 for LP_DDR4 */
> -};
> -
> static const struct dpu_ubwc_cfg sc7280_ubwc_cfg = {
> .ubwc_version = DPU_HW_UBWC_VER_30,
> .highest_bank_bit = 0x1,
> @@ -753,36 +735,6 @@ static const struct dpu_mdp_cfg sc8280xp_mdp[] = {
> },
> };
>
> -static const struct dpu_mdp_cfg sm8550_mdp[] = {
> - {
> - .name = "top_0", .id = MDP_TOP,
> - .base = 0, .len = 0x494,
> - .features = BIT(DPU_MDP_PERIPH_0_REMOVED),
> - .clk_ctrls[DPU_CLK_CTRL_VIG0] = {
> - .reg_off = 0x4330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_VIG1] = {
> - .reg_off = 0x6330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_VIG2] = {
> - .reg_off = 0x8330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_VIG3] = {
> - .reg_off = 0xa330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_DMA0] = {
> - .reg_off = 0x24330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_DMA1] = {
> - .reg_off = 0x26330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_DMA2] = {
> - .reg_off = 0x28330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_DMA3] = {
> - .reg_off = 0x2a330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_DMA4] = {
> - .reg_off = 0x2c330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_DMA5] = {
> - .reg_off = 0x2e330, .bit_off = 0},
> - .clk_ctrls[DPU_CLK_CTRL_REG_DMA] = {
> - .reg_off = 0x2bc, .bit_off = 20},
> - },
> -};
> -
> static const struct dpu_mdp_cfg qcm2290_mdp[] = {
> {
> .name = "top_0", .id = MDP_TOP,
> @@ -1041,45 +993,6 @@ static const struct dpu_ctl_cfg sm8450_ctl[] = {
> },
> };
>
> -static const struct dpu_ctl_cfg sm8550_ctl[] = {
> - {
> - .name = "ctl_0", .id = CTL_0,
> - .base = 0x15000, .len = 0x290,
> - .features = CTL_SM8550_MASK | BIT(DPU_CTL_SPLIT_DISPLAY),
> - .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 9),
> - },
> - {
> - .name = "ctl_1", .id = CTL_1,
> - .base = 0x16000, .len = 0x290,
> - .features = CTL_SM8550_MASK | BIT(DPU_CTL_SPLIT_DISPLAY),
> - .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 10),
> - },
> - {
> - .name = "ctl_2", .id = CTL_2,
> - .base = 0x17000, .len = 0x290,
> - .features = CTL_SM8550_MASK,
> - .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 11),
> - },
> - {
> - .name = "ctl_3", .id = CTL_3,
> - .base = 0x18000, .len = 0x290,
> - .features = CTL_SM8550_MASK,
> - .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 12),
> - },
> - {
> - .name = "ctl_4", .id = CTL_4,
> - .base = 0x19000, .len = 0x290,
> - .features = CTL_SM8550_MASK,
> - .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 13),
> - },
> - {
> - .name = "ctl_5", .id = CTL_5,
> - .base = 0x1a000, .len = 0x290,
> - .features = CTL_SM8550_MASK,
> - .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 23),
> - },
> -};
> -
> static const struct dpu_ctl_cfg sc7280_ctl[] = {
> {
> .name = "ctl_0", .id = CTL_0,
> @@ -1347,29 +1260,6 @@ static const struct dpu_sspp_sub_blks sm8550_vig_sblk_3 =
> static const struct dpu_sspp_sub_blks sm8550_dma_sblk_4 = _DMA_SBLK("12", 5);
> static const struct dpu_sspp_sub_blks sm8550_dma_sblk_5 = _DMA_SBLK("13", 6);
>
> -static const struct dpu_sspp_cfg sm8550_sspp[] = {
> - SSPP_BLK("sspp_0", SSPP_VIG0, 0x4000, 0x344, VIG_SC7180_MASK,
> - sm8550_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
> - SSPP_BLK("sspp_1", SSPP_VIG1, 0x6000, 0x344, VIG_SC7180_MASK,
> - sm8550_vig_sblk_1, 4, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG1),
> - SSPP_BLK("sspp_2", SSPP_VIG2, 0x8000, 0x344, VIG_SC7180_MASK,
> - sm8550_vig_sblk_2, 8, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG2),
> - SSPP_BLK("sspp_3", SSPP_VIG3, 0xa000, 0x344, VIG_SC7180_MASK,
> - sm8550_vig_sblk_3, 12, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG3),
> - SSPP_BLK("sspp_8", SSPP_DMA0, 0x24000, 0x344, DMA_SDM845_MASK,
> - sdm845_dma_sblk_0, 1, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA0),
> - SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, 0x344, DMA_SDM845_MASK,
> - sdm845_dma_sblk_1, 5, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA1),
> - SSPP_BLK("sspp_10", SSPP_DMA2, 0x28000, 0x344, DMA_SDM845_MASK,
> - sdm845_dma_sblk_2, 9, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA2),
> - SSPP_BLK("sspp_11", SSPP_DMA3, 0x2a000, 0x344, DMA_SDM845_MASK,
> - sdm845_dma_sblk_3, 13, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA3),
> - SSPP_BLK("sspp_12", SSPP_DMA4, 0x2c000, 0x344, DMA_CURSOR_SDM845_MASK,
> - sm8550_dma_sblk_4, 14, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA4),
> - SSPP_BLK("sspp_13", SSPP_DMA5, 0x2e000, 0x344, DMA_CURSOR_SDM845_MASK,
> - sm8550_dma_sblk_5, 15, SSPP_TYPE_DMA, DPU_CLK_CTRL_DMA5),
> -};
> -
> static const struct dpu_sspp_cfg sc7280_sspp[] = {
> SSPP_BLK("sspp_0", SSPP_VIG0, 0x4000, 0x1f8, VIG_SC7280_MASK,
> sc7280_vig_sblk_0, 0, SSPP_TYPE_VIG, DPU_CLK_CTRL_VIG0),
> @@ -1794,33 +1684,6 @@ static const struct dpu_pingpong_cfg sm8450_pp[] = {
> -1),
> };
>
> -static const struct dpu_pingpong_cfg sm8550_pp[] = {
> - PP_BLK_DIPHER("pingpong_0", PINGPONG_0, 0x69000, MERGE_3D_0, sc7280_pp_sblk,
> - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8),
> - -1),
> - PP_BLK_DIPHER("pingpong_1", PINGPONG_1, 0x6a000, MERGE_3D_0, sc7280_pp_sblk,
> - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 9),
> - -1),
> - PP_BLK_DIPHER("pingpong_2", PINGPONG_2, 0x6b000, MERGE_3D_1, sc7280_pp_sblk,
> - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 10),
> - -1),
> - PP_BLK_DIPHER("pingpong_3", PINGPONG_3, 0x6c000, MERGE_3D_1, sc7280_pp_sblk,
> - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 11),
> - -1),
> - PP_BLK_DIPHER("pingpong_4", PINGPONG_4, 0x6d000, MERGE_3D_2, sc7280_pp_sblk,
> - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30),
> - -1),
> - PP_BLK_DIPHER("pingpong_5", PINGPONG_5, 0x6e000, MERGE_3D_2, sc7280_pp_sblk,
> - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 31),
> - -1),
> - PP_BLK_DIPHER("pingpong_6", PINGPONG_6, 0x66000, MERGE_3D_3, sc7280_pp_sblk,
> - -1,
> - -1),
> - PP_BLK_DIPHER("pingpong_7", PINGPONG_7, 0x66400, MERGE_3D_3, sc7280_pp_sblk,
> - -1,
> - -1),
> -};
> -
> /*************************************************************
> * MERGE_3D sub blocks config
> *************************************************************/
> @@ -1851,13 +1714,6 @@ static const struct dpu_merge_3d_cfg sm8450_merge_3d[] = {
> MERGE_3D_BLK("merge_3d_3", MERGE_3D_3, 0x65f00),
> };
>
> -static const struct dpu_merge_3d_cfg sm8550_merge_3d[] = {
> - MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x4e000),
> - MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x4f000),
> - MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x50000),
> - MERGE_3D_BLK("merge_3d_3", MERGE_3D_3, 0x66700),
> -};
> -
> /*************************************************************
> * DSC sub blocks config
> *************************************************************/
> @@ -1971,14 +1827,6 @@ static const struct dpu_intf_cfg sm8450_intf[] = {
> INTF_BLK("intf_3", INTF_3, 0x37000, 0x2c4, INTF_DP, MSM_DP_CONTROLLER_1, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 30, 31),
> };
>
> -static const struct dpu_intf_cfg sm8550_intf[] = {
> - INTF_BLK("intf_0", INTF_0, 0x34000, 0x300, INTF_DP, MSM_DP_CONTROLLER_0, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 24, 25),
> - /* TODO TE sub-blocks for intf1 & intf2 */
> - INTF_BLK("intf_1", INTF_1, 0x35000, 0x300, INTF_DSI, 0, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 26, 27),
> - INTF_BLK("intf_2", INTF_2, 0x36000, 0x300, INTF_DSI, 1, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 28, 29),
> - INTF_BLK("intf_3", INTF_3, 0x37000, 0x300, INTF_DP, MSM_DP_CONTROLLER_1, 24, INTF_SC7280_MASK, MDP_SSPP_TOP0_INTR, 30, 31),
> -};
> -
> /*************************************************************
> * Writeback blocks config
> *************************************************************/
> @@ -2825,33 +2673,6 @@ static const struct dpu_mdss_cfg sm8450_dpu_cfg = {
> .mdss_irqs = IRQ_SM8450_MASK,
> };
>
> -static const struct dpu_mdss_cfg sm8550_dpu_cfg = {
> - .caps = &sm8550_dpu_caps,
> - .ubwc = &sm8550_ubwc_cfg,
> - .mdp_count = ARRAY_SIZE(sm8550_mdp),
> - .mdp = sm8550_mdp,
> - .ctl_count = ARRAY_SIZE(sm8550_ctl),
> - .ctl = sm8550_ctl,
> - .sspp_count = ARRAY_SIZE(sm8550_sspp),
> - .sspp = sm8550_sspp,
> - .mixer_count = ARRAY_SIZE(sm8150_lm),
> - .mixer = sm8150_lm,
> - .dspp_count = ARRAY_SIZE(sm8150_dspp),
> - .dspp = sm8150_dspp,
> - .pingpong_count = ARRAY_SIZE(sm8550_pp),
> - .pingpong = sm8550_pp,
> - .merge_3d_count = ARRAY_SIZE(sm8550_merge_3d),
> - .merge_3d = sm8550_merge_3d,
> - .intf_count = ARRAY_SIZE(sm8550_intf),
> - .intf = sm8550_intf,
> - .vbif_count = ARRAY_SIZE(sdm845_vbif),
> - .vbif = sdm845_vbif,
> - .reg_dma_count = 1,
> - .dma_cfg = &sm8450_regdma,
> - .perf = &sm8450_perf_data,
> - .mdss_irqs = IRQ_SM8450_MASK,
> -};
> -
> static const struct dpu_mdss_cfg sc7280_dpu_cfg = {
> .caps = &sc7280_dpu_caps,
> .ubwc = &sc7280_ubwc_cfg,
> @@ -2898,6 +2719,8 @@ static const struct dpu_mdss_cfg qcm2290_dpu_cfg = {
> .mdss_irqs = IRQ_SC7180_MASK,
> };
>
> +#include "catalog/dpu_9_0_sm8550.h"
> +
> static const struct dpu_mdss_hw_cfg_handler cfg_handler[] = {
> { .hw_rev = DPU_HW_VER_300, .dpu_cfg = &msm8998_dpu_cfg},
> { .hw_rev = DPU_HW_VER_301, .dpu_cfg = &msm8998_dpu_cfg},
next prev parent reply other threads:[~2023-03-29 20:26 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 23:12 [PATCH v2 00/50] drm/msm/dpu: rework HW catalog Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 01/50] drm/msm/dpu: set DPU_MDP_PERIPH_0_REMOVED for sc8280xp Dmitry Baryshkov
2023-03-16 0:27 ` (subset) " Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 02/50] drm/msm/dpu: disable features unsupported by QCM2290 Dmitry Baryshkov
2023-03-16 0:30 ` (subset) " Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 03/50] drm/msm/dpu: fix typo in in sm8550's dma_sblk_5 Dmitry Baryshkov
2023-02-13 17:37 ` Neil Armstrong
2023-02-24 18:06 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 04/50] drm/msm/dpu: fix len of sc7180 ctl blocks Dmitry Baryshkov
2023-02-24 18:12 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 05/50] drm/msm/dpu: fix sm6115 and qcm2290 mixer width limits Dmitry Baryshkov
2023-02-24 19:11 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 06/50] drm/msm/dpu: correct sm8550 scaler Dmitry Baryshkov
2023-02-13 10:41 ` Neil Armstrong
2023-02-13 11:16 ` Dmitry Baryshkov
2023-02-13 17:36 ` neil.armstrong
2023-02-24 20:51 ` Abhinav Kumar
2023-02-25 23:06 ` Dmitry Baryshkov
2023-02-25 23:27 ` Abhinav Kumar
2023-02-26 0:06 ` Dmitry Baryshkov
2023-02-26 2:10 ` Abhinav Kumar
2023-02-26 12:59 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 07/50] drm/msm/dpu: correct sc8280xp scaler Dmitry Baryshkov
2023-02-25 22:55 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 08/50] drm/msm/dpu: correct sm8450 scaler Dmitry Baryshkov
2023-02-25 22:55 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 09/50] drm/msm/dpu: correct sm8250 and sm8350 scaler Dmitry Baryshkov
2023-02-25 22:59 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 10/50] drm/msm/dpu: correct sm6115 scaler Dmitry Baryshkov
2023-02-25 23:11 ` Abhinav Kumar
2023-02-26 0:01 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 11/50] drm/msm/dpu: drop DPU_DIM_LAYER from MIXER_MSM8998_MASK Dmitry Baryshkov
2023-02-28 23:04 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 12/50] drm/msm/dpu: fix clocks settings for msm8998 SSPP blocks Dmitry Baryshkov
2023-02-25 23:32 ` Abhinav Kumar
2023-02-11 23:12 ` [PATCH v2 13/50] drm/msm/dpu: don't use DPU_CLK_CTRL_CURSORn for DMA SSPP clocks Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 14/50] drm/msm/dpu: Allow variable SSPP/INTF_BLK size Dmitry Baryshkov
2023-02-13 11:01 ` Konrad Dybcio
2023-02-13 11:18 ` Dmitry Baryshkov
2023-03-29 20:01 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 15/50] drm/msm/dpu: constify DSC data structures Dmitry Baryshkov
2023-03-29 19:49 ` [v2,15/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 16/50] drm/msm/dpu: mark remaining pp data as const Dmitry Baryshkov
2023-03-29 20:15 ` [v2,16/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 17/50] drm/msm/dpu: move UBWC/memory configuration to separate struct Dmitry Baryshkov
2023-03-29 20:23 ` [v2,17/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 18/50] drm/msm/dpu: split SM8550 catalog entry to the separate file Dmitry Baryshkov
2023-03-29 20:25 ` Konrad Dybcio [this message]
2023-02-11 23:12 ` [PATCH v2 19/50] drm/msm/dpu: split SM8450 " Dmitry Baryshkov
2023-03-30 11:34 ` [v2,19/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 20/50] drm/msm/dpu: split SC8280XP " Dmitry Baryshkov
2023-03-30 11:39 ` [v2,20/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 21/50] drm/msm/dpu: split SC7280 " Dmitry Baryshkov
2023-03-30 11:41 ` [v2,21/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 22/50] drm/msm/dpu: split SM8350 " Dmitry Baryshkov
2023-03-30 11:46 ` [v2,22/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 23/50] drm/msm/dpu: split SM6115 " Dmitry Baryshkov
2023-03-30 11:47 ` [v2,23/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 24/50] drm/msm/dpu: split QCM2290 " Dmitry Baryshkov
2023-03-30 11:50 ` [v2,24/50] " Konrad Dybcio
2023-03-30 11:52 ` Dmitry Baryshkov
2023-03-30 11:53 ` Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 25/50] drm/msm/dpu: split SC7180 " Dmitry Baryshkov
2023-03-30 11:55 ` [v2,25/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 26/50] drm/msm/dpu: split SM8250 " Dmitry Baryshkov
2023-03-30 12:06 ` [v2,26/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 27/50] drm/msm/dpu: split SC8180X " Dmitry Baryshkov
2023-03-30 12:08 ` [v2,27/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 28/50] drm/msm/dpu: split SM8150 " Dmitry Baryshkov
2023-03-30 12:10 ` [v2,28/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 29/50] drm/msm/dpu: split MSM8998 " Dmitry Baryshkov
2023-03-30 12:14 ` [v2,29/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 30/50] drm/msm/dpu: split SDM845 " Dmitry Baryshkov
2023-03-30 12:19 ` [v2,30/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 31/50] drm/msm/dpu: duplicate sdm845 catalog entries Dmitry Baryshkov
2023-03-30 12:21 ` [v2,31/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 32/50] drm/msm/dpu: duplicate sc7180 " Dmitry Baryshkov
2023-03-30 12:22 ` [v2,32/50] " Konrad Dybcio
2023-03-30 12:24 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 33/50] drm/msm/dpu: duplicate sm8150 " Dmitry Baryshkov
2023-03-30 12:26 ` [v2,33/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 34/50] drm/msm/dpu: duplicate sm8250 " Dmitry Baryshkov
2023-03-30 12:27 ` [v2,34/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 35/50] drm/msm/dpu: duplicate sm8350 " Dmitry Baryshkov
2023-03-30 12:27 ` [v2,35/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 36/50] drm/msm/dpu: use defined symbol for sc8280xp's maxwidth Dmitry Baryshkov
2023-03-30 12:28 ` [v2,36/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 37/50] drm/msm/dpu: enable DPU_CTL_SPLIT_DISPLAY for sc8280xp Dmitry Baryshkov
2023-03-30 12:29 ` [v2,37/50] " Konrad Dybcio
2023-03-30 21:32 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 38/50] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450 Dmitry Baryshkov
2023-03-30 12:33 ` [v2,38/50] " Konrad Dybcio
2023-03-30 12:38 ` Dmitry Baryshkov
2023-03-30 12:42 ` Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 39/50] drm/msm/dpu: drop duplicate vig_sblk instances Dmitry Baryshkov
2023-03-07 18:31 ` Dmitry Baryshkov
2023-03-30 12:34 ` [v2,39/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 40/50] drm/msm/dpu: enable DSPP on sc8180x Dmitry Baryshkov
2023-03-30 12:39 ` [v2,40/50] " Konrad Dybcio
2023-03-30 21:46 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 41/50] drm/msm/dpu: deduplicate sc8180x with sm8150 Dmitry Baryshkov
2023-03-30 12:55 ` [v2,41/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 42/50] drm/msm/dpu: deduplicate sm6115 with qcm2290 Dmitry Baryshkov
2023-03-30 12:56 ` [v2,42/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 43/50] drm/msm/dpu: deduplicate sc8280xp with sm8450 Dmitry Baryshkov
2023-03-30 12:59 ` [v2,43/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 44/50] drm/msm/dpu: drop unused macros from hw catalog Dmitry Baryshkov
2023-03-30 13:02 ` [v2,44/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 45/50] drm/msm/dpu: inline IRQ_n_MASK defines Dmitry Baryshkov
2023-03-30 13:08 ` [v2,45/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 46/50] drm/msm/dpu: rename INTF_foo_MASK to contain major DPU version Dmitry Baryshkov
2023-03-30 13:14 ` [v2,46/50] " Konrad Dybcio
2023-03-30 13:25 ` Dmitry Baryshkov
2023-02-11 23:12 ` [PATCH v2 47/50] drm/msm/dpu: rename CTL_foo_MASK " Dmitry Baryshkov
2023-03-30 13:15 ` [v2,47/50] " Konrad Dybcio
2023-03-30 13:16 ` Konrad Dybcio
2023-03-30 13:26 ` Dmitry Baryshkov
2023-03-30 13:27 ` Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 48/50] drm/msm/dpu: rename VIG and DMA_foo_MASK " Dmitry Baryshkov
2023-03-30 13:24 ` [v2,48/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 49/50] drm/msm/dpu: rename MIXER_foo_MASK " Dmitry Baryshkov
2023-03-30 13:25 ` [v2,49/50] " Konrad Dybcio
2023-02-11 23:12 ` [PATCH v2 50/50] drm/msm/dpu: rename MERGE_3D_foo_MASK " Dmitry Baryshkov
2023-03-30 13:26 ` [v2,50/50] " Konrad Dybcio
2023-03-07 18:02 ` [PATCH v2 00/50] drm/msm/dpu: rework HW catalog Dmitry Baryshkov
2023-03-07 18:20 ` [Freedreno] " Abhinav Kumar
2023-03-16 2:28 ` (subset) " Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72ec4076-3d7b-0deb-7691-eaa6e66ee354@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox