* [PATCH] spmi: pmic-arb: add missing newline in dev_err format strings
@ 2024-07-03 22:12 David Collins
2024-07-04 2:25 ` Bjorn Andersson
2024-07-18 21:02 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: David Collins @ 2024-07-03 22:12 UTC (permalink / raw)
To: Stephen Boyd, linux-kernel
Cc: David Collins, linux-arm-msm, Abel Vesa, Dan Carpenter,
Neil Armstrong
dev_err() format strings should end with '\n'. Several such
format strings in the spmi-pmic-arb driver are missing it.
Add newlines where needed.
Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter")
Signed-off-by: David Collins <quic_collinsd@quicinc.com>
---
drivers/spmi/spmi-pmic-arb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 791cdc160c51..c408ded0c00f 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, u8 sid,
*offset = rc;
if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
- dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
+ dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
PMIC_ARB_MAX_TRANS_BYTES, len);
return -EINVAL;
}
@@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_bus *bus, u8 opc,
*offset = rc;
if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
- dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
+ dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
PMIC_ARB_MAX_TRANS_BYTES, len);
return -EINVAL;
}
@@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
index = of_property_match_string(node, "reg-names", "cnfg");
if (index < 0) {
- dev_err(dev, "cnfg reg region missing");
+ dev_err(dev, "cnfg reg region missing\n");
return -EINVAL;
}
@@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
index = of_property_match_string(node, "reg-names", "intr");
if (index < 0) {
- dev_err(dev, "intr reg region missing");
+ dev_err(dev, "intr reg region missing\n");
return -EINVAL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] spmi: pmic-arb: add missing newline in dev_err format strings
2024-07-03 22:12 [PATCH] spmi: pmic-arb: add missing newline in dev_err format strings David Collins
@ 2024-07-04 2:25 ` Bjorn Andersson
2024-07-18 21:02 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-07-04 2:25 UTC (permalink / raw)
To: David Collins
Cc: Stephen Boyd, linux-kernel, linux-arm-msm, Abel Vesa,
Dan Carpenter, Neil Armstrong
On Wed, Jul 03, 2024 at 03:12:48PM GMT, David Collins wrote:
> dev_err() format strings should end with '\n'. Several such
> format strings in the spmi-pmic-arb driver are missing it.
> Add newlines where needed.
>
> Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter")
> Signed-off-by: David Collins <quic_collinsd@quicinc.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> drivers/spmi/spmi-pmic-arb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 791cdc160c51..c408ded0c00f 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, u8 sid,
>
> *offset = rc;
> if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
> - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
> + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
> PMIC_ARB_MAX_TRANS_BYTES, len);
> return -EINVAL;
> }
> @@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_bus *bus, u8 opc,
>
> *offset = rc;
> if (bc >= PMIC_ARB_MAX_TRANS_BYTES) {
> - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested",
> + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n",
> PMIC_ARB_MAX_TRANS_BYTES, len);
> return -EINVAL;
> }
> @@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
>
> index = of_property_match_string(node, "reg-names", "cnfg");
> if (index < 0) {
> - dev_err(dev, "cnfg reg region missing");
> + dev_err(dev, "cnfg reg region missing\n");
> return -EINVAL;
> }
>
> @@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
>
> index = of_property_match_string(node, "reg-names", "intr");
> if (index < 0) {
> - dev_err(dev, "intr reg region missing");
> + dev_err(dev, "intr reg region missing\n");
> return -EINVAL;
> }
>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] spmi: pmic-arb: add missing newline in dev_err format strings
2024-07-03 22:12 [PATCH] spmi: pmic-arb: add missing newline in dev_err format strings David Collins
2024-07-04 2:25 ` Bjorn Andersson
@ 2024-07-18 21:02 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2024-07-18 21:02 UTC (permalink / raw)
To: David Collins, linux-kernel
Cc: David Collins, linux-arm-msm, Abel Vesa, Dan Carpenter,
Neil Armstrong
Quoting David Collins (2024-07-03 15:12:48)
> dev_err() format strings should end with '\n'. Several such
> format strings in the spmi-pmic-arb driver are missing it.
> Add newlines where needed.
>
> Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter")
> Signed-off-by: David Collins <quic_collinsd@quicinc.com>
> ---
Applied to spmi-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-18 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-03 22:12 [PATCH] spmi: pmic-arb: add missing newline in dev_err format strings David Collins
2024-07-04 2:25 ` Bjorn Andersson
2024-07-18 21:02 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox