* [PATCH v6 2/5] drm: add constant N value in helper file
@ 2020-06-09 3:40 Tanmay Shah
2020-06-10 2:20 ` Stephen Boyd
2020-06-11 9:25 ` Jani Nikula
0 siblings, 2 replies; 5+ messages in thread
From: Tanmay Shah @ 2020-06-09 3:40 UTC (permalink / raw)
To: linux-arm-msm, dri-devel
Cc: swboyd, sam, seanpaul, freedreno, chandanu, robdclark, abhinavk,
nganji, linux-clk, Vara Reddy, Tanmay Shah
From: Chandan Uddaraju <chandanu@codeaurora.org>
The constant N value (0x8000) is used by i915 DP
driver. Define this value in dp helper header file
to use in multiple Display Port drivers. Change
i915 driver accordingly.
Change in v6: Change commit message
Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
Signed-off-by: Vara Reddy <varar@codeaurora.org>
Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
include/drm/drm_dp_helper.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 9ea1a39..4b2cfff 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8085,7 +8085,7 @@ static void compute_m_n(unsigned int m, unsigned int n,
* which the devices expect also in synchronous clock mode.
*/
if (constant_n)
- *ret_n = 0x8000;
+ *ret_n = DP_LINK_CONSTANT_N_VALUE;
else
*ret_n = min_t(unsigned int, roundup_pow_of_two(n), DATA_LINK_N_MAX);
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2035ac4..589132a 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1134,6 +1134,7 @@
#define DP_MST_PHYSICAL_PORT_0 0
#define DP_MST_LOGICAL_PORT_0 8
+#define DP_LINK_CONSTANT_N_VALUE 0x8000
#define DP_LINK_STATUS_SIZE 6
bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
int lane_count);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v6 2/5] drm: add constant N value in helper file
2020-06-09 3:40 [PATCH v6 2/5] drm: add constant N value in helper file Tanmay Shah
@ 2020-06-10 2:20 ` Stephen Boyd
2020-06-11 20:07 ` tanmay
2020-06-11 9:25 ` Jani Nikula
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2020-06-10 2:20 UTC (permalink / raw)
To: Tanmay Shah, dri-devel, linux-arm-msm
Cc: sam, seanpaul, freedreno, chandanu, robdclark, abhinavk, nganji,
linux-clk, Vara Reddy, Tanmay Shah
Quoting Tanmay Shah (2020-06-08 20:40:47)
> From: Chandan Uddaraju <chandanu@codeaurora.org>
>
> The constant N value (0x8000) is used by i915 DP
> driver. Define this value in dp helper header file
> to use in multiple Display Port drivers. Change
> i915 driver accordingly.
>
> Change in v6: Change commit message
>
> Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
> Signed-off-by: Vara Reddy <varar@codeaurora.org>
> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Can you resend this series as an actual patch series? None of the
patches have the proper In-Reply-To headers so it is hard to track the
thread.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 2/5] drm: add constant N value in helper file
2020-06-10 2:20 ` Stephen Boyd
@ 2020-06-11 20:07 ` tanmay
0 siblings, 0 replies; 5+ messages in thread
From: tanmay @ 2020-06-11 20:07 UTC (permalink / raw)
To: Stephen Boyd
Cc: dri-devel, linux-arm-msm, sam, seanpaul, freedreno, chandanu,
robdclark, abhinavk, nganji, linux-clk, Vara Reddy
On 2020-06-09 19:20, Stephen Boyd wrote:
> Quoting Tanmay Shah (2020-06-08 20:40:47)
>> From: Chandan Uddaraju <chandanu@codeaurora.org>
>>
>> The constant N value (0x8000) is used by i915 DP
>> driver. Define this value in dp helper header file
>> to use in multiple Display Port drivers. Change
>> i915 driver accordingly.
>>
>> Change in v6: Change commit message
>>
>> Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
>> Signed-off-by: Vara Reddy <varar@codeaurora.org>
>> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
>> ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> Can you resend this series as an actual patch series? None of the
> patches have the proper In-Reply-To headers so it is hard to track the
> thread.
Sure. Should I keep Message-ID of v5-patch-1 for in-reply-to header?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 2/5] drm: add constant N value in helper file
2020-06-09 3:40 [PATCH v6 2/5] drm: add constant N value in helper file Tanmay Shah
2020-06-10 2:20 ` Stephen Boyd
@ 2020-06-11 9:25 ` Jani Nikula
1 sibling, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2020-06-11 9:25 UTC (permalink / raw)
To: Tanmay Shah, linux-arm-msm, dri-devel
Cc: sam, abhinavk, swboyd, seanpaul, Tanmay Shah, Vara Reddy,
freedreno, linux-clk, chandanu
On Mon, 08 Jun 2020, Tanmay Shah <tanmay@codeaurora.org> wrote:
> From: Chandan Uddaraju <chandanu@codeaurora.org>
>
> The constant N value (0x8000) is used by i915 DP
> driver. Define this value in dp helper header file
> to use in multiple Display Port drivers. Change
> i915 driver accordingly.
>
> Change in v6: Change commit message
>
> Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
> Signed-off-by: Vara Reddy <varar@codeaurora.org>
> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
for merging via drm-misc if that helps you.
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> include/drm/drm_dp_helper.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 9ea1a39..4b2cfff 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8085,7 +8085,7 @@ static void compute_m_n(unsigned int m, unsigned int n,
> * which the devices expect also in synchronous clock mode.
> */
> if (constant_n)
> - *ret_n = 0x8000;
> + *ret_n = DP_LINK_CONSTANT_N_VALUE;
> else
> *ret_n = min_t(unsigned int, roundup_pow_of_two(n), DATA_LINK_N_MAX);
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2035ac4..589132a 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1134,6 +1134,7 @@
> #define DP_MST_PHYSICAL_PORT_0 0
> #define DP_MST_LOGICAL_PORT_0 8
>
> +#define DP_LINK_CONSTANT_N_VALUE 0x8000
> #define DP_LINK_STATUS_SIZE 6
> bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
> int lane_count);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v6 0/5] Add support for DisplayPort driver on
@ 2020-06-12 1:50 Tanmay Shah
2020-06-12 1:50 ` [PATCH v6 2/5] drm: add constant N value in helper file Tanmay Shah
0 siblings, 1 reply; 5+ messages in thread
From: Tanmay Shah @ 2020-06-12 1:50 UTC (permalink / raw)
To: sam, robh+dt, swboyd
Cc: devicetree, linux-kernel, linux-arm-msm, dri-devel, freedreno,
seanpaul, robdclark, aravindh, abhinavk, Tanmay Shah
These patches add support for Display-Port driver on SnapDragon
hardware. It adds
DP driver and DP PLL driver files along with the needed device-tree
bindings.
The block diagram of DP driver is shown below:
+-------------+
|DRM FRAMEWORK|
+------+------+
|
+----v----+
| DP DRM |
+----+----+
|
+----v----+
+------------+| DP +----------++------+
+ +---+| DISPLAY |+---+ | |
| + +-+-----+-+ | | |
| | | | | | |
| | | | | | |
| | | | | | |
v v v v v v v
+------+ +------+ +---+ +----+ +----+ +---+ +-----+
| DP | | DP | |DP | | DP | | DP | |DP | | DP |
|PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER|
+--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+
| | |
+--v---+ +v-----v+
|DEVICE| | DP |
| TREE | |CATALOG|
+------+ +---+---+
|
+---v----+
|CTRL/PHY|
| HW |
+--------+
These patches have dependency on clock driver changes mentioned below:
https://patchwork.kernel.org/patch/11245895/
https://patchwork.kernel.org/cover/11069083/
Chandan Uddaraju (4):
dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon
drm: add constant N value in helper file
drm/msm/dp: add displayPort driver support
drm/msm/dp: add support for DP PLL driver
Jeykumar Sankaran (1):
drm/msm/dpu: add display port support in DPU
.../bindings/display/msm/dp-sc7180.yaml | 142 ++
.../devicetree/bindings/display/msm/dpu.txt | 8 +
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
drivers/gpu/drm/msm/Kconfig | 21 +
drivers/gpu/drm/msm/Makefile | 15 +
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 29 +-
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 +
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 +-
drivers/gpu/drm/msm/dp/dp_aux.c | 530 +++++
drivers/gpu/drm/msm/dp/dp_aux.h | 35 +
drivers/gpu/drm/msm/dp/dp_catalog.c | 1025 ++++++++++
drivers/gpu/drm/msm/dp/dp_catalog.h | 86 +
drivers/gpu/drm/msm/dp/dp_ctrl.c | 1709 +++++++++++++++++
drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 +
drivers/gpu/drm/msm/dp/dp_display.c | 912 +++++++++
drivers/gpu/drm/msm/dp/dp_display.h | 31 +
drivers/gpu/drm/msm/dp/dp_drm.c | 170 ++
drivers/gpu/drm/msm/dp/dp_drm.h | 18 +
drivers/gpu/drm/msm/dp/dp_hpd.c | 69 +
drivers/gpu/drm/msm/dp/dp_hpd.h | 79 +
drivers/gpu/drm/msm/dp/dp_link.c | 1216 ++++++++++++
drivers/gpu/drm/msm/dp/dp_link.h | 132 ++
drivers/gpu/drm/msm/dp/dp_panel.c | 490 +++++
drivers/gpu/drm/msm/dp/dp_panel.h | 95 +
drivers/gpu/drm/msm/dp/dp_parser.c | 390 ++++
drivers/gpu/drm/msm/dp/dp_parser.h | 204 ++
drivers/gpu/drm/msm/dp/dp_pll.c | 93 +
drivers/gpu/drm/msm/dp/dp_pll.h | 59 +
drivers/gpu/drm/msm/dp/dp_pll_10nm.c | 903 +++++++++
drivers/gpu/drm/msm/dp/dp_pll_private.h | 103 +
drivers/gpu/drm/msm/dp/dp_power.c | 422 ++++
drivers/gpu/drm/msm/dp/dp_power.h | 115 ++
drivers/gpu/drm/msm/dp/dp_reg.h | 505 +++++
drivers/gpu/drm/msm/msm_drv.c | 2 +
drivers/gpu/drm/msm/msm_drv.h | 53 +-
include/drm/drm_dp_helper.h | 1 +
36 files changed, 9753 insertions(+), 19 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml
create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_10nm.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_private.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c
create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h
create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h
base-commit: 48f99181fc118d82dc8bf6c7221ad1c654cb8bc2
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v6 2/5] drm: add constant N value in helper file
2020-06-12 1:50 [PATCH v6 0/5] Add support for DisplayPort driver on Tanmay Shah
@ 2020-06-12 1:50 ` Tanmay Shah
0 siblings, 0 replies; 5+ messages in thread
From: Tanmay Shah @ 2020-06-12 1:50 UTC (permalink / raw)
To: sam, robh+dt, swboyd
Cc: devicetree, linux-kernel, linux-arm-msm, dri-devel, freedreno,
seanpaul, robdclark, aravindh, abhinavk, Chandan Uddaraju,
Vara Reddy, Tanmay Shah, Jani Nikula
From: Chandan Uddaraju <chandanu@codeaurora.org>
The constant N value (0x8000) is used by i915 DP
driver. Define this value in dp helper header file
to use in multiple Display Port drivers. Change
i915 driver accordingly.
Change in v6: Change commit message
Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
Signed-off-by: Vara Reddy <varar@codeaurora.org>
Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
include/drm/drm_dp_helper.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 9ea1a397d1b5..4b2cfff5b761 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8085,7 +8085,7 @@ static void compute_m_n(unsigned int m, unsigned int n,
* which the devices expect also in synchronous clock mode.
*/
if (constant_n)
- *ret_n = 0x8000;
+ *ret_n = DP_LINK_CONSTANT_N_VALUE;
else
*ret_n = min_t(unsigned int, roundup_pow_of_two(n), DATA_LINK_N_MAX);
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2035ac44afde..589132ab9ab6 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1134,6 +1134,7 @@
#define DP_MST_PHYSICAL_PORT_0 0
#define DP_MST_LOGICAL_PORT_0 8
+#define DP_LINK_CONSTANT_N_VALUE 0x8000
#define DP_LINK_STATUS_SIZE 6
bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE],
int lane_count);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-12 1:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-09 3:40 [PATCH v6 2/5] drm: add constant N value in helper file Tanmay Shah
2020-06-10 2:20 ` Stephen Boyd
2020-06-11 20:07 ` tanmay
2020-06-11 9:25 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2020-06-12 1:50 [PATCH v6 0/5] Add support for DisplayPort driver on Tanmay Shah
2020-06-12 1:50 ` [PATCH v6 2/5] drm: add constant N value in helper file Tanmay Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox