From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc: marijn.suijten@somainline.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 4/8] clk: qcom: Add GPU clock controller driver for SM6125
Date: Tue, 31 Jan 2023 13:37:59 +0100 [thread overview]
Message-ID: <8e11a80c-8056-e226-e051-c01b82f29d05@linaro.org> (raw)
In-Reply-To: <ac2d458c-3cb9-9117-82ca-b025b92073df@linaro.org>
On 31.01.2023 10:00, Dmitry Baryshkov wrote:
> On 31/01/2023 01:59, Konrad Dybcio wrote:
>> Add support for the GPU clock controller found on SM6125.
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
[...]
>> + /* Set recommended WAKEUP/SLEEP settings for the gpu_cc_cx_gmu_clk */
>> + regmap_update_bits(regmap, gpu_cc_cx_gmu_clk.clkr.enable_reg, CBCR_WAKEUP, 0xf);
>> + regmap_update_bits(regmap, gpu_cc_cx_gmu_clk.clkr.enable_reg, CBCR_SLEEP, 0xf);
>
> I think you have to use FIELD_PREP here. regmap_update_bits doesn't shift the value according to the mask, does it?
>
You're right.
Konrad
>> +
>> + qcom_branch_set_force_mem_core(regmap, gpu_cc_gx_gfx3d_clk.halt_reg, true);
>> + qcom_branch_set_force_periph_on(regmap, gpu_cc_gx_gfx3d_clk.halt_reg, true);
>> +
>> + return qcom_cc_really_probe(pdev, &gpu_cc_sm6125_desc, regmap);
>> +}
>> +
>> +static struct platform_driver gpu_cc_sm6125_driver = {
>> + .probe = gpu_cc_sm6125_probe,
>> + .driver = {
>> + .name = "gpucc-sm6125",
>> + .of_match_table = gpu_cc_sm6125_match_table,
>> + },
>> +};
>> +module_platform_driver(gpu_cc_sm6125_driver);
>> +
>> +MODULE_DESCRIPTION("QTI GPUCC SM6125 Driver");
>> +MODULE_LICENSE("GPL");
>
next prev parent reply other threads:[~2023-01-31 12:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 23:59 [PATCH v4 0/8] SM6(11|12|37)5 GPUCC Konrad Dybcio
2023-01-30 23:59 ` [PATCH v4 1/8] clk: qcom: branch: Add helper functions for setting retain bits Konrad Dybcio
2023-01-31 9:05 ` Dmitry Baryshkov
2023-01-30 23:59 ` [PATCH v4 2/8] clk: qcom: branch: Add SLEEP/WAKE fields definitions Konrad Dybcio
2023-01-31 9:07 ` Dmitry Baryshkov
2023-01-30 23:59 ` [PATCH v4 3/8] dt-bindings: clock: Add Qcom SM6125 GPUCC Konrad Dybcio
2023-01-30 23:59 ` [PATCH v4 4/8] clk: qcom: Add GPU clock controller driver for SM6125 Konrad Dybcio
2023-01-31 9:00 ` Dmitry Baryshkov
2023-01-31 12:37 ` Konrad Dybcio [this message]
2023-01-30 23:59 ` [PATCH v4 5/8] dt-bindings: clock: Add Qcom SM6375 GPUCC Konrad Dybcio
2023-01-30 23:59 ` [PATCH v4 6/8] clk: qcom: Add GPU clock controller driver for SM6375 Konrad Dybcio
2023-01-31 9:08 ` Dmitry Baryshkov
2023-01-30 23:59 ` [PATCH v4 7/8] dt-bindings: clock: Add Qcom SM6115 GPUCC Konrad Dybcio
2023-01-31 19:15 ` Krzysztof Kozlowski
2023-01-30 23:59 ` [PATCH v4 8/8] clk: qcom: Add GPU clock controller driver for SM6115 Konrad Dybcio
2023-01-31 9:25 ` Dmitry Baryshkov
2023-01-31 12:38 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e11a80c-8056-e226-e051-c01b82f29d05@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox