From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sc8280xp: Correct USB PHY power domains
Date: Fri, 29 Dec 2023 14:01:06 +0100 [thread overview]
Message-ID: <ZY7DEpaIgvfL_A11@hovoldconsulting.com> (raw)
In-Reply-To: <20231227-topic-8280_pcie_dts-v1-2-13d12b1698ff@linaro.org>
On Wed, Dec 27, 2023 at 11:28:27PM +0100, Konrad Dybcio wrote:
> The USB GDSCs are only related to the controllers.
Are you sure?
> The PHYs on the other
> hand, are powered by VDD_MX and their specific VDDA_PHY/PLL regulators.
>
> Fix the power-domains assignment to stop potentially toggling the GDSC
> unnecessarily.
Again, there's no additional toggling being done here, but yes, this may
keep the domains enabled during suspend depending on how the driver is
implemented.
If that's the concern, then please spell that out too.
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
May not be needed either.
> @@ -2597,7 +2597,7 @@ usb_2_qmpphy0: phy@88ef000 {
> <&gcc GCC_USB3UNIPHY_PHY_MP0_BCR>;
> reset-names = "phy", "phy_phy";
>
> - power-domains = <&gcc USB30_MP_GDSC>;
> + power-domains = <&rpmhpd SC8280XP_MX>;
Johan
next prev parent reply other threads:[~2023-12-29 13:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 22:28 [PATCH 0/3] SC8280XP preparatory PCIe fixes Konrad Dybcio
2023-12-27 22:28 ` [PATCH 1/3] arm64: dts: qcom: sc8280xp: Fix PCIe PHY power-domains Konrad Dybcio
2023-12-29 11:24 ` Johan Hovold
2023-12-29 13:08 ` Konrad Dybcio
2023-12-29 13:20 ` Johan Hovold
2023-12-29 17:03 ` Manivannan Sadhasivam
2023-12-30 12:28 ` Konrad Dybcio
2024-01-02 9:05 ` Johan Hovold
2024-01-22 17:25 ` Manivannan Sadhasivam
2024-01-22 17:36 ` Johan Hovold
2024-01-23 17:06 ` Manivannan Sadhasivam
2024-01-23 18:41 ` Konrad Dybcio
2024-01-24 7:31 ` Johan Hovold
2023-12-27 22:28 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp: Correct USB PHY power domains Konrad Dybcio
2023-12-29 13:01 ` Johan Hovold [this message]
2023-12-29 13:06 ` Konrad Dybcio
2023-12-29 13:25 ` Johan Hovold
2023-12-29 15:05 ` Konrad Dybcio
2023-12-29 15:43 ` Johan Hovold
2023-12-29 17:10 ` Manivannan Sadhasivam
2024-01-02 8:55 ` Johan Hovold
2023-12-27 22:28 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: Add PCIe CLKREQ# sleep state Konrad Dybcio
2023-12-29 12:55 ` Johan Hovold
2023-12-30 14:11 ` Konrad Dybcio
2023-12-29 17:14 ` Manivannan Sadhasivam
2023-12-30 14:10 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZY7DEpaIgvfL_A11@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox