From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sc8280xp: Correct USB PHY power domains
Date: Fri, 29 Dec 2023 14:25:41 +0100 [thread overview]
Message-ID: <ZY7I1brn0chtOzis@hovoldconsulting.com> (raw)
In-Reply-To: <b730bf22-fa3a-4720-9fd1-79d2207d6812@linaro.org>
[ Please remember to trim your replies and add a newline before your
inline comments to make them readable. ]
On Fri, Dec 29, 2023 at 02:06:26PM +0100, Konrad Dybcio wrote:
> On 29.12.2023 14:01, Johan Hovold wrote:
> > On Wed, Dec 27, 2023 at 11:28:27PM +0100, Konrad Dybcio wrote:
> >> Fix the power-domains assignment to stop potentially toggling the GDSC
> >> unnecessarily.
> >
> > Again, there's no additional toggling being done here, but yes, this may
> > keep the domains enabled during suspend depending on how the driver is
> > implemented.
> No, it can actually happen. (Some) QMP PHYs are referenced by the
> DP hardware. If USB is disabled (or suspended), the DP being active
> will hold these GDSCs enabled.
That's not a "toggling", is it? Also if the DP controller is a consumer of
these PHY's why should it not prevent the PHYs from suspending?
Johan
next prev parent reply other threads:[~2023-12-29 13:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 22:28 [PATCH 0/3] SC8280XP preparatory PCIe fixes Konrad Dybcio
2023-12-27 22:28 ` [PATCH 1/3] arm64: dts: qcom: sc8280xp: Fix PCIe PHY power-domains Konrad Dybcio
2023-12-29 11:24 ` Johan Hovold
2023-12-29 13:08 ` Konrad Dybcio
2023-12-29 13:20 ` Johan Hovold
2023-12-29 17:03 ` Manivannan Sadhasivam
2023-12-30 12:28 ` Konrad Dybcio
2024-01-02 9:05 ` Johan Hovold
2024-01-22 17:25 ` Manivannan Sadhasivam
2024-01-22 17:36 ` Johan Hovold
2024-01-23 17:06 ` Manivannan Sadhasivam
2024-01-23 18:41 ` Konrad Dybcio
2024-01-24 7:31 ` Johan Hovold
2023-12-27 22:28 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp: Correct USB PHY power domains Konrad Dybcio
2023-12-29 13:01 ` Johan Hovold
2023-12-29 13:06 ` Konrad Dybcio
2023-12-29 13:25 ` Johan Hovold [this message]
2023-12-29 15:05 ` Konrad Dybcio
2023-12-29 15:43 ` Johan Hovold
2023-12-29 17:10 ` Manivannan Sadhasivam
2024-01-02 8:55 ` Johan Hovold
2023-12-27 22:28 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: Add PCIe CLKREQ# sleep state Konrad Dybcio
2023-12-29 12:55 ` Johan Hovold
2023-12-30 14:11 ` Konrad Dybcio
2023-12-29 17:14 ` Manivannan Sadhasivam
2023-12-30 14:10 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZY7I1brn0chtOzis@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox