From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sc8280xp: Fix PCIe PHY power-domains
Date: Wed, 24 Jan 2024 08:31:57 +0100 [thread overview]
Message-ID: <ZbC87YiI4Sg8eEbb@hovoldconsulting.com> (raw)
In-Reply-To: <20240123170614.GH19029@thinkpad>
On Tue, Jan 23, 2024 at 10:36:14PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Jan 22, 2024 at 06:36:51PM +0100, Johan Hovold wrote:
> Ok. I tested by enabling the PHY clocks during qmp_pcie_clk_init() without
> PCIE_GDSC. It worked for one instance of the PHY which doesn't have
> PCIE_PHY_AUX_CLK, but for the PHY instance with this clock, I saw the same "clk
> stuck" issue. Then checking the internal documentation revealed that this clock
> needs PCIE_GDSC to become functional >.<
>
> So to conclude, PCIE_AUX_CLK belongs to the controller and it needs GDSC. And
> PCIE_PHY_AUX_CLK belongs to the PHY and it also needs GDSC.
>
> I will just submit a series to remove the PCIE_AUX_CLK from PHY nodes. Then
> in another series, I'll remove the GDSC for PHY instances that do not require
> PCIE_PHY_AUX_CLK.
Sounds good, thanks.
Johan
next prev parent reply other threads:[~2024-01-24 7:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 22:28 [PATCH 0/3] SC8280XP preparatory PCIe fixes Konrad Dybcio
2023-12-27 22:28 ` [PATCH 1/3] arm64: dts: qcom: sc8280xp: Fix PCIe PHY power-domains Konrad Dybcio
2023-12-29 11:24 ` Johan Hovold
2023-12-29 13:08 ` Konrad Dybcio
2023-12-29 13:20 ` Johan Hovold
2023-12-29 17:03 ` Manivannan Sadhasivam
2023-12-30 12:28 ` Konrad Dybcio
2024-01-02 9:05 ` Johan Hovold
2024-01-22 17:25 ` Manivannan Sadhasivam
2024-01-22 17:36 ` Johan Hovold
2024-01-23 17:06 ` Manivannan Sadhasivam
2024-01-23 18:41 ` Konrad Dybcio
2024-01-24 7:31 ` Johan Hovold [this message]
2023-12-27 22:28 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp: Correct USB PHY power domains Konrad Dybcio
2023-12-29 13:01 ` Johan Hovold
2023-12-29 13:06 ` Konrad Dybcio
2023-12-29 13:25 ` Johan Hovold
2023-12-29 15:05 ` Konrad Dybcio
2023-12-29 15:43 ` Johan Hovold
2023-12-29 17:10 ` Manivannan Sadhasivam
2024-01-02 8:55 ` Johan Hovold
2023-12-27 22:28 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: Add PCIe CLKREQ# sleep state Konrad Dybcio
2023-12-29 12:55 ` Johan Hovold
2023-12-30 14:11 ` Konrad Dybcio
2023-12-29 17:14 ` Manivannan Sadhasivam
2023-12-30 14:10 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbC87YiI4Sg8eEbb@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox