[PATCH 0/2] qdu1000: Fix LLCC reg property

[PATCH 0/2] qdu1000: Fix LLCC reg property

[Komal Bajaj]

The LLCC binding and driver was corrected to handle the stride
varying between platforms. Switch to the new format to obtain
the base address of each LLCC bank from devicetree.

Komal Bajaj (2):
  arm64: dts: qcom: qdu1000: Fix LLCC reg property
  dt-bindings: cache: qcom,llcc: Fix QDU1000 description

 .../devicetree/bindings/cache/qcom,llcc.yaml     |  2 +-
 arch/arm64/boot/dts/qcom/qdu1000.dtsi            | 16 +++++++++++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

--
2.42.0

[PATCH 1/2] arm64: dts: qcom: qdu1000: Fix LLCC reg property

[Komal Bajaj]

The LLCC binding and driver was corrected to handle the stride
varying between platforms. Switch to the new format to ensure
accesses are done in the right place.

Fixes: b0e0290bc47d ("arm64: dts: qcom: qdu1000: correct LLCC reg entries")
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qdu1000.dtsi | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
index 7a77f7a55498..3795ebb2d3d6 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
+++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
@@ -1579,9 +1579,23 @@ gem_noc: interconnect@19100000 {

 		system-cache-controller@19200000 {
 			compatible = "qcom,qdu1000-llcc";
-			reg = <0 0x19200000 0 0xd80000>,
+			reg = <0 0x19200000 0 0x80000>,
+			      <0 0x19300000 0 0x80000>,
+			      <0 0x19600000 0 0x80000>,
+			      <0 0x19700000 0 0x80000>,
+			      <0 0x19a00000 0 0x80000>,
+			      <0 0x19b00000 0 0x80000>,
+			      <0 0x19e00000 0 0x80000>,
+			      <0 0x19f00000 0 0x80000>,
 			      <0 0x1a200000 0 0x80000>;
 			reg-names = "llcc0_base",
+				    "llcc1_base",
+				    "llcc2_base",
+				    "llcc3_base",
+				    "llcc4_base",
+				    "llcc5_base",
+				    "llcc6_base",
+				    "llcc7_base",
 				    "llcc_broadcast_base";
 			interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
 		};
--
2.42.0

Re: [PATCH 1/2] arm64: dts: qcom: qdu1000: Fix LLCC reg property

[Mukesh Ojha]

On Wed, Jun 12, 2024 at 11:57:18AM +0530, Komal Bajaj wrote:
> The LLCC binding and driver was corrected to handle the stride
> varying between platforms. Switch to the new format to ensure
> accesses are done in the right place.
> 
> Fixes: b0e0290bc47d ("arm64: dts: qcom: qdu1000: correct LLCC reg entries")
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>

Looks good to me.

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

[PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000 description

[Komal Bajaj]

QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
dt-bindings accordingly.

Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
 Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
index 192911696010..68ea5f70b75f 100644
--- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
@@ -67,7 +67,6 @@ allOf:
         compatible:
           contains:
             enum:
-              - qcom,qdu1000-llcc
               - qcom,sc7180-llcc
               - qcom,sm6350-llcc
     then:
@@ -132,6 +131,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,qdu1000-llcc
               - qcom,sc8180x-llcc
               - qcom,sc8280xp-llcc
               - qcom,x1e80100-llcc
--
2.42.0

Re: [PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000 description

[Krzysztof Kozlowski]

On 12/06/2024 08:27, Komal Bajaj wrote:
> QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
> dt-bindings accordingly.
> 
> Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")

You are basically reverting without saying this is a revert and without
explanation.

What's happening with QDU1000? Why it is such a mess that DTS was
totally not matching bindings drivers and now suddenly we need to revert
commits?

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: cache: qcom,llcc: Fix QDU1000 description

[Mukesh Ojha]

On Wed, Jun 12, 2024 at 09:58:50AM +0200, Krzysztof Kozlowski wrote:
> On 12/06/2024 08:27, Komal Bajaj wrote:
> > QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
> > dt-bindings accordingly.
> > 
> > Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
> 
> You are basically reverting without saying this is a revert and without
> explanation.
> 
> What's happening with QDU1000? Why it is such a mess that DTS was
> totally not matching bindings drivers and now suddenly we need to revert
> commits?

I think, this happened because of the refactoring happened in LLCC driver
and at the same time QDU1000 device tree change picked while other SoCs
change was made like 

e.g
https://lore.kernel.org/r/20230314080443.64635-11-manivannan.sadhasivam@linaro.org
https://lore.kernel.org/r/20230517-topic-kailua-llcc-v1-2-d57bd860c43e@linaro.org


However, this change missed for QDU1000, later f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
happened and now realized the driver does not work anymore with current
binding and hence fixing was required.

-Mukesh