[PATCH 0/3] arm64: dts: qcom: x1e80100: Fix missing address/size cells warnings

[PATCH 0/3] arm64: dts: qcom: x1e80100: Fix missing address/size cells warnings

[Abel Vesa]

The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
handling") now forces all parent nodes to describe the #adress-cells
and #size-cells, otherwise it will throw a warning.

Note that this patch is currently only in -next.

Fix all warnings on the X Elite by adding these two properties to all
parent nodes that don't have them.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (3):
      arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to firmware node
      arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to ADSP GPR nodes
      arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon

 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi |  3 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi       | 10 ++++++++++
 2 files changed, 13 insertions(+)
---
base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a
change-id: 20241108-x1e80100-fix-address-size-cells-missing-warnings-1cfba11bfdbd

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

[PATCH 1/3] arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to firmware node

[Abel Vesa]

The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
handling") now forces the parent nodes to specify #adddress-cells
and #size-cells, otherwise it will throw a warning.

So add the #address-cells and #size-cells properties to the firmware node
to get rid of those warnings.

Cc: <stable+noautosel@kernel.org> # Depends on commit 4b28a0dec185
Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 88805629ed2bf052ea6ec152794066217489cf52..c6b554bac616b9ea6a183e894d4e3d58516fbcd7 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -304,6 +304,9 @@ cluster_cl5: cluster-sleep-1 {
 	};
 
 	firmware {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
 		scm: scm {
 			compatible = "qcom,scm-x1e80100", "qcom,scm";
 			interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS
@@ -5804,6 +5807,9 @@ apps_rsc: rsc@17500000 {
 			label = "apps_rsc";
 			power-domains = <&system_pd>;
 
+			#address-cells = <1>;
+			#size-cells = <0>;
+
 			apps_bcm_voter: bcm-voter {
 				compatible = "qcom,bcm-voter";
 			};

-- 
2.34.1

[PATCH 2/3] arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to ADSP GPR nodes

[Abel Vesa]

The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
handling") now forces the parent nodes to specify #adddress-cells
and #size-cells, otherwise it will throw a warning.

So add the #address-cells and #size-cells properties to the ADSP GPR nodes
(q6apm and q6prm) to get rid of those warnings.

Cc: <stable+noautosel@kernel.org> # Depends on commit 4b28a0dec185
Fixes: 99f63aea9149 ("arm64: dts: qcom: x1e80100: add ADSP GPR")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index c6b554bac616b9ea6a183e894d4e3d58516fbcd7..568f9a295e497533344ba47ed1e4ae7aa3d2ab16 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -6232,6 +6232,8 @@ q6apm: service@1 {
 						#sound-dai-cells = <0>;
 						qcom,protection-domain = "avs/audio",
 									 "msm/adsp/audio_pd";
+						#address-cells = <1>;
+						#size-cells = <0>;
 
 						q6apmbedai: bedais {
 							compatible = "qcom,q6apm-lpass-dais";
@@ -6250,6 +6252,8 @@ q6prm: service@2 {
 						reg = <GPR_PRM_MODULE_IID>;
 						qcom,protection-domain = "avs/audio",
 									 "msm/adsp/audio_pd";
+						#address-cells = <1>;
+						#size-cells = <0>;
 
 						q6prmcc: clock-controller {
 							compatible = "qcom,q6prm-lpass-clocks";

-- 
2.34.1

[PATCH 3/3] arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon

[Abel Vesa]

The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
handling") now forces the parent nodes to specify #adddress-cells
and #size-cells, otherwise it will throw a warning.

So add the #address-cells and #size-cells properties to the pmk8550_pon node
to get rid of those warnings.

Cc: <stable+noautosel@kernel.org> # Depends on commit 4b28a0dec185
Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
index 5b54ee79f048e3208cbcd6f91e0cec073420fe63..5b9d67c340dc7a4550c9c7f16269542e400e4ee4 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
@@ -205,6 +205,9 @@ pmk8550_pon: pon@1300 {
 			reg = <0x1300>, <0x800>;
 			reg-names = "hlos", "pbs";
 
+			#address-cells = <1>;
+			#size-cells = <0>;
+
 			pon_pwrkey: pwrkey {
 				compatible = "qcom,pmk8350-pwrkey";
 				interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;

-- 
2.34.1

Re: [PATCH 3/3] arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon

[Dmitry Baryshkov]

On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@linaro.org> wrote:
>
> The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
> handling") now forces the parent nodes to specify #adddress-cells
> and #size-cells, otherwise it will throw a warning.
>
> So add the #address-cells and #size-cells properties to the pmk8550_pon node
> to get rid of those warnings.
>
> Cc: <stable+noautosel@kernel.org> # Depends on commit 4b28a0dec185
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> index 5b54ee79f048e3208cbcd6f91e0cec073420fe63..5b9d67c340dc7a4550c9c7f16269542e400e4ee4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> @@ -205,6 +205,9 @@ pmk8550_pon: pon@1300 {
>                         reg = <0x1300>, <0x800>;
>                         reg-names = "hlos", "pbs";
>
> +                       #address-cells = <1>;

This is incorrect, nodes under pon don't have reg and don't use addressing.

> +                       #size-cells = <0>;
> +
>                         pon_pwrkey: pwrkey {
>                                 compatible = "qcom,pmk8350-pwrkey";
>                                 interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
>
> --
> 2.34.1
>


-- 
With best wishes
Dmitry

Re: [PATCH 0/3] arm64: dts: qcom: x1e80100: Fix missing address/size cells warnings

[Dmitry Baryshkov]

On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@linaro.org> wrote:
>
> The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
> handling") now forces all parent nodes to describe the #adress-cells
> and #size-cells, otherwise it will throw a warning.
>
> Note that this patch is currently only in -next.
>
> Fix all warnings on the X Elite by adding these two properties to all
> parent nodes that don't have them.

The individual patches are incorrect per my understanding. None of
those child nodes use addressing, so adding #address-cells = <1> is
incorrect. Maybe it should be #address-cells = <0>, but that looks a
bit ridiculous to me.

>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Abel Vesa (3):
>       arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to firmware node
>       arm64: dts: qcom: x1e80100: Add missing #address-cells/#size-cells to ADSP GPR nodes
>       arm64: dts: qcom: x1e80100-pmics: Add missing #address-cells/#size-cells to pmk8550_pon
>
>  arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi |  3 +++
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi       | 10 ++++++++++
>  2 files changed, 13 insertions(+)
> ---
> base-commit: 929beafbe7acce3267c06115e13e03ff6e50548a
> change-id: 20241108-x1e80100-fix-address-size-cells-missing-warnings-1cfba11bfdbd
>
> Best regards,
> --
> Abel Vesa <abel.vesa@linaro.org>
>


-- 
With best wishes
Dmitry

Re: [PATCH 0/3] arm64: dts: qcom: x1e80100: Fix missing address/size cells warnings

[Johan Hovold]

On Sat, Nov 09, 2024 at 12:49:16AM +0200, Dmitry Baryshkov wrote:
> On Sat, 9 Nov 2024 at 00:05, Abel Vesa <abel.vesa@linaro.org> wrote:
> >
> > The commit 4b28a0dec185 ("of: WARN on deprecated #address-cells/#size-cells
> > handling") now forces all parent nodes to describe the #adress-cells
> > and #size-cells, otherwise it will throw a warning.
> >
> > Note that this patch is currently only in -next.
> >
> > Fix all warnings on the X Elite by adding these two properties to all
> > parent nodes that don't have them.
> 
> The individual patches are incorrect per my understanding. None of
> those child nodes use addressing, so adding #address-cells = <1> is
> incorrect. Maybe it should be #address-cells = <0>, but that looks a
> bit ridiculous to me.

Yeah, the warnings are bogus. Rob merged a fix last night:

	https://lore.kernel.org/lkml/20241108193547.2647986-2-robh@kernel.org/

so this should be resolved in linux-next on Monday or so.

Johan