* [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
@ 2026-04-20 7:33 Shawn Guo
2026-04-20 8:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2026-04-20 7:33 UTC (permalink / raw)
To: Herbert Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Dmitry Baryshkov, Bartosz Golaszewski,
Deepti Jaggi, linux-crypto, devicetree, linux-arm-msm,
linux-kernel, Shawn Guo
Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
witha fallback on qcom,inline-crypto-engine.
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
.../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index 876bf90ed96e..9251db2b8fcd 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -16,6 +16,7 @@ properties:
- qcom,eliza-inline-crypto-engine
- qcom,kaanapali-inline-crypto-engine
- qcom,milos-inline-crypto-engine
+ - qcom,nord-inline-crypto-engine
- qcom,qcs8300-inline-crypto-engine
- qcom,sa8775p-inline-crypto-engine
- qcom,sc7180-inline-crypto-engine
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-04-20 7:33 [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
@ 2026-04-20 8:27 ` Krzysztof Kozlowski
2026-04-20 8:39 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-20 8:27 UTC (permalink / raw)
To: Shawn Guo, Herbert Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Dmitry Baryshkov, Bartosz Golaszewski,
Deepti Jaggi, linux-crypto, devicetree, linux-arm-msm,
linux-kernel
On 20/04/2026 09:33, Shawn Guo wrote:
> Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
> witha fallback on qcom,inline-crypto-engine.
Don't explain what the diff is doing. Explain why. Why do you use fallback?
What is Nord? It's nowhere explained. First posting was 1.5 months ago
and it did not provide any explanation. I don't see any information
being posted in the series sent now.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-04-20 8:27 ` Krzysztof Kozlowski
@ 2026-04-20 8:39 ` Shawn Guo
2026-04-20 11:56 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2026-04-20 8:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel
On Mon, Apr 20, 2026 at 10:27:56AM +0200, Krzysztof Kozlowski wrote:
> On 20/04/2026 09:33, Shawn Guo wrote:
> > Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
> > witha fallback on qcom,inline-crypto-engine.
>
> Don't explain what the diff is doing. Explain why. Why do you use fallback?
>
> What is Nord? It's nowhere explained. First posting was 1.5 months ago
> and it did not provide any explanation. I don't see any information
> being posted in the series sent now.
I'm still checking internally to see how we can get the best socinfo
patch describing Nord which is a SoC family covering both SA8997P and
IQ10 variant. Hopefully I will get it soon.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-04-20 8:39 ` Shawn Guo
@ 2026-04-20 11:56 ` Krzysztof Kozlowski
2026-04-20 12:57 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-20 11:56 UTC (permalink / raw)
To: Shawn Guo
Cc: Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel
On 20/04/2026 10:39, Shawn Guo wrote:
> On Mon, Apr 20, 2026 at 10:27:56AM +0200, Krzysztof Kozlowski wrote:
>> On 20/04/2026 09:33, Shawn Guo wrote:
>>> Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
>>> witha fallback on qcom,inline-crypto-engine.
>>
>> Don't explain what the diff is doing. Explain why. Why do you use fallback?
>>
>> What is Nord? It's nowhere explained. First posting was 1.5 months ago
>> and it did not provide any explanation. I don't see any information
>> being posted in the series sent now.
>
> I'm still checking internally to see how we can get the best socinfo
> patch describing Nord which is a SoC family covering both SA8997P and
> IQ10 variant. Hopefully I will get it soon.
I found the DTS on:
https://github.com/qualcomm-linux/kernel-topics/commits/early/hwe/nord/
so it should be mentioned somewhere, which I kind of asked when we
discussed about adding compatibles used by that DTS. You would solve
yourself all my questions from three threads.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-04-20 11:56 ` Krzysztof Kozlowski
@ 2026-04-20 12:57 ` Shawn Guo
2026-04-20 13:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2026-04-20 12:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel
On Mon, Apr 20, 2026 at 01:56:46PM +0200, Krzysztof Kozlowski wrote:
> On 20/04/2026 10:39, Shawn Guo wrote:
> > On Mon, Apr 20, 2026 at 10:27:56AM +0200, Krzysztof Kozlowski wrote:
> >> On 20/04/2026 09:33, Shawn Guo wrote:
> >>> Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
> >>> witha fallback on qcom,inline-crypto-engine.
> >>
> >> Don't explain what the diff is doing. Explain why. Why do you use fallback?
> >>
> >> What is Nord? It's nowhere explained. First posting was 1.5 months ago
> >> and it did not provide any explanation. I don't see any information
> >> being posted in the series sent now.
> >
> > I'm still checking internally to see how we can get the best socinfo
> > patch describing Nord which is a SoC family covering both SA8997P and
> > IQ10 variant. Hopefully I will get it soon.
>
> I found the DTS on:
> https://github.com/qualcomm-linux/kernel-topics/commits/early/hwe/nord/
> so it should be mentioned somewhere, which I kind of asked when we
> discussed about adding compatibles used by that DTS. You would solve
> yourself all my questions from three threads.
Ah, I see. I thought only patches posted to list count.
Thanks!
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-04-20 12:57 ` Shawn Guo
@ 2026-04-20 13:47 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-20 13:47 UTC (permalink / raw)
To: Shawn Guo
Cc: Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel
On 20/04/2026 14:57, Shawn Guo wrote:
> On Mon, Apr 20, 2026 at 01:56:46PM +0200, Krzysztof Kozlowski wrote:
>> On 20/04/2026 10:39, Shawn Guo wrote:
>>> On Mon, Apr 20, 2026 at 10:27:56AM +0200, Krzysztof Kozlowski wrote:
>>>> On 20/04/2026 09:33, Shawn Guo wrote:
>>>>> Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
>>>>> witha fallback on qcom,inline-crypto-engine.
>>>>
>>>> Don't explain what the diff is doing. Explain why. Why do you use fallback?
>>>>
>>>> What is Nord? It's nowhere explained. First posting was 1.5 months ago
>>>> and it did not provide any explanation. I don't see any information
>>>> being posted in the series sent now.
>>>
>>> I'm still checking internally to see how we can get the best socinfo
>>> patch describing Nord which is a SoC family covering both SA8997P and
>>> IQ10 variant. Hopefully I will get it soon.
>>
>> I found the DTS on:
>> https://github.com/qualcomm-linux/kernel-topics/commits/early/hwe/nord/
>> so it should be mentioned somewhere, which I kind of asked when we
>> discussed about adding compatibles used by that DTS. You would solve
>> yourself all my questions from three threads.
>
> Ah, I see. I thought only patches posted to list count.
That link is public posting of patches. Anyone can clone that repo, take
that branch and send DTS not even waiting for you, including case when
you do not continue with DTS after merging the ABI.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-20 13:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 7:33 [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
2026-04-20 8:27 ` Krzysztof Kozlowski
2026-04-20 8:39 ` Shawn Guo
2026-04-20 11:56 ` Krzysztof Kozlowski
2026-04-20 12:57 ` Shawn Guo
2026-04-20 13:47 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox