From: Kathiravan T <quic_kathirav@quicinc.com>
To: Elliot Berman <quic_eberman@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Mukesh Ojha" <quic_mojha@quicinc.com>,
Kalle Valo <kvalo@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
<quic_anusha@quicinc.com>, <quic_saahtoma@quicinc.com>
Subject: Re: [PATCH V5 0/3] Introduce the read-modify-write API to collect
Date: Tue, 25 Jul 2023 15:25:55 +0530 [thread overview]
Message-ID: <eb723e27-de44-ed19-b331-41441c5cc755@quicinc.com> (raw)
In-Reply-To: <cc1fec2c-1356-2716-86cf-5b76c18ec1dd@quicinc.com>
On 7/25/2023 12:35 AM, Elliot Berman wrote:
>
>
> On 7/20/2023 12:04 AM, Kathiravan T wrote:
>> On IPQ platforms, to collect the crashdump, we need to just modify the
>> DLOAD bit in the TCSR register. Current infrastructure, overwrites the
>> entire regiter value when enabling the crashdump feature, which leads to
>> crashdump not gets collected. This series introduce the
>> qcom_scm_io_update_field API to achieve the same.
>>
>
> I don't think you describe patch 2 in the subject line or cover
> letter. As best I can tell, Patches 2 and 3 are independent. They're
> similar only in that they both depend on patch 1.
Yeah. I missed that part. I'm thinking of dropping the 2nd patch and
send only the patch 1 and patch 3 in the next spin. Once the patch 1 and
the another pinctrl patch which Bjorn's is referring [1] (Hopefully, If
I am not wrong) is landed in linux-next, I can send out the patch 2
separately. Do let me know if this okay.
[1]
https://lore.kernel.org/linux-arm-msm/2d790f7e-b373-f0ee-d978-fb78bc4f1ed1@quicinc.com/
>
>> Intially this approach is posted by Poovendhan[1], later Mukesh
>> integrated this patch in his minidump support series[2]. Based on the
>> current feedback on the minidump series, seems it will take sometime to
>> get into a good shape, in the meantime these patches doesn't have any
>> dependency with the minidump series. As discussed with the Mukesh[3],
>> posting these 3 patches to enable the crashdump on IPQ chipsets.
>>
>> Since the current version of minidump series is V4, I'm posting this as
>> a V5. Please let me know if this should be V1.
>>
>> [1]
>> https://lore.kernel.org/linux-arm-msm/20230113160012.14893-4-quic_poovendh@quicinc.com/
>>
>>
>> [2]
>> https://lore.kernel.org/linux-arm-msm/1676990381-18184-3-git-send-email-quic_mojha@quicinc.com/
>>
>>
>> [3]
>> https://lore.kernel.org/linux-arm-msm/d77f5601-2b08-a7c7-1400-7ab68b8add3a@quicinc.com/
>>
>>
>>
>> Mukesh Ojha (3):
>> firmware: qcom_scm: provide a read-modify-write function
>> pinctrl: qcom: Use qcom_scm_io_update_field()
>> firmware: scm: Modify only the download bits in TCSR register
>>
>> drivers/firmware/qcom_scm.c | 26 ++++++++++++++++++++++++--
>> drivers/pinctrl/qcom/pinctrl-msm.c | 12 +++++-------
>> include/linux/firmware/qcom/qcom_scm.h | 2 ++
>> 3 files changed, 31 insertions(+), 9 deletions(-)
>>
prev parent reply other threads:[~2023-07-25 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 7:04 [PATCH V5 0/3] Introduce the read-modify-write API to collect Kathiravan T
2023-07-20 7:04 ` [PATCH V5 1/3] firmware: qcom_scm: provide a read-modify-write function Kathiravan T
2023-07-22 1:17 ` Trilok Soni
2023-07-23 13:55 ` Kathiravan T
2023-07-29 0:34 ` Guru Das Srinagesh
2023-07-24 19:05 ` Elliot Berman
2023-07-20 7:04 ` [PATCH V5 2/3] pinctrl: qcom: Use qcom_scm_io_update_field() Kathiravan T
2023-07-22 3:09 ` Bjorn Andersson
2023-07-23 13:48 ` Kathiravan T
2023-07-20 7:04 ` [PATCH V5 3/3] firmware: scm: Modify only the download bits in TCSR register Kathiravan T
2023-07-21 23:15 ` kernel test robot
2023-07-24 19:05 ` Elliot Berman
2023-07-25 10:24 ` Kathiravan T
2023-07-20 7:08 ` [PATCH V5 0/3] Introduce the read-modify-write API to collect Kathiravan T
2023-07-24 19:05 ` Elliot Berman
2023-07-25 9:55 ` Kathiravan T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb723e27-de44-ed19-b331-41441c5cc755@quicinc.com \
--to=quic_kathirav@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=kvalo@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=quic_anusha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=quic_saahtoma@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox