* Re: [PATCH] media: iris: fix QCOM_MDT_LOADER dependency
2026-02-05 14:56 ` [PATCH] media: iris: fix QCOM_MDT_LOADER dependency Arnd Bergmann
@ 2026-02-05 14:58 ` Konrad Dybcio
2026-02-06 11:26 ` Bryan O'Donoghue
2026-03-02 10:51 ` Dikshita Agarwal
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-02-05 14:58 UTC (permalink / raw)
To: Arnd Bergmann, Vikash Garodia, Dikshita Agarwal,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Clark
Cc: Arnd Bergmann, Abhinav Kumar, Hans Verkuil, Stefan Schmidt,
linux-media, linux-arm-msm, linux-kernel
On 2/5/26 3:56 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y,
> the kernel fails to link:
>
> x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
> iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size'
> iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load'
>
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
I see that drm/msm (+Rob) does that too, but perhaps for a reason (old
I.MX platforms with Adreno)
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: iris: fix QCOM_MDT_LOADER dependency
2026-02-05 14:56 ` [PATCH] media: iris: fix QCOM_MDT_LOADER dependency Arnd Bergmann
2026-02-05 14:58 ` Konrad Dybcio
@ 2026-02-06 11:26 ` Bryan O'Donoghue
2026-03-02 10:51 ` Dikshita Agarwal
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2026-02-06 11:26 UTC (permalink / raw)
To: Arnd Bergmann, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab
Cc: Arnd Bergmann, Abhinav Kumar, Hans Verkuil, Stefan Schmidt,
linux-media, linux-arm-msm, linux-kernel
On 05/02/2026 14:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y,
> the kernel fails to link:
>
> x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
> iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size'
> iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load'
>
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/platform/qcom/iris/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig
> index 3c803a05305a..5498f48362d1 100644
> --- a/drivers/media/platform/qcom/iris/Kconfig
> +++ b/drivers/media/platform/qcom/iris/Kconfig
> @@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS
> depends on VIDEO_DEV
> depends on ARCH_QCOM || COMPILE_TEST
> select V4L2_MEM2MEM_DEV
> - select QCOM_MDT_LOADER if ARCH_QCOM
> + select QCOM_MDT_LOADER
> select QCOM_SCM
> select VIDEOBUF2_DMA_CONTIG
> help
> --
> 2.39.5
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: iris: fix QCOM_MDT_LOADER dependency
2026-02-05 14:56 ` [PATCH] media: iris: fix QCOM_MDT_LOADER dependency Arnd Bergmann
2026-02-05 14:58 ` Konrad Dybcio
2026-02-06 11:26 ` Bryan O'Donoghue
@ 2026-03-02 10:51 ` Dikshita Agarwal
2 siblings, 0 replies; 4+ messages in thread
From: Dikshita Agarwal @ 2026-03-02 10:51 UTC (permalink / raw)
To: Arnd Bergmann, Vikash Garodia, Bryan O'Donoghue,
Mauro Carvalho Chehab
Cc: Arnd Bergmann, Abhinav Kumar, Hans Verkuil, Stefan Schmidt,
linux-media, linux-arm-msm, linux-kernel
On 2/5/2026 8:26 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y,
> the kernel fails to link:
>
> x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
> iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size'
> iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load'
>
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/platform/qcom/iris/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig
> index 3c803a05305a..5498f48362d1 100644
> --- a/drivers/media/platform/qcom/iris/Kconfig
> +++ b/drivers/media/platform/qcom/iris/Kconfig
> @@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS
> depends on VIDEO_DEV
> depends on ARCH_QCOM || COMPILE_TEST
> select V4L2_MEM2MEM_DEV
> - select QCOM_MDT_LOADER if ARCH_QCOM
> + select QCOM_MDT_LOADER
> select QCOM_SCM
> select VIDEOBUF2_DMA_CONTIG
> help
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Thanks,
Dikshita
^ permalink raw reply [flat|nested] 4+ messages in thread