* [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout
@ 2018-11-06 4:28 Tao Ren
2018-11-08 0:02 ` Andrew Jeffery
0 siblings, 1 reply; 5+ messages in thread
From: Tao Ren @ 2018-11-06 4:28 UTC (permalink / raw)
To: linux-aspeed
This is the layout used by Facebook BMC systems. It describes the fixed
flash layout of a 32MB mtd device.
Signed-off-by: Tao Ren <taoren@fb.com>
---
Changes since v1:
- adding facebook copyright.
.../boot/dts/facebook-bmc-flash-layout.dtsi | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi
diff --git a/arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi b/arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi
new file mode 100644
index 000000000000..94039d7b7de5
--- /dev/null
+++ b/arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright (c) 2018 Facebook Inc.
+
+partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ u-boot at 0 {
+ reg = <0x0 0x60000>;
+ label = "u-boot";
+ };
+
+ u-boot-env at 60000 {
+ reg = <0x60000 0x20000>;
+ label = "env";
+ };
+
+ fit at 80000 {
+ reg = <0x80000 0x1b80000>;
+ label = "fit";
+ };
+
+ data0 at 1c00000 {
+ reg = <0x1c00000 0x400000>;
+ label = "data0";
+ };
+
+ flash0 at 0 {
+ reg = <0x0 0x2000000>;
+ label = "flash0";
+ };
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout
2018-11-06 4:28 [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout Tao Ren
@ 2018-11-08 0:02 ` Andrew Jeffery
2018-11-08 0:18 ` Tao Ren
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2018-11-08 0:02 UTC (permalink / raw)
To: linux-aspeed
Hi Tao,
On Tue, 6 Nov 2018, at 14:58, Tao Ren wrote:
> This is the layout used by Facebook BMC systems. It describes the fixed
> flash layout of a 32MB mtd device.
>
> Signed-off-by: Tao Ren <taoren@fb.com>
> ---
> Changes since v1:
> - adding facebook copyright.
>
> .../boot/dts/facebook-bmc-flash-layout.dtsi | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi
>
> diff --git a/arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi b/arch/
> arm/boot/dts/facebook-bmc-flash-layout.dtsi
> new file mode 100644
> index 000000000000..94039d7b7de5
> --- /dev/null
> +++ b/arch/arm/boot/dts/facebook-bmc-flash-layout.dtsi
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright (c) 2018 Facebook Inc.
> +
> +partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + u-boot at 0 {
> + reg = <0x0 0x60000>;
> + label = "u-boot";
> + };
> +
> + u-boot-env at 60000 {
> + reg = <0x60000 0x20000>;
> + label = "env";
> + };
> +
> + fit at 80000 {
> + reg = <0x80000 0x1b80000>;
> + label = "fit";
> + };
> +
> + data0 at 1c00000 {
> + reg = <0x1c00000 0x400000>;
> + label = "data0";
> + };
> +
> + flash0 at 0 {
> + reg = <0x0 0x2000000>;
> + label = "flash0";
> + };
Is this necessary? Isn't the same thing achieved with the /dev/mtd0 device?
Cheers,
Andrew
> +};
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout
2018-11-08 0:02 ` Andrew Jeffery
@ 2018-11-08 0:18 ` Tao Ren
2018-11-08 1:45 ` Andrew Jeffery
0 siblings, 1 reply; 5+ messages in thread
From: Tao Ren @ 2018-11-08 0:18 UTC (permalink / raw)
To: linux-aspeed
On 11/7/18 4:02 PM, Andrew Jeffery wrote:
>> +partitions {
>> + compatible = "fixed-partitions";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + u-boot at 0 {
>> + reg = <0x0 0x60000>;
>> + label = "u-boot";
>> + };
>> +
>> + u-boot-env at 60000 {
>> + reg = <0x60000 0x20000>;
>> + label = "env";
>> + };
>> +
>> + fit at 80000 {
>> + reg = <0x80000 0x1b80000>;
>> + label = "fit";
>> + };
>> +
>> + data0 at 1c00000 {
>> + reg = <0x1c00000 0x400000>;
>> + label = "data0";
>> + };
>> +
>> + flash0 at 0 {
>> + reg = <0x0 0x2000000>;
>> + label = "flash0";
>> + };
>
> Is this necessary? Isn't the same thing achieved with the /dev/mtd0 device?
Hi Andrew,
Thank you for the review! The new layout file is needed mainly because of "data0" partition: several facebook platforms use the partition as "persistent" storage.
As for "flash0", technically it's not needed (as you pointed out, /dev/mtd0 covers the entire flash if master_partition is enabled). It's still here to avoid breaking some legacy applications.
Thanks,
Tao Ren
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout
2018-11-08 0:18 ` Tao Ren
@ 2018-11-08 1:45 ` Andrew Jeffery
2018-11-08 2:31 ` Tao Ren
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2018-11-08 1:45 UTC (permalink / raw)
To: linux-aspeed
On Thu, 8 Nov 2018, at 10:48, Tao Ren wrote:
> On 11/7/18 4:02 PM, Andrew Jeffery wrote:
> >> +partitions {
> >> + compatible = "fixed-partitions";
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> +
> >> + u-boot at 0 {
> >> + reg = <0x0 0x60000>;
> >> + label = "u-boot";
> >> + };
> >> +
> >> + u-boot-env at 60000 {
> >> + reg = <0x60000 0x20000>;
> >> + label = "env";
> >> + };
> >> +
> >> + fit at 80000 {
> >> + reg = <0x80000 0x1b80000>;
> >> + label = "fit";
> >> + };
> >> +
> >> + data0 at 1c00000 {
> >> + reg = <0x1c00000 0x400000>;
> >> + label = "data0";
> >> + };
> >> +
> >> + flash0 at 0 {
> >> + reg = <0x0 0x2000000>;
> >> + label = "flash0";
> >> + };
> >
> > Is this necessary? Isn't the same thing achieved with the /dev/mtd0 device?
>
> Hi Andrew,
>
> Thank you for the review! The new layout file is needed mainly because
> of "data0" partition: several facebook platforms use the partition as
> "persistent" storage.
>
> As for "flash0", technically it's not needed (as you pointed out, /dev/
> mtd0 covers the entire flash if master_partition is enabled). It's still
> here to avoid breaking some legacy applications.
This is what I expected. I think it might be worth adding a comment, given
you are respinning the series to address my comments on the board
devicetree patch.
Anyway, thanks for the clarification.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout
2018-11-08 1:45 ` Andrew Jeffery
@ 2018-11-08 2:31 ` Tao Ren
0 siblings, 0 replies; 5+ messages in thread
From: Tao Ren @ 2018-11-08 2:31 UTC (permalink / raw)
To: linux-aspeed
On 11/7/18 5:45 PM, Andrew Jeffery wrote:
>>> Is this necessary? Isn't the same thing achieved with the /dev/mtd0 device?
>>
>> Hi Andrew,
>>
>> Thank you for the review! The new layout file is needed mainly because
>> of "data0" partition: several facebook platforms use the partition as
>> "persistent" storage.
>>
>> As for "flash0", technically it's not needed (as you pointed out, /dev/
>> mtd0 covers the entire flash if master_partition is enabled). It's still
>> here to avoid breaking some legacy applications.
>
> This is what I expected. I think it might be worth adding a comment, given
> you are respinning the series to address my comments on the board
> devicetree patch.
>
> Anyway, thanks for the clarification.
>
> Andrew
Sure Andrew. I will add some comments and send out 2 updated patches together (most likely sometime tomorrow).
Thanks,
Tao Ren
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-08 2:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-06 4:28 [PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout Tao Ren
2018-11-08 0:02 ` Andrew Jeffery
2018-11-08 0:18 ` Tao Ren
2018-11-08 1:45 ` Andrew Jeffery
2018-11-08 2:31 ` Tao Ren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox