From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 04/10] media: aspeed: remove IRQF_SHARED flag
Date: Fri, 31 May 2019 15:15:42 -0700 [thread overview]
Message-ID: <20190531221548.14757-5-jae.hyun.yoo@linux.intel.com> (raw)
In-Reply-To: <20190531221548.14757-1-jae.hyun.yoo@linux.intel.com>
Video Engine has a dedicated interrupt line so this driver doesn't
need to use IRQF_SHARED flag so remove it. Also, it'd be good for
following what Thomas recommended in the IRQF_ONESHOT support
patch like below:
"Note that for now IRQF_ONESHOT cannot be used with IRQF_SHARED to
avoid complex accounting mechanisms."
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
---
v2 -> v3:
None.
v1 -> v2:
None.
drivers/media/platform/aspeed-video.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index f7db8969c8f2..d1b541409544 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -1601,8 +1601,7 @@ static int aspeed_video_init(struct aspeed_video *video)
}
rc = devm_request_threaded_irq(dev, irq, NULL, aspeed_video_irq,
- IRQF_ONESHOT | IRQF_SHARED, DEVICE_NAME,
- video);
+ IRQF_ONESHOT, DEVICE_NAME, video);
if (rc < 0) {
dev_err(dev, "Unable to request IRQ %d\n", irq);
return rc;
--
2.21.0
next prev parent reply other threads:[~2019-05-31 22:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 22:15 [PATCH v3 00/10] Improve stability and add bug fixes of Aspeed video engine driver Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 01/10] media: aspeed: fix a kernel warning on clk control Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 02/10] media: aspeed: refine clock control logic Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 03/10] media: aspeed: change irq to threaded irq Jae Hyun Yoo
2019-05-31 22:15 ` Jae Hyun Yoo [this message]
2019-05-31 22:15 ` [PATCH v3 05/10] media: aspeed: reduce noisy log printing outs Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 06/10] media: aspeed: remove checking of VE_INTERRUPT_CAPTURE_COMPLETE Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 07/10] media: aspeed: refine interrupt handling logic Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 08/10] media: aspeed: remove source buffer allocation before mode detection Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 09/10] media: aspeed: use different delays for triggering VE H/W reset Jae Hyun Yoo
2019-05-31 22:15 ` [PATCH v3 10/10] media: aspeed: add a workaround to fix a silicon bug Jae Hyun Yoo
2019-06-06 0:53 ` Jae Hyun Yoo
2019-06-12 7:17 ` Hans Verkuil
2019-06-12 15:03 ` Eddie James
2019-06-12 16:13 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531221548.14757-5-jae.hyun.yoo@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox