From: Jacky Huang <jackyhuang@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <andrew@codeconstruct.com.au>, <joel@jms.id.au>,
<krzysztof.kozlowski@oss.qualcomm.com>, <conor+dt@kernel.org>,
<andrew@lunn.ch>, <devicetree@vger.kernel.org>,
<linux-aspeed@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC
Date: Wed, 29 Jul 2026 15:06:09 +0900 [thread overview]
Message-ID: <20260729060612.1085870-1-jackyhuang@nvidia.com> (raw)
In-Reply-To: <20260728143952.GA2121505-robh@kernel.org>
Hi Rob,
Thank you very much for the review.
On Tue, Jul 28, 2026 at 09:39:52AM -0500, Rob Herring wrote:
> > + cp2112g: device@2 {
>
> This and other devices should have a compatible string and associated
> schema. The hub probably should too.
Will fix in v5.
> > + flash@0 {
>
> Needs a compatible.
The flash@0 node augments the corresponding node defined in
aspeed-g6.dtsi, which already carries compatible = "jedec,spi-nor",
so the compatible is inherited. The same applies to the flash@0
under &spi2.
> > + status = "okay";
>
> okay is the default, so not needed.
The flash@0 node in aspeed-g6.dtsi is status = "disabled", so the
board file needs status = "okay" to enable it.
Jacky
next prev parent reply other threads:[~2026-07-29 23:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 8:55 [PATCH v4 0/2] Add device tree for NVIDIA VR-NVL BMC Jacky Huang
2026-07-28 8:55 ` [PATCH v4 1/2] dt-bindings: arm: aspeed: Add " Jacky Huang
2026-07-28 8:55 ` [PATCH v4 2/2] ARM: dts: " Jacky Huang
2026-07-28 14:39 ` Rob Herring
2026-07-29 6:06 ` Jacky Huang [this message]
2026-07-29 6:16 ` Krzysztof Kozlowski
2026-07-29 8:40 ` Jacky Huang
2026-07-29 13:17 ` Rob Herring
2026-07-30 10:24 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729060612.1085870-1-jackyhuang@nvidia.com \
--to=jackyhuang@nvidia.com \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox