Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jacky Huang <jackyhuang@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Andrew Jeffery <andrew@codeconstruct.com.au>,
	Joel Stanley <joel@jms.id.au>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	<devicetree@vger.kernel.org>, <linux-aspeed@lists.ozlabs.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC
Date: Wed, 29 Jul 2026 17:40:10 +0900	[thread overview]
Message-ID: <20260729084013.1104891-1-jackyhuang@nvidia.com> (raw)
In-Reply-To: <d8927b08-f743-4b1c-85ad-f64b9e5b326f@oss.qualcomm.com>

Hi Krzysztof,

On Wed, Jul 29, 2026 at 08:16:52AM +0200, Krzysztof Kozlowski wrote:
> Why are you extending existing nodes that way instead of phandle/label?
> You write confusing code, so that's why you have such comments.

Thank you for pointing this out. I agree that the current form is unclear.

For v5, I plan to add source labels to the existing flash nodes in
aspeed-g6.dtsi:

    fmc: spi@1e620000 {
            fmc_flash0: flash@0 {
                    ...
            };
    };

    spi2: spi@1e631000 {
            spi2_flash0: flash@0 {
                    ...
            };
    };

The board DTS will then reference them directly:

    &fmc_flash0 {
            ...
    };

    &spi2_flash0 {
            ...
    };

This should make the references to the existing nodes explicit.

Best,
Jacky


  reply	other threads:[~2026-07-29 23:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  8:55 [PATCH v4 0/2] Add device tree for NVIDIA VR-NVL BMC Jacky Huang
2026-07-28  8:55 ` [PATCH v4 1/2] dt-bindings: arm: aspeed: Add " Jacky Huang
2026-07-28  8:55 ` [PATCH v4 2/2] ARM: dts: " Jacky Huang
2026-07-28 14:39   ` Rob Herring
2026-07-29  6:06     ` Jacky Huang
2026-07-29  6:16       ` Krzysztof Kozlowski
2026-07-29  8:40         ` Jacky Huang [this message]
2026-07-29 13:17       ` Rob Herring
2026-07-30 10:24         ` Jacky Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729084013.1104891-1-jackyhuang@nvidia.com \
    --to=jackyhuang@nvidia.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox