public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Tony Jones <tonyj@suse.de>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] audit: fix external header definitions for gcc10
Date: Fri, 10 Jan 2020 21:18:03 -0500	[thread overview]
Message-ID: <1871063.F7JoL3MBZj@x2> (raw)
In-Reply-To: <20200111000346.GA22149@suse.de>

On Friday, January 10, 2020 7:03:47 PM EST Tony Jones wrote:
> Header definitions need to be external when building with -fno-common
> (which is default in GCC 10).

Applied. Thanks!

-Steve

> (.text+0x0): multiple definition of `event_node_list'; ausearch.o (symbol
> from plugin):(.text+0x0): first defined here [   60s]
> /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld:
> ausearch-time.o (symbol from plugin): in function `lookup_time':
> 
> Fixes: ff25054df7ed
> ---
>  src/ausearch-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ausearch-common.h b/src/ausearch-common.h
> index 6669203..3040547 100644
> --- a/src/ausearch-common.h
> +++ b/src/ausearch-common.h
> @@ -50,7 +50,7 @@ extern pid_t event_pid;
>  extern int event_exact_match;
>  extern uid_t event_uid, event_euid, event_loginuid;
>  extern const char *event_tuid, *event_teuid, *event_tauid;
> -slist *event_node_list;
> +extern slist *event_node_list;
>  extern const char *event_comm;
>  extern const char *event_filename;
>  extern const char *event_hostname;
> --
> 2.21.0

      reply	other threads:[~2020-01-11  2:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-11  0:03 [PATCH] audit: fix external header definitions for gcc10 Tony Jones
2020-01-11  2:18 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1871063.F7JoL3MBZj@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=tonyj@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox