* [PATCH] audit: fix external header definitions for gcc10
@ 2020-01-11 0:03 Tony Jones
2020-01-11 2:18 ` Steve Grubb
0 siblings, 1 reply; 2+ messages in thread
From: Tony Jones @ 2020-01-11 0:03 UTC (permalink / raw)
To: linux-audit
Header definitions need to be external when building with -fno-common (which is default in GCC 10).
(.text+0x0): multiple definition of `event_node_list'; ausearch.o (symbol from plugin):(.text+0x0): first defined here
[ 60s] /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: ausearch-time.o (symbol from plugin): in function `lookup_time':
Fixes: ff25054df7ed
---
src/ausearch-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ausearch-common.h b/src/ausearch-common.h
index 6669203..3040547 100644
--- a/src/ausearch-common.h
+++ b/src/ausearch-common.h
@@ -50,7 +50,7 @@ extern pid_t event_pid;
extern int event_exact_match;
extern uid_t event_uid, event_euid, event_loginuid;
extern const char *event_tuid, *event_teuid, *event_tauid;
-slist *event_node_list;
+extern slist *event_node_list;
extern const char *event_comm;
extern const char *event_filename;
extern const char *event_hostname;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] audit: fix external header definitions for gcc10
2020-01-11 0:03 [PATCH] audit: fix external header definitions for gcc10 Tony Jones
@ 2020-01-11 2:18 ` Steve Grubb
0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2020-01-11 2:18 UTC (permalink / raw)
To: Tony Jones; +Cc: linux-audit
On Friday, January 10, 2020 7:03:47 PM EST Tony Jones wrote:
> Header definitions need to be external when building with -fno-common
> (which is default in GCC 10).
Applied. Thanks!
-Steve
> (.text+0x0): multiple definition of `event_node_list'; ausearch.o (symbol
> from plugin):(.text+0x0): first defined here [ 60s]
> /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld:
> ausearch-time.o (symbol from plugin): in function `lookup_time':
>
> Fixes: ff25054df7ed
> ---
> src/ausearch-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ausearch-common.h b/src/ausearch-common.h
> index 6669203..3040547 100644
> --- a/src/ausearch-common.h
> +++ b/src/ausearch-common.h
> @@ -50,7 +50,7 @@ extern pid_t event_pid;
> extern int event_exact_match;
> extern uid_t event_uid, event_euid, event_loginuid;
> extern const char *event_tuid, *event_teuid, *event_tauid;
> -slist *event_node_list;
> +extern slist *event_node_list;
> extern const char *event_comm;
> extern const char *event_filename;
> extern const char *event_hostname;
> --
> 2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-11 2:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-11 0:03 [PATCH] audit: fix external header definitions for gcc10 Tony Jones
2020-01-11 2:18 ` Steve Grubb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox