From: Eric Paris <eparis@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH 04/14] fixup! audit: convert audit_exe to audit_fsnotify
Date: Wed, 18 Jun 2014 09:38:22 -0400 [thread overview]
Message-ID: <20140618093822.368a9bb1@flatline.rdu.redhat.com> (raw)
In-Reply-To: <69becd9fa692980a8852bafa01f08971330846d7.1403060033.git.rgb@redhat.com>
On Tue, 17 Jun 2014 23:09:39 -0400
Richard Guy Briggs <rgb@redhat.com> wrote:
> Remove unnecessary space.
> ---
> kernel/auditfilter.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 30091ce..94b6af1 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -551,7 +551,6 @@ static struct audit_entry
> *audit_data_to_entry(struct audit_rule_data *data, break;
> case AUDIT_EXE:
> case AUDIT_EXE_CHILDREN:
> -
> if (entry->rule.exe || f->val > PATH_MAX)
> goto exit_free;
> str = audit_unpack_string(&bufp, &remain,
> f->val);
For patches like these, would you rather I just fold it into my patch
to keep a clean history, or would you rather I apply this little
whitespace change? (obviously fixing things like the subject)
next prev parent reply other threads:[~2014-06-18 13:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 3:09 [PATCH 00/14] audit by executable name Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 01/14] audit: implement audit by executable Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 02/14] audit: clean simple fsnotify implementation Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 03/14] audit: convert audit_exe to audit_fsnotify Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 04/14] fixup! " Richard Guy Briggs
2014-06-18 13:38 ` Eric Paris [this message]
2014-06-18 20:18 ` Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 05/14] fixup! audit: clean simple fsnotify implementation Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 06/14] audit: avoid double copying the audit_exe path string Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 07/14] fixup! audit: convert audit_exe to audit_fsnotify Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 08/14] fixup! audit: clean simple fsnotify implementation Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 09/14] audit: put rule existence check in canonical order Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 10/14] fixup! audit: implement audit by executable Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 11/14] " Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 12/14] fixup! audit: clean simple fsnotify implementation Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 13/14] audit: continue fleshing out audit by exe Richard Guy Briggs
2014-06-18 14:08 ` Eric Paris
2014-06-25 20:19 ` Richard Guy Briggs
2014-06-18 3:09 ` [PATCH 14/14] audit: enable audit_get/put_mark() Richard Guy Briggs
2014-06-18 14:09 ` Eric Paris
2014-06-18 20:21 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618093822.368a9bb1@flatline.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox