* [PATCH] audit: less stack usage for /proc/*/loginuid
@ 2016-10-29 16:04 Alexey Dobriyan
2016-11-02 6:10 ` Richard Guy Briggs
2016-11-03 21:28 ` Paul Moore
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2016-10-29 16:04 UTC (permalink / raw)
To: paul, eparis; +Cc: linux-audit
%u requires 10 characters at most not 20.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/proc/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1243,7 +1243,7 @@ static const struct file_operations proc_oom_score_adj_operations = {
};
#ifdef CONFIG_AUDITSYSCALL
-#define TMPBUFLEN 21
+#define TMPBUFLEN 11
static ssize_t proc_loginuid_read(struct file * file, char __user * buf,
size_t count, loff_t *ppos)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] audit: less stack usage for /proc/*/loginuid
2016-10-29 16:04 [PATCH] audit: less stack usage for /proc/*/loginuid Alexey Dobriyan
@ 2016-11-02 6:10 ` Richard Guy Briggs
2016-11-03 21:28 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Richard Guy Briggs @ 2016-11-02 6:10 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-audit
On 2016-10-29 19:04, Alexey Dobriyan wrote:
> %u requires 10 characters at most not 20.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Ack, looks reasonable to me. This has been there from the original
commit 1e2d1492e178 Serge Hallyn, Feb 2005.
> ---
>
> fs/proc/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -1243,7 +1243,7 @@ static const struct file_operations proc_oom_score_adj_operations = {
> };
>
> #ifdef CONFIG_AUDITSYSCALL
> -#define TMPBUFLEN 21
> +#define TMPBUFLEN 11
> static ssize_t proc_loginuid_read(struct file * file, char __user * buf,
> size_t count, loff_t *ppos)
> {
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Kernel Security Engineering, Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] audit: less stack usage for /proc/*/loginuid
2016-10-29 16:04 [PATCH] audit: less stack usage for /proc/*/loginuid Alexey Dobriyan
2016-11-02 6:10 ` Richard Guy Briggs
@ 2016-11-03 21:28 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2016-11-03 21:28 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-audit
On Sat, Oct 29, 2016 at 12:04 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> %u requires 10 characters at most not 20.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> fs/proc/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks reasonable to me, merged. Thanks.
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -1243,7 +1243,7 @@ static const struct file_operations proc_oom_score_adj_operations = {
> };
>
> #ifdef CONFIG_AUDITSYSCALL
> -#define TMPBUFLEN 21
> +#define TMPBUFLEN 11
> static ssize_t proc_loginuid_read(struct file * file, char __user * buf,
> size_t count, loff_t *ppos)
> {
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-03 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-29 16:04 [PATCH] audit: less stack usage for /proc/*/loginuid Alexey Dobriyan
2016-11-02 6:10 ` Richard Guy Briggs
2016-11-03 21:28 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox