From: Steve Grubb <sgrubb@redhat.com>
To: Yuri Gribov <tetra2005@gmail.com>
Cc: linux-audit@redhat.com
Subject: Re: [BUG?] Exported private symbols in audit-userspace
Date: Thu, 26 Apr 2018 07:48:35 -0400 [thread overview]
Message-ID: <20180426074835.487e23ae@ivy-bridge> (raw)
In-Reply-To: <CAJOtW+6XEG1CHBqFug=DbSYYyTRHjRmzrMyWJdCYs-T_hiR_gA@mail.gmail.com>
On Tue, 24 Apr 2018 21:32:33 +0100
Yuri Gribov <tetra2005@gmail.com> wrote:
> Hi,
>
> Is there a reason for functions below to not be marked as hidden? They
> are not present in audit's public headers so technically there's no
> reason to export them from shlibs. I can see that some symbols (e.g.
> `audit_strsplit_r`) were marked as hidden before but then exported in
> https://github.com/linux-audit/audit-userspace/commit/aa4ed834b7db2f8c7c929bbec9750a6285cf5e39#diff-6085c87000f8d0b00a22de1631168e4e
>
> _audit_archadded
> _audit_elf
> _audit_exeadded
> _audit_filterfsadded
> audit_msg
> _audit_permadded
> __audit_send
> audit_send
> audit_strsplit
> audit_strsplit_r
> _audit_syscalladded
> auparse_do_interpretation
> _auparse_free_interpretations
> auparse_interp_adjust_type
> _auparse_load_interpretations
> _auparse_lookup_interpretation
> __bss_start
> check_lru_cache
> compute_subject_key
> destroy_lru
> _edata
> _end
> _fini
> _init
> init_lru
> lru_evict
Thanks for pointing this out. The LRU symbols should not be public. I
fixed this in git. The rest are internal use that need to be public but
not advertised.
-Steve
> The issue was found using ShlibVisibilityChecker
> (https://github.com/yugr/ShlibVisibilityChecker).
>
> Best regards,
> Yury Gribov
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
prev parent reply other threads:[~2018-04-26 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 20:32 [BUG?] Exported private symbols in audit-userspace Yuri Gribov
2018-04-26 11:48 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426074835.487e23ae@ivy-bridge \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=tetra2005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox