From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>, Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] filterkey: add errormsg reporting
Date: Mon, 12 Jun 2017 20:02:25 -0400 [thread overview]
Message-ID: <4084249.yv8OCQJMUB@x2> (raw)
In-Reply-To: <1491302321-1048-1-git-send-email-rgb@redhat.com>
On Tuesday, April 4, 2017 6:38:41 AM EDT Richard Guy Briggs wrote:
> Call errormsg after processing filterkey to speed up debugging.
Applied. Thanks!
-Steve
> See: https://github.com/linux-audit/audit-userspace/issues/13
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> src/auditctl.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/auditctl.c b/src/auditctl.c
> index e112b16..04765f4 100644
> --- a/src/auditctl.c
> +++ b/src/auditctl.c
> @@ -1091,8 +1091,10 @@ process_keys:
> } else {
> /* Add this to the rule */
> int ret = audit_rule_fieldpair_data(&rule_new, cmd, flags);
> - if (ret < 0)
> + if (ret != 0) {
> + audit_number_to_errmsg(ret, cmd);
> retval = -1;
> + }
> free(cmd);
> }
> }
prev parent reply other threads:[~2017-06-13 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:38 [PATCH] filterkey: add errormsg reporting Richard Guy Briggs
2017-06-13 0:02 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4084249.yv8OCQJMUB@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=pmoore@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox