* [PATCH] filterkey: add errormsg reporting
@ 2017-04-04 10:38 Richard Guy Briggs
2017-06-13 0:02 ` Steve Grubb
0 siblings, 1 reply; 2+ messages in thread
From: Richard Guy Briggs @ 2017-04-04 10:38 UTC (permalink / raw)
To: linux-audit; +Cc: Richard Guy Briggs
Call errormsg after processing filterkey to speed up debugging.
See: https://github.com/linux-audit/audit-userspace/issues/13
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
src/auditctl.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/auditctl.c b/src/auditctl.c
index e112b16..04765f4 100644
--- a/src/auditctl.c
+++ b/src/auditctl.c
@@ -1091,8 +1091,10 @@ process_keys:
} else {
/* Add this to the rule */
int ret = audit_rule_fieldpair_data(&rule_new, cmd, flags);
- if (ret < 0)
+ if (ret != 0) {
+ audit_number_to_errmsg(ret, cmd);
retval = -1;
+ }
free(cmd);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] filterkey: add errormsg reporting
2017-04-04 10:38 [PATCH] filterkey: add errormsg reporting Richard Guy Briggs
@ 2017-06-13 0:02 ` Steve Grubb
0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2017-06-13 0:02 UTC (permalink / raw)
To: Richard Guy Briggs, Paul Moore; +Cc: linux-audit
On Tuesday, April 4, 2017 6:38:41 AM EDT Richard Guy Briggs wrote:
> Call errormsg after processing filterkey to speed up debugging.
Applied. Thanks!
-Steve
> See: https://github.com/linux-audit/audit-userspace/issues/13
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> src/auditctl.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/auditctl.c b/src/auditctl.c
> index e112b16..04765f4 100644
> --- a/src/auditctl.c
> +++ b/src/auditctl.c
> @@ -1091,8 +1091,10 @@ process_keys:
> } else {
> /* Add this to the rule */
> int ret = audit_rule_fieldpair_data(&rule_new, cmd, flags);
> - if (ret < 0)
> + if (ret != 0) {
> + audit_number_to_errmsg(ret, cmd);
> retval = -1;
> + }
> free(cmd);
> }
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-13 0:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-04 10:38 [PATCH] filterkey: add errormsg reporting Richard Guy Briggs
2017-06-13 0:02 ` Steve Grubb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox