Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael C Thompson <thompsmc@us.ibm.com>
To: Michael C Thompson <thompsmc@us.ibm.com>
Cc: Linux Audit <linux-audit@redhat.com>
Subject: Re: audit 1.2.2 released
Date: Wed, 17 May 2006 10:45:35 -0500	[thread overview]
Message-ID: <446B451F.7080704@us.ibm.com> (raw)
In-Reply-To: <446B420F.1070301@us.ibm.com>

Michael C Thompson wrote:
> Steve Grubb wrote:
>> Please let me know if there are any problems with this release.
> 
> With the current version of audit, auditctl -l only prints an equal, not 
> equal operator when it displays rules, while the rules in the kernel are 
> operating correctly, this is most an inconvenience, since is not 
> possible to tell what rules are really in the kernel.
> 
> The problem lies in the audit_print_reply logic not detecting the type 
> of the message (either AUDIT_LIST or AUDIT_LIST_RULE).
> 
> Below is a patch which adds this detection.
> 
> Thanks,
> Mike

Below is some testing between the original code and the patched code.

# auditctl -a entry,always -S chmod -F 'uid=100'
# auditctl -a entry,always -S chmod -F 'uid>200'
# auditctl -a entry,always -S chmod -F 'uid>=300'
# auditctl -a entry,always -S chmod -F 'uid!=400'
# auditctl -a entry,always -S chmod -F 'uid<500'
# auditctl -a entry,always -S chmod -F 'uid<=600'

# auditctl -l	[ audit-1.2.2 auditctl pre-patch]
LIST_RULES: entry,always uid=100 (0x64) syscall=chmod
LIST_RULES: entry,always uid=200 (0xc8) syscall=chmod
LIST_RULES: entry,always uid=300 (0x12c) syscall=chmod
LIST_RULES: entry,always uid=400 (0x190) syscall=chmod
LIST_RULES: entry,always uid=500 (0x1f4) syscall=chmod
LIST_RULES: entry,always uid=600 (0x258) syscall=chmod


# auditctl -l   [ audit-1.2.2 auditctl post-patch ]
LIST_RULES: entry,always uid=100 (0x64) syscall=chmod
LIST_RULES: entry,always uid>200 (0xc8) syscall=chmod
LIST_RULES: entry,always uid>=300 (0x12c) syscall=chmod
LIST_RULES: entry,always uid!=400 (0x190) syscall=chmod
LIST_RULES: entry,always uid<500 (0x1f4) syscall=chmod
LIST_RULES: entry,always uid<=600 (0x258) syscall=chmod

Thanks,
Mike

  reply	other threads:[~2006-05-17 15:45 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-12 21:26 audit 1.2.2 released Steve Grubb
2006-05-15 19:57 ` Michael C Thompson
2006-05-15 20:04   ` Steve Grubb
2006-05-15 20:14     ` Michael C Thompson
2006-05-16 14:53       ` Michael C Thompson
2006-05-16 15:23         ` Steve Grubb
2006-05-16 16:08           ` Michael C Thompson
2006-05-16 16:28             ` Steve Grubb
2006-05-16 15:34         ` Steve Grubb
2006-05-16 15:53           ` Linda Knippers
2006-05-16 17:23             ` Steve Grubb
2006-05-16 20:38               ` Michael C Thompson
2006-05-16 21:49                 ` Steve Grubb
2006-05-16 22:31                   ` Valdis.Kletnieks
2006-05-17 10:25                     ` Steve Grubb
2006-05-22 17:31               ` Steve Grubb
2006-05-22 19:15                 ` Xin Zhao
2006-05-22 19:24                   ` Steve Grubb
2006-05-22 19:37                     ` Xin Zhao
2006-05-22 19:47                       ` Steve Grubb
2006-05-22 20:15                         ` Xin Zhao
2006-05-23  6:56                       ` Amy Griffis
2006-05-23  3:43                         ` Xin Zhao
2006-05-23 15:11                           ` Steve Grubb
2006-05-23 16:24                 ` Michael C Thompson
2006-05-23 22:20                   ` Michael C Thompson
2006-05-23 23:05                     ` Linda Knippers
2006-05-24 19:44                       ` Michael C Thompson
2006-05-24 20:58                         ` James Antill
2006-05-25 13:48                           ` Michael C Thompson
2006-05-25 15:16                             ` James Antill
2006-05-25 15:22                               ` Michael C Thompson
2006-05-25 15:40                                 ` James Antill
2006-05-24 13:04                     ` Steve Grubb
2006-05-24 20:30                       ` Michael C Thompson
2006-05-17 15:32 ` Michael C Thompson
2006-05-17 15:45   ` Michael C Thompson [this message]
2006-05-17 21:12 ` Michael C Thompson
2006-05-17 21:23   ` Steve Grubb
2006-05-17 21:43     ` Michael C Thompson
2006-05-17 21:55       ` Steve Grubb
  -- strict thread matches above, loose matches on Subject: below --
2006-05-25 15:50 Chad Hanson
2006-05-26 16:05 ` Darrel Goeddel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446B451F.7080704@us.ibm.com \
    --to=thompsmc@us.ibm.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox