From: Bart Van Assche <bvanassche@acm.org>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH block-5.14] Revert "block/mq-deadline: Add cgroup support"
Date: Wed, 11 Aug 2021 13:22:20 -0700 [thread overview]
Message-ID: <00e13a7b-6009-a9d7-41ba-aae82f5813de@acm.org> (raw)
In-Reply-To: <YRQhlPBqAlkJdowG@mtj.duckdns.org>
On 8/11/21 12:14 PM, Tejun Heo wrote:
> On Wed, Aug 11, 2021 at 11:49:10AM -0700, Bart Van Assche wrote:
>> You write that this isn't the right way to collect per cgroup stats. What is
>> the "right way"? Has this been documented somewhere?
>
> Well, there's nothing specific to mq-deadline or any other elevator or
> controller about the stats that your patch collected and showed. That
> seems like a pretty straight forward sign that it likely doens't
> belong there.
Do you perhaps want these statistics to be reported via read-only cgroup
attributes of a new cgroup policy that is independent of any particular
I/O scheduler?
Thanks,
Bart.
next prev parent reply other threads:[~2021-08-11 20:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 17:41 [PATCH block-5.14] Revert "block/mq-deadline: Add cgroup support" Tejun Heo
2021-08-11 18:49 ` Bart Van Assche
2021-08-11 19:14 ` Tejun Heo
2021-08-11 20:22 ` Bart Van Assche [this message]
2021-08-12 17:51 ` Tejun Heo
2021-08-12 18:16 ` Bart Van Assche
2021-08-12 19:23 ` Tejun Heo
2021-08-13 2:18 ` Damien Le Moal
2021-08-13 16:29 ` Tejun Heo
2021-08-13 17:17 ` Bart Van Assche
2021-08-13 21:43 ` Tejun Heo
2021-08-13 17:15 ` Bart Van Assche
2021-08-12 18:56 ` Jens Axboe
2021-08-12 19:10 ` Tejun Heo
2021-08-11 19:48 ` Jens Axboe
2021-08-12 14:14 ` Oleksandr Natalenko
2021-08-12 15:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e13a7b-6009-a9d7-41ba-aae82f5813de@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox