public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH block-5.14] Revert "block/mq-deadline: Add cgroup support"
Date: Thu, 12 Aug 2021 11:16:37 -0700	[thread overview]
Message-ID: <631e7e18-52ca-9bec-0150-bac755e0ff24@acm.org> (raw)
In-Reply-To: <YRVfmWnOyPYl/okx@mtj.duckdns.org>

On 8/12/21 10:51 AM, Tejun Heo wrote:
> There's an almost fundamental conflict between ioprio and cgroup IO
> control. bfq layers it so that ioprio classes define the global
> priority above weights and then ioprio modifies the weights within
> each class. mq-deadline isn't cgroup aware and who knows what kind of
> priority inversions it's creating when its ioprio enforcement is
> interacting with other cgroup controllers.

Are you perhaps referring to the iocost and iolatency cgroup 
controllers? Is it ever useful to combine these controllers with the 
ioprio controller? The ioprio controller was introduced with the goal to 
provide the information to the storage controller about which I/O 
request to handle first. My understanding of the iocost and iolatency 
controllers is that these cgroup controllers decide in which order to 
process I/O requests. Neither controller has the last word over I/O 
order if the queue depth is larger than one, something that is essential 
to achieve reasonable performance.

Bart.

  reply	other threads:[~2021-08-12 18:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 17:41 [PATCH block-5.14] Revert "block/mq-deadline: Add cgroup support" Tejun Heo
2021-08-11 18:49 ` Bart Van Assche
2021-08-11 19:14   ` Tejun Heo
2021-08-11 20:22     ` Bart Van Assche
2021-08-12 17:51       ` Tejun Heo
2021-08-12 18:16         ` Bart Van Assche [this message]
2021-08-12 19:23           ` Tejun Heo
2021-08-13  2:18             ` Damien Le Moal
2021-08-13 16:29               ` Tejun Heo
2021-08-13 17:17                 ` Bart Van Assche
2021-08-13 21:43                   ` Tejun Heo
2021-08-13 17:15               ` Bart Van Assche
2021-08-12 18:56         ` Jens Axboe
2021-08-12 19:10           ` Tejun Heo
2021-08-11 19:48 ` Jens Axboe
2021-08-12 14:14   ` Oleksandr Natalenko
2021-08-12 15:50     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=631e7e18-52ca-9bec-0150-bac755e0ff24@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox