From: Tejun Heo <tj@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH block-5.14] Revert "block/mq-deadline: Add cgroup support"
Date: Wed, 11 Aug 2021 09:14:28 -1000 [thread overview]
Message-ID: <YRQhlPBqAlkJdowG@mtj.duckdns.org> (raw)
In-Reply-To: <035f8334-3b69-667d-be91-92dcab9dc887@acm.org>
Hello, Bart.
On Wed, Aug 11, 2021 at 11:49:10AM -0700, Bart Van Assche wrote:
> Agreed that I should have Cc-ed you on the cgroup patches. But where were
> you while my mq-deadline patch series was out for review? The first version
> of that patch series was published on May 27 and the patch series was merged
> on June 21 so there was almost one month time to post review feedback.
Regardless of where I've been, I can't really review things which
don't show up in my radar. The patches didn't even cc cgroups mailing
list. How would I know that I needed to review the patches?
> Additionally, the above description is not very helpful. If it is not
> allowed to add custom elements by adding more pd_stat_fn callbacks, why does
> that callback even exist? Why does the cgroup core not complain if a new
> policy is registered that defines a pd_stat_fn callback?
That part of the comment was on the specific fomatting that you used.
cgroup interface files follow a few styles to stay consistent and ease
parsing. Please refer to Documentation/admin-guide/cgroup-v2.rst.
> You write that this isn't the right way to collect per cgroup stats. What is
> the "right way"? Has this been documented somewhere?
Well, there's nothing specific to mq-deadline or any other elevator or
controller about the stats that your patch collected and showed. That
seems like a pretty straight forward sign that it likely doens't
belong there.
Thanks.
--
tejun
next prev parent reply other threads:[~2021-08-11 19:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 17:41 [PATCH block-5.14] Revert "block/mq-deadline: Add cgroup support" Tejun Heo
2021-08-11 18:49 ` Bart Van Assche
2021-08-11 19:14 ` Tejun Heo [this message]
2021-08-11 20:22 ` Bart Van Assche
2021-08-12 17:51 ` Tejun Heo
2021-08-12 18:16 ` Bart Van Assche
2021-08-12 19:23 ` Tejun Heo
2021-08-13 2:18 ` Damien Le Moal
2021-08-13 16:29 ` Tejun Heo
2021-08-13 17:17 ` Bart Van Assche
2021-08-13 21:43 ` Tejun Heo
2021-08-13 17:15 ` Bart Van Assche
2021-08-12 18:56 ` Jens Axboe
2021-08-12 19:10 ` Tejun Heo
2021-08-11 19:48 ` Jens Axboe
2021-08-12 14:14 ` Oleksandr Natalenko
2021-08-12 15:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRQhlPBqAlkJdowG@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox