From: Hannes Reinecke <hare@suse.de>
To: Ed Cashin <ed.cashin@acm.org>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org, hare@suse.com
Subject: Re: [PATCH 4/6] aoe: use device_add_disk_with_groups()
Date: Wed, 1 Aug 2018 08:57:12 +0200 [thread overview]
Message-ID: <03060ac8-57ce-9b11-cc7a-287264ac87b5@suse.de> (raw)
In-Reply-To: <CADvA-d=ESWUgJNpsSxdOhLp1amt3B9Aqy+GZ-i=t5zkLVn6RWg@mail.gmail.com>
On 08/01/2018 03:00 AM, Ed Cashin wrote:
> On Mon, Jul 30, 2018 at 3:12 AM Hannes Reinecke <hare@suse.de
> <mailto:hare@suse.de>> wrote:
>
> Use device_add_disk_with_groups() to avoid a race condition with
> udev during startup.
>
>
> I love the idea of getting rid of the race, but I am having trouble
> seeing what happened to the cleanup we had via sysfs_remove_group.
> You're storing a pointer to groups off the device, but I don't see it
> getting
> used for cleanup later in this patch set. Are you patching linux-next?
>
And that's the beauty of this patch: you don't need to free/unlink the
groups yourself.
Unlinking is done in the driver core via
device_del()->device_remove_attrs()->device_remove_groups().
So no separate patch needed.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-08-01 6:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:12 [PATCH 0/6] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-07-30 7:12 ` [PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() Hannes Reinecke
2018-07-30 8:56 ` Christoph Hellwig
2018-07-30 8:57 ` Hannes Reinecke
2018-08-13 19:53 ` Bart Van Assche
2018-07-30 7:12 ` [PATCH 2/6] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-07-30 8:57 ` Christoph Hellwig
2018-07-30 7:12 ` [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-07-30 8:59 ` Christoph Hellwig
2018-08-13 19:51 ` Bart Van Assche
2018-08-14 6:19 ` Hannes Reinecke
2018-07-30 7:12 ` [PATCH 4/6] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-07-30 9:01 ` Christoph Hellwig
2018-08-01 1:00 ` Ed Cashin
2018-08-01 6:57 ` Hannes Reinecke [this message]
2018-08-02 11:55 ` Ed Cashin
2018-07-30 7:12 ` [PATCH 5/6] zram: register default groups with device_add_disk() Hannes Reinecke
2018-07-30 9:02 ` Christoph Hellwig
2018-07-30 7:12 ` [PATCH 6/6] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-07-30 9:03 ` Christoph Hellwig
2018-07-31 15:11 ` Michael S. Tsirkin
2018-07-31 15:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03060ac8-57ce-9b11-cc7a-287264ac87b5@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=ed.cashin@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox