From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hare@suse.de" <hare@suse.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups
Date: Mon, 13 Aug 2018 19:51:16 +0000 [thread overview]
Message-ID: <a15ed0c9327ffd79615e2b9f0d1f2cec8e5d330a.camel@wdc.com> (raw)
In-Reply-To: <20180730071227.22887-4-hare@suse.de>
On Mon, 2018-07-30 at 09:12 +0200, Hannes Reinecke wrote:
> @@ -3061,11 +3066,7 @@ static void nvme_alloc_ns=
(struct nvme_ctrl *ctrl, unsigned nsid)
> =20
> nvme_get_ctrl(ctrl);
> =20
> - device_add_disk(ctrl->device, ns->disk, NULL);
> - if (sysfs_create_group(&disk_to_dev(ns->dis=
k)->kobj,
> - &nvme_ns_id_attr_group))
> - pr_warn("%s: failed to create sysfs group for identifica=
tion\n",
> - ns->disk->disk_name);
> + device_add_disk(ctrl->device, ns->disk, nvme_n=
s_id_attr_groups);
> if (ns->ndev && nvme_nvm_register_sysfs(ns))
> pr_warn("%s: failed to register lightnvm sysfs group for=
identification\n",
> ns->disk->disk_name);
Hello Hannes,
Have you noticed that nvme_nvm_register_sysfs() also registers =
sysfs attributes
and hence that the attributes registered by that function should be merged =
into
the nvme_ns_id_attr_groups array?
Thanks,
Bart.
next prev parent reply other threads:[~2018-08-13 19:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:12 [PATCH 0/6] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-07-30 7:12 ` [PATCH 1/6] genhd: drop 'bool' argument from __device_add_disk() Hannes Reinecke
2018-07-30 8:56 ` Christoph Hellwig
2018-07-30 8:57 ` Hannes Reinecke
2018-08-13 19:53 ` Bart Van Assche
2018-07-30 7:12 ` [PATCH 2/6] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-07-30 8:57 ` Christoph Hellwig
2018-07-30 7:12 ` [PATCH 3/6] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-07-30 8:59 ` Christoph Hellwig
2018-08-13 19:51 ` Bart Van Assche [this message]
2018-08-14 6:19 ` Hannes Reinecke
2018-07-30 7:12 ` [PATCH 4/6] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-07-30 9:01 ` Christoph Hellwig
2018-08-01 1:00 ` Ed Cashin
2018-08-01 6:57 ` Hannes Reinecke
2018-08-02 11:55 ` Ed Cashin
2018-07-30 7:12 ` [PATCH 5/6] zram: register default groups with device_add_disk() Hannes Reinecke
2018-07-30 9:02 ` Christoph Hellwig
2018-07-30 7:12 ` [PATCH 6/6] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-07-30 9:03 ` Christoph Hellwig
2018-07-31 15:11 ` Michael S. Tsirkin
2018-07-31 15:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a15ed0c9327ffd79615e2b9f0d1f2cec8e5d330a.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox